...So, in the course of working on the split-image support I ended up
refactoring the way that lorax is handling the arch-specific parts of
image creation (basically, the stuff in images.py).

The work is going on in the "treebuilder" branch (Warning: I'll probably
rebase it repeatedly, so expect to have to git pull -f if you clone it),
and the interesting bit is this:

http://git.fedorahosted.org/git/?p=lorax.git;a=commit;h=1cbe33d2d1ea5d0b1f6edf2376 b73b6cfa4e4c06

Basically, since we're using mako templates for making the runtime, why
not use them for making the boot images and the tree as well?

It's an incomplete, untested work-in-progress.. but it should have
approximately the same featureset as current master.
I think the templates are a lot easier to follow than the code in
images.py. For example, sparc.tmpl:
http://git.fedorahosted.org/git/?p=lorax.git;a=blob;hb=treebuilder;f=src/pylorax/sparc.tmpl

It's definitely a lot less code:
18 files changed, 709 insertions(+), 1680 deletions(-)

I should have it producing images early next week, so please withhold
judgement on the particulars of the code 'til I have it more complete.

But I wanted to give you all some idea what I was working on, and give
us a chance to talk about the overall design and such.

Let me know what you think!

-w

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

> Basically, since we're using mako templates for making the runtime, why
> not use them for making the boot images and the tree as well?
>
> It's an incomplete, untested work-in-progress.. but it should have
> approximately the same featureset as current master.
> I think the templates are a lot easier to follow than the code in
> images.py. For example, sparc.tmpl:
> http://git.fedorahosted.org/git/?p=lorax.git;a=blob;hb=treebuilder;f=src/pylorax/sparc.tmpl
>
> It's definitely a lot less code:
> 18 files changed, 709 insertions(+), 1680 deletions(-)

I've said this in IRC, but I'll say it in email just for whoever wasn't
paying attention. I think this is the right direction. We've already
bought into the mako template syntax, so we might as well use it. It
also looks like a reasonable thing to do, though I do have some minor
quibbles with certain pieces of syntax. But that's nothing that should
prevent you from continuing to work on it.

- Chris
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

I was planning to move almost everything into the template myself, after these split image patches went in, but you beat me to it, so I approve.

--

Martin Gracik

----- Original Message -----
> > Basically, since we're using mako templates for making the runtime,
> > why
> > not use them for making the boot images and the tree as well?
> >
> > It's an incomplete, untested work-in-progress.. but it should have
> > approximately the same featureset as current master.
> > I think the templates are a lot easier to follow than the code in
> > images.py. For example, sparc.tmpl:
> > http://git.fedorahosted.org/git/?p=lorax.git;a=blob;hb=treebuilder;f=src/pylorax/sparc.tmpl
> >
> > It's definitely a lot less code:
> > 18 files changed, 709 insertions(+), 1680 deletions(-)
>
> I've said this in IRC, but I'll say it in email just for whoever
> wasn't
> paying attention. I think this is the right direction. We've already
> bought into the mako template syntax, so we might as well use it. It
> also looks like a reasonable thing to do, though I do have some minor
> quibbles with certain pieces of syntax. But that's nothing that should
> prevent you from continuing to work on it.
>
> - Chris
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list