FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Kernel

 
 
LinkBack Thread Tools
 
Old 04-01-2011, 06:36 AM
Julien-externe BLACHE
 
Default Bug#620331: linux-2.6: igb driver fix for management card detection

Source: linux-2.6
Version: 2.6.32-31
Severity: wishlist
Tags: patch

Hi,

The igb driver up to 2.6.34 uses an incorrect check to detect the presence
of a management card sharing the network interface.

This can lead to a loss of network connectivity for the host and/or the
management card eventually.

The fix from upstream applies cleanly to 2.6.32 and is attached to this
bug report for convenience.

Thanks,

JB.

--
Consultant INTM - Debian Developer - TMI Calibre
EDF - DSP - CSP IT - ITS Rhône Alpes - C4S - CCNPS
04 69 65 68 56





Ce message et toutes les pièces jointes (ci-après le 'Message') sont établis à l'intention exclusive des destinataires et les informations qui y figurent sont strictement confidentielles. Toute utilisation de ce Message non conforme à sa destination, toute diffusion ou toute publication totale ou partielle, est interdite sauf autorisation expresse.

Si vous n'êtes pas le destinataire de ce Message, il vous est interdit de le copier, de le faire suivre, de le divulguer ou d'en utiliser tout ou partie. Si vous avez reçu ce Message par erreur, merci de le supprimer de votre système, ainsi que toutes ses copies, et de n'en garder aucune trace sur quelque support que ce soit. Nous vous remercions également d'en avertir immédiatement l'expéditeur par retour du message.

Il est impossible de garantir que les communications par messagerie électronique arrivent en temps utile, sont sécurisées ou dénuées de toute erreur ou virus.
__________________________________________________ __

This message and any attachments (the 'Message') are intended solely for the addressees. The information contained in this Message is confidential. Any use of information contained in this Message not in accord with its purpose, any dissemination or disclosure, either whole or partial, is prohibited except formal approval.

If you are not the addressee, you may not copy, forward, disclose or use any part of it. If you have received this message in error, please delete it and all copies from your system and notify the sender immediately by return message.

E-mail communication cannot be guaranteed to be timely secure, error or virus-free.
 
Old 04-03-2011, 04:06 AM
Ben Hutchings
 
Default Bug#620331: linux-2.6: igb driver fix for management card detection

On Fri, 2011-04-01 at 08:36 +0200, Julien-externe BLACHE wrote:
> Source: linux-2.6
> Version: 2.6.32-31
> Severity: wishlist
> Tags: patch
>
> Hi,
>
> The igb driver up to 2.6.34 uses an incorrect check to detect the presence
> of a management card sharing the network interface.
>
> This can lead to a loss of network connectivity for the host and/or the
> management card eventually.

How does the host lose connectivity?

I'm somewhat wary of cherry-picking such a patch without a very good
reason. Interactions with Lights Out Management seem to be particularly
prone to regression.

Ben.

> The fix from upstream applies cleanly to 2.6.32 and is attached to this
> bug report for convenience.
>
> Thanks,
>
> JB.
>

--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
 
Old 04-04-2011, 06:45 AM
Julien-externe BLACHE
 
Default Bug#620331: linux-2.6: igb driver fix for management card detection

ben@decadent.org.uk wrote on 04/03/2011 06:06:24 AM:

Hi Ben,

> > This can lead to a loss of network connectivity for the host and/or
the
> > management card eventually.
>
> How does the host lose connectivity?
>
> I'm somewhat wary of cherry-picking such a patch without a very good
> reason. Interactions with Lights Out Management seem to be particularly
> prone to regression.

In this specific case, the host isn't actually affected; only the MC can
lose connectivity if the driver doesn't detect the MC due to this bug and
powers down/resets the interface when it shouldn't.

Bugs that led to the host losing connectivity were fixed in or before
2.6.32.

This patch is entirely safe to apply, per 82575 documentation and the fact
that it comes straight from Intel

Thanks,

JB.

--
Consultant INTM - Debian Developer - TMI Calibre
EDF - DSP - CSP IT - ITS Rhône Alpes - C4S - CCNPS
04 69 65 68 56




Ce message et toutes les pièces jointes (ci-après le 'Message') sont établis à l'intention exclusive des destinataires et les informations qui y figurent sont strictement confidentielles. Toute utilisation de ce Message non conforme à sa destination, toute diffusion ou toute publication totale ou partielle, est interdite sauf autorisation expresse.

Si vous n'êtes pas le destinataire de ce Message, il vous est interdit de le copier, de le faire suivre, de le divulguer ou d'en utiliser tout ou partie. Si vous avez reçu ce Message par erreur, merci de le supprimer de votre système, ainsi que toutes ses copies, et de n'en garder aucune trace sur quelque support que ce soit. Nous vous remercions également d'en avertir immédiatement l'expéditeur par retour du message.

Il est impossible de garantir que les communications par messagerie électronique arrivent en temps utile, sont sécurisées ou dénuées de toute erreur ou virus.
__________________________________________________ __

This message and any attachments (the 'Message') are intended solely for the addressees. The information contained in this Message is confidential. Any use of information contained in this Message not in accord with its purpose, any dissemination or disclosure, either whole or partial, is prohibited except formal approval.

If you are not the addressee, you may not copy, forward, disclose or use any part of it. If you have received this message in error, please delete it and all copies from your system and notify the sender immediately by return message.

E-mail communication cannot be guaranteed to be timely secure, error or virus-free.




--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: OF3D6A7D69.8BEE67A7-ONC1257868.0024A180-C1257868.00252400@notes.edfgdf.fr">http://lists.debian.org/OF3D6A7D69.8BEE67A7-ONC1257868.0024A180-C1257868.00252400@notes.edfgdf.fr
 
Old 04-04-2011, 10:58 AM
Ben Hutchings
 
Default Bug#620331: linux-2.6: igb driver fix for management card detection

On Mon, Apr 04, 2011 at 08:45:40AM +0200, Julien-externe BLACHE wrote:
> ben@decadent.org.uk wrote on 04/03/2011 06:06:24 AM:
>
> Hi Ben,
>
> > > This can lead to a loss of network connectivity for the host and/or
> the
> > > management card eventually.
> >
> > How does the host lose connectivity?
> >
> > I'm somewhat wary of cherry-picking such a patch without a very good
> > reason. Interactions with Lights Out Management seem to be particularly
> > prone to regression.
>
> In this specific case, the host isn't actually affected; only the MC can
> lose connectivity if the driver doesn't detect the MC due to this bug and
> powers down/resets the interface when it shouldn't.
>
> Bugs that led to the host losing connectivity were fixed in or before
> 2.6.32.
>
> This patch is entirely safe to apply, per 82575 documentation and the fact
> that it comes straight from Intel

So do many interesting regressions.

I expect that at some point we'll want to update the driver to add new
hardware support, and then we'll pick this up along the way. Until
then, however, I'm not going to apply it.

Ben.

--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20110404105824.GI2268@decadent.org.uk">http://lists.debian.org/20110404105824.GI2268@decadent.org.uk
 
Old 04-04-2011, 12:08 PM
Julien-externe BLACHE
 
Default Bug#620331: linux-2.6: igb driver fix for management card detection

ben@decadent.org.uk wrote on 04/04/2011 12:58:24 PM:

Hi,

> I expect that at some point we'll want to update the driver to add new
> hardware support, and then we'll pick this up along the way. Until
> then, however, I'm not going to apply it.

I don't understand your decision; upgrading the whole driver is actually a
lot more likely to introduce regressions, seeing how this driver should be
at the very least 2 different drivers.

I've been working on the igb driver for 5 days, I've read every single
upstream commit affecting igb since before 2.6.32 and I've read the 82575
manuals from cover to cover.

If you want to see for yourself, Intel document ref. 324632-003, rev. 2.1
01/2011, pages 392-393 document the MANC register.

And that'll be it as far as I'm concerned.

JB.

--
Consultant INTM - Debian Developer - TMI Calibre
EDF - DSP - CSP IT - ITS Rhône Alpes - C4S - CCNPS
04 69 65 68 56




Ce message et toutes les pièces jointes (ci-après le 'Message') sont établis à l'intention exclusive des destinataires et les informations qui y figurent sont strictement confidentielles. Toute utilisation de ce Message non conforme à sa destination, toute diffusion ou toute publication totale ou partielle, est interdite sauf autorisation expresse.

Si vous n'êtes pas le destinataire de ce Message, il vous est interdit de le copier, de le faire suivre, de le divulguer ou d'en utiliser tout ou partie. Si vous avez reçu ce Message par erreur, merci de le supprimer de votre système, ainsi que toutes ses copies, et de n'en garder aucune trace sur quelque support que ce soit. Nous vous remercions également d'en avertir immédiatement l'expéditeur par retour du message.

Il est impossible de garantir que les communications par messagerie électronique arrivent en temps utile, sont sécurisées ou dénuées de toute erreur ou virus.
__________________________________________________ __

This message and any attachments (the 'Message') are intended solely for the addressees. The information contained in this Message is confidential. Any use of information contained in this Message not in accord with its purpose, any dissemination or disclosure, either whole or partial, is prohibited except formal approval.

If you are not the addressee, you may not copy, forward, disclose or use any part of it. If you have received this message in error, please delete it and all copies from your system and notify the sender immediately by return message.

E-mail communication cannot be guaranteed to be timely secure, error or virus-free.




--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: OF8A21B97A.D233715A-ONC1257868.0041E9E0-C1257868.0042B6D4@notes.edfgdf.fr">http://lists.debian.org/OF8A21B97A.D233715A-ONC1257868.0041E9E0-C1257868.0042B6D4@notes.edfgdf.fr
 
Old 04-04-2011, 12:19 PM
Ben Hutchings
 
Default Bug#620331: linux-2.6: igb driver fix for management card detection

On Mon, Apr 04, 2011 at 02:08:41PM +0200, Julien-externe BLACHE wrote:
> ben@decadent.org.uk wrote on 04/04/2011 12:58:24 PM:
>
> Hi,
>
> > I expect that at some point we'll want to update the driver to add new
> > hardware support, and then we'll pick this up along the way. Until
> > then, however, I'm not going to apply it.
>
> I don't understand your decision; upgrading the whole driver is actually a
> lot more likely to introduce regressions, seeing how this driver should be
> at the very least 2 different drivers.

It also results in a version that is closer to that tested by the
upstream developers (and users of more recent distributions).

> I've been working on the igb driver for 5 days, I've read every single
> upstream commit affecting igb since before 2.6.32 and I've read the 82575
> manuals from cover to cover.

So have you verified that there are no earlier or later changes related
to this?

> If you want to see for yourself, Intel document ref. 324632-003, rev. 2.1
> 01/2011, pages 392-393 document the MANC register.

It is naive to believe anything in a hardware manual without testing it!
I assume you have done that, though.

Ben.

> And that'll be it as far as I'm concerned.

--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20110404121959.GL2268@decadent.org.uk">http://lists.debian.org/20110404121959.GL2268@decadent.org.uk
 

Thread Tools




All times are GMT. The time now is 12:02 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org