Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Debian Kernel (http://www.linux-archive.org/debian-kernel/)
-   -   Bug#597581: update-initramfs should not set PATH (http://www.linux-archive.org/debian-kernel/429652-bug-597581-update-initramfs-should-not-set-path.html)

Ian Jackson 09-20-2010 11:25 PM

Bug#597581: update-initramfs should not set PATH
 
Package: initramfs-tools
Version: 0.92o

I've been doing some exciting initramfs hacking and I found that my
hook scripts were not working because although I call update-initramfs
with /usr/local/{sbin,bin} on my path, they were being removed.

$ dpkg -L initramfs-tools | xargs grep PATH
/usr/sbin/mkinitramfs:export PATH='/usr/bin:/sbin:/bin'
...

I don't think this is correct. It seems to have been introduced in
response to #409995, which was a complaint that (in effect) /sbin
could be missing from the path.

The correct approach would be to add /usr/sbin and /sbin to the end of
PATH, something like this:
export PATH="${PATH-/usr/local/bin:/bin:/usr/bin}:/sbin:/usr/sbin"

Ian.



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 19607.60776.313979.585012@chiark.greenend.org.uk"> http://lists.debian.org/19607.60776.313979.585012@chiark.greenend.org.uk

Michael Prokop 11-23-2011 12:02 PM

Bug#597581: update-initramfs should not set PATH
 
tags 597581 + pending
thanks

* Ian Jackson [Die Sep 21, 2010 at 12:25:28 +0100]:

> I've been doing some exciting initramfs hacking and I found that my
> hook scripts were not working because although I call update-initramfs
> with /usr/local/{sbin,bin} on my path, they were being removed.

> $ dpkg -L initramfs-tools | xargs grep PATH
> /usr/sbin/mkinitramfs:export PATH='/usr/bin:/sbin:/bin'
> ...

> I don't think this is correct. It seems to have been introduced in
> response to #409995, which was a complaint that (in effect) /sbin
> could be missing from the path.

> The correct approach would be to add /usr/sbin and /sbin to the end of
> PATH, something like this:
> export PATH="${PATH-/usr/local/bin:/bin:/usr/bin}:/sbin:/usr/sbin"

I'm sorry that no one seemed to care about this bug for so long.

AFAICS your fix is sitting in branch maks/path of
initramfs-tools.git, so marking this bug as pending, since it's
scheduled for review and inclusion for the upcoming release.

regards,
-mika-


All times are GMT. The time now is 10:04 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.