FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Kernel

 
 
LinkBack Thread Tools
 
Old 06-10-2010, 12:51 PM
Christoph Anton Mitterer
 
Default Bug#585419: drop vol_id related code from get_fstype in /usr/share/initramfs-tools/scripts/functions

Package: initramfs-tools
Version: 0.96.1
Severity: wishlist
Tags: patch


Hi.

May I suggest to drop the code from get_fstype in /usr/share/initramfs-tools/scripts/functions
that uses vol_id.

AFAIK vol_id is no longer available in udev or any other Debian package,
so this is dead code.

Attached is a patch for this.


Cheers,
Chris.
--- /usr/share/initramfs-tools/scripts/functions 2010-06-08 12:10:38.000000000 +0200
+++ /usr/share/initramfs-tools/scripts/functions 2010-06-10 14:50:25.822262987 +0200
@@ -285,13 +285,10 @@
local FS FSTYPE FSSIZE RET
FS="${1}"

- # vol_id has a more complete list of file systems,
- # but fstype is more robust
+ # blk_id has a more complete list of file systems, but fstype is more robust
eval $(fstype "${FS}" 2> /dev/null)
if [ "$FSTYPE" = "unknown" ] && command -v blkid >/dev/null 2>&1 ; then
FSTYPE=$(blkid -o value -s TYPE "${FS}")
- elif [ "$FSTYPE" = "unknown" ] && [ -x /lib/udev/vol_id ]; then
- FSTYPE=$(/lib/udev/vol_id -t "${FS}" 2> /dev/null)
fi
RET=$?
 
Old 06-10-2010, 01:35 PM
Michael Prokop
 
Default Bug#585419: drop vol_id related code from get_fstype in /usr/share/initramfs-tools/scripts/functions

* Christoph Anton Mitterer <calestyo@scientia.net> [Thu Jun 10, 2010 at 02:51:04PM +0200]:

> May I suggest to drop the code from get_fstype in /usr/share/initramfs-tools/scripts/functions
> that uses vol_id.

> AFAIK vol_id is no longer available in udev or any other Debian package,
> so this is dead code.

> Attached is a patch for this.

> --- /usr/share/initramfs-tools/scripts/functions 2010-06-08 12:10:38.000000000 +0200
> +++ /usr/share/initramfs-tools/scripts/functions 2010-06-10 14:50:25.822262987 +0200
> @@ -285,13 +285,10 @@
> local FS FSTYPE FSSIZE RET
> FS="${1}"

> - # vol_id has a more complete list of file systems,
> - # but fstype is more robust
> + # blk_id has a more complete list of file systems, but fstype is more robust
> eval $(fstype "${FS}" 2> /dev/null)
> if [ "$FSTYPE" = "unknown" ] && command -v blkid >/dev/null 2>&1 ; then
> FSTYPE=$(blkid -o value -s TYPE "${FS}")
> - elif [ "$FSTYPE" = "unknown" ] && [ -x /lib/udev/vol_id ]; then
> - FSTYPE=$(/lib/udev/vol_id -t "${FS}" 2> /dev/null)
> fi
> RET=$?

Yeah, it's just fallback code.

udev in lenny provides /lib/udev/vol_id, though lenny's e2fsprogs
(which is an essential package) also ships blkid - so this should be
save.

maks, any objections against applying this patch?

regards,
-mika-
 
Old 06-10-2010, 01:45 PM
Christoph Anton Mitterer
 
Default Bug#585419: drop vol_id related code from get_fstype in /usr/share/initramfs-tools/scripts/functions

On Thu, 2010-06-10 at 15:35 +0200, Michael Prokop wrote:
> Yeah, it's just fallback code.
Of course

> udev in lenny provides /lib/udev/vol_id, though lenny's e2fsprogs
> (which is an essential package) also ships blkid - so this should be
> save.
Well I'm fine with keeping it in lenny,.. but I guess it's gone in
suqeeze/sid.


Cheers,
Chris.
 
Old 06-11-2010, 12:54 PM
maximilian attems
 
Default Bug#585419: drop vol_id related code from get_fstype in /usr/share/initramfs-tools/scripts/functions

On Thu, Jun 10, 2010 at 03:45:30PM +0200, Christoph Anton Mitterer wrote:
> On Thu, 2010-06-10 at 15:35 +0200, Michael Prokop wrote:
> > Yeah, it's just fallback code.
> Of course

no point in axing.

> > udev in lenny provides /lib/udev/vol_id, though lenny's e2fsprogs
> > (which is an essential package) also ships blkid - so this should be
> > save.
> Well I'm fine with keeping it in lenny,.. but I guess it's gone in
> suqeeze/sid.

keep in mind the upgrade path of lenny, updating comment is fine mika.




--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20100611125401.GC19408@baikonur.stro.at">http://lists.debian.org/20100611125401.GC19408@baikonur.stro.at
 

Thread Tools




All times are GMT. The time now is 07:22 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org