FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Kernel

 
 
LinkBack Thread Tools
 
Old 06-09-2010, 10:17 PM
David Lehman
 
Default Make minimum shrink size 1 not 0 (#602442)

On Wed, 2010-06-09 at 14:22 -0700, Brian C. Lane wrote:
> Shrink dialog in autopart lets 0 get through. Lower level code
> doesn't like a length of 0 and throws and exception that isn't
> caught.

Ack, although I'm not sure a size of 1 is much more useful than 0.

Dave

>
> Resolves: rhbz#602442
> ---
> iw/autopart_type.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/iw/autopart_type.py b/iw/autopart_type.py
> index 9134e68..404fa74 100644
> --- a/iw/autopart_type.py
> +++ b/iw/autopart_type.py
> @@ -49,7 +49,7 @@ def whichToShrink(storage, intf):
> requpper = long(math.floor(part.format.currentSize))
>
> adj = shrinkSB.get_adjustment()
> - adj.lower = reqlower
> + adj.lower = max(1,reqlower)
> adj.upper = requpper
> adj.set_value(reqlower)
>


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 06-09-2010, 10:20 PM
"Brian C. Lane"
 
Default Make minimum shrink size 1 not 0 (#602442)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/09/2010 03:17 PM, David Lehman wrote:
> On Wed, 2010-06-09 at 14:22 -0700, Brian C. Lane wrote:
>> Shrink dialog in autopart lets 0 get through. Lower level code
>> doesn't like a length of 0 and throws and exception that isn't
>> caught.
>
> Ack, although I'm not sure a size of 1 is much more useful than 0.
>

True, but it keeps it from raising an exception

- --
Brian C. Lane <bcl@redhat.com>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBTBATyRF+jBaO/jp/AQICHAf7B7eoV0rFfwUzL+KzUhJngLtM3vTTh6Ov
NM9t9RqyO6QdyN/gBiImb8s2g0vL02bsAgzlXJWPOtPVyP0ntWdr6tLgbnrIb8PZ
o1mVV0AKWamyFSON5tpE7Rrsl5qbSViOG6T8ukVipbL9T6XPQC 8CHn42BVUJSdAP
5KclxWMXcujAR1IzIB3UNu1PBz9eykQqlW2kLji0ZjXJPyebln nKFYaKujatrp7v
Axfk/S3Xy+sFGnR81d1ygb8SI6t5fJdrnjrhIRUfMO4mFAmKMYgpSsi vP0igd+sN
vcBR3ksfKMx9VpXrMOhNLMGXht8ql5O0baAbxtHS7k9TcP8gxP KxeQ==
=Bh1L
-----END PGP SIGNATURE-----

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 06-10-2010, 05:40 PM
David Cantrell
 
Default Make minimum shrink size 1 not 0 (#602442)

On Wed, 9 Jun 2010, Brian C. Lane wrote:


On 06/09/2010 03:17 PM, David Lehman wrote:

On Wed, 2010-06-09 at 14:22 -0700, Brian C. Lane wrote:

Shrink dialog in autopart lets 0 get through. Lower level code
doesn't like a length of 0 and throws and exception that isn't
caught.


Ack, although I'm not sure a size of 1 is much more useful than 0.



True, but it keeps it from raising an exception


The lower bound should be the min() of the device minimum size and the format
minimum size.

--
David Cantrell <dcantrell@redhat.com>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 05:28 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org