I don't have a 2.6.31 kernel in Debian Lenny, can't this patch applied to the Debian Lenny Kernel as it fixes a stability bug?

Greets,
Brian



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20100602115220.GA23564@omicron.homeip.net">http://lists.debian.org/20100602115220.GA23564@omicron.homeip.net

On Wed, 2010-06-02 at 13:52 +0200, Brian 'morlenxus' Miculcy wrote:
> I don't have a 2.6.31 kernel in Debian Lenny, can't this patch applied
> to the Debian Lenny Kernel as it fixes a stability bug?

It looks like we can make a similar change. Bastian, does it look like
this will work?

Ben.

From 81f4306654d459f730dfbe5fac983e1cba8fcf7c Mon Sep 17 00:00:00 2001
From: Christoph Hellwig <hch@lst.de>
Date: Fri, 17 Jul 2009 21:47:45 -0600
Subject: [PATCH] virtio_blk: don't bounce highmem requests

By default a block driver bounces highmem requests, but virtio-blk is
perfectly fine with any request that fit into it's 64 bit addressing scheme,
mapped in the kernel virtual space or not.

Besides improving performance on highmem systems this also makes the
reproducible oops in __bounce_end_io go away (but hiding the real cause).

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
[bwh: Adjust context for 2.6.26]
---
drivers/block/virtio_blk.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index dd7ea20..141c0e7 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -276,6 +276,9 @@ static int virtblk_probe(struct virtio_device *vdev)
}
set_capacity(vblk->disk, cap);

+ /* No need to bounce any requests */
+ blk_queue_bounce_limit(vblk->disk->queue, BLK_BOUNCE_ANY);
+
/* Host can optionally specify maximum segment size and number of
* segments. */
err = virtio_config_val(vdev, VIRTIO_BLK_F_SIZE_MAX,
--
1.7.1

--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

On Wed, Jun 02, 2010 at 03:16:23PM +0100, Ben Hutchings wrote:
> It looks like we can make a similar change. Bastian, does it look like
> this will work?

Looks fine, except that it does not apply directly.

Bastian

--
Humans do claim a great deal for that particular emotion (love).
-- Spock, "The Lights of Zetar", stardate 5725.6



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20100602152311.GA1313@wavehammer.waldi.eu.org">htt p://lists.debian.org/20100602152311.GA1313@wavehammer.waldi.eu.org

Yeah, probably the line numbers aren't correct, so it can't find the right position.
Can you find the right position in the code or should i do that and submit a working patch?

On Wed, Jun 02, 2010 at 05:23:11PM +0200, Bastian Blank wrote:
> On Wed, Jun 02, 2010 at 03:16:23PM +0100, Ben Hutchings wrote:
> > It looks like we can make a similar change. Bastian, does it look like
> > this will work?
>
> Looks fine, except that it does not apply directly.
>
> Bastian
>
> --
> Humans do claim a great deal for that particular emotion (love).
> -- Spock, "The Lights of Zetar", stardate 5725.6



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20100602153511.GA26932@omicron.homeip.net">http://lists.debian.org/20100602153511.GA26932@omicron.homeip.net

On Wed, Jun 02, 2010 at 05:35:11PM +0200, Brian 'morlenxus' Miculcy wrote:
> Yeah, probably the line numbers aren't correct, so it can't find the right position.
> Can you find the right position in the code or should i do that and submit a working patch?
>
> On Wed, Jun 02, 2010 at 05:23:11PM +0200, Bastian Blank wrote:
> > On Wed, Jun 02, 2010 at 03:16:23PM +0100, Ben Hutchings wrote:
> > > It looks like we can make a similar change. Bastian, does it look like
> > > this will work?
> >
> > Looks fine, except that it does not apply directly.

I sent what I thought was a working patch for lenny.

Ben.

--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20100602185650.GK5306@decadent.org.uk">http://lists.debian.org/20100602185650.GK5306@decadent.org.uk

Installed linux-source-2.6.26, unpacked, applied the patch - no errors.
Don't see why it don't apply for you, i used the debian kernel source package and applied above patch. Can you check that again?

On Wed, Jun 02, 2010 at 07:56:50PM +0100, Ben Hutchings wrote:
> On Wed, Jun 02, 2010 at 05:35:11PM +0200, Brian 'morlenxus' Miculcy wrote:
> > Yeah, probably the line numbers aren't correct, so it can't find the right position.
> > Can you find the right position in the code or should i do that and submit a working patch?
> >
> > On Wed, Jun 02, 2010 at 05:23:11PM +0200, Bastian Blank wrote:
> > > On Wed, Jun 02, 2010 at 03:16:23PM +0100, Ben Hutchings wrote:
> > > > It looks like we can make a similar change. Bastian, does it look like
> > > > this will work?
> > >
> > > Looks fine, except that it does not apply directly.
>
> I sent what I thought was a working patch for lenny.
>
> Ben.
>
> --
> Ben Hutchings
> We get into the habit of living before acquiring the habit of thinking.
> - Albert Camus



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20100603131027.GA14877@omicron.homeip.net">http://lists.debian.org/20100603131027.GA14877@omicron.homeip.net

On Wed, Jun 02, 2010 at 07:56:50PM +0100, Ben Hutchings wrote:
> I sent what I thought was a working patch for lenny.

I mixed it up somehow.

Bastian

--
One does not thank logic.
-- Sarek, "Journey to Babel", stardate 3842.4



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20100603211355.GA13328@wavehammer.waldi.eu.org">ht tp://lists.debian.org/20100603211355.GA13328@wavehammer.waldi.eu.org

So will this patch go in?

On Thu, Jun 03, 2010 at 11:13:55PM +0200, Bastian Blank wrote:
> On Wed, Jun 02, 2010 at 07:56:50PM +0100, Ben Hutchings wrote:
> > I sent what I thought was a working patch for lenny.
>
> I mixed it up somehow.
>
> Bastian
>
> --
> One does not thank logic.
> -- Sarek, "Journey to Babel", stardate 3842.4



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20100604140238.GA2274@omicron.homeip.net">http://lists.debian.org/20100604140238.GA2274@omicron.homeip.net

On Thu, 2010-06-03 at 15:10 +0200, Brian 'morlenxus' Miculcy wrote:
> Installed linux-source-2.6.26, unpacked, applied the patch - no errors.
> Don't see why it don't apply for you, i used the debian kernel source
> package and applied above patch. Can you check that again?

Did you also build and test that it fixed the bug?

Ben.

--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Yes, no more oops.

On Sat, Jun 05, 2010 at 09:17:17PM +0100, Ben Hutchings wrote:
> On Thu, 2010-06-03 at 15:10 +0200, Brian 'morlenxus' Miculcy wrote:
> > Installed linux-source-2.6.26, unpacked, applied the patch - no errors.
> > Don't see why it don't apply for you, i used the debian kernel source
> > package and applied above patch. Can you check that again?
>
> Did you also build and test that it fixed the bug?
>
> Ben.
>
> --
> Ben Hutchings
> Once a job is fouled up, anything done to improve it makes it worse.





--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20100607131645.GB24236@omicron.homeip.net">http://lists.debian.org/20100607131645.GB24236@omicron.homeip.net