Ack.
The case of logging messages for early networking is getting better and
better.

On 03/31/2010 08:14 PM, Peter Jones wrote:
> Ajax was wondering why xdriver=vesa was requiring early networking. It
> isn't, but the log claims it is. The log shouldn't claim that.
> ---
> loader/loader.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/loader/loader.c b/loader/loader.c
> index d731f96..996e9e9 100644
> --- a/loader/loader.c
> +++ b/loader/loader.c
> @@ -1127,12 +1127,15 @@ static void parseCmdLineFlags(struct loaderData_s * loaderData,
> * to anaconda
> */
> if (!strncasecmp(argv[i], "syslog", 6) ||
> - !strncasecmp(argv[i], "vnc", 3) ||
> - isKickstartFileRemote(loaderData->ksFile)) {
> + !strncasecmp(argv[i], "vnc", 3)) {
> logMessage(INFO, "early networking required for %s",
> argv[i]);
> flags |= LOADER_FLAGS_EARLY_NETWORKING;
> }
> + if (isKickstartFileRemote(loaderData->ksFile)) {
> + logMessage(INFO, "early networking required for remote kickstart configuration");
> + flags |= LOADER_FLAGS_EARLY_NETWORKING;
> + }
>
> if (!strncasecmp(argv[i], "vesa", 4)) {
> checked_asprintf(&extraArgs[numExtraArgs],

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

> Ajax was wondering why xdriver=vesa was requiring early networking. It
> isn't, but the log claims it is. The log shouldn't claim that.

Ack as well.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list