Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Debian Kernel (http://www.linux-archive.org/debian-kernel/)
-   -   Ignore probably-spurious disklabels on unpartitionable devices. (#567832) (http://www.linux-archive.org/debian-kernel/332492-ignore-probably-spurious-disklabels-unpartitionable-devices-567832-a.html)

David Lehman 02-26-2010 03:26 PM

Ignore probably-spurious disklabels on unpartitionable devices. (#567832)
 
---
storage/devicetree.py | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/storage/devicetree.py b/storage/devicetree.py
index 386d23f..e0892d9 100644
--- a/storage/devicetree.py
+++ b/storage/devicetree.py
@@ -1303,7 +1303,11 @@ class DeviceTree(object):
except InvalidDiskLabelError:
pass
else:
- device.format = format
+ if format.partitions:
+ # parted's checks for disklabel presence are less than
+ # rigorous, so we will assume that detected disklabels
+ # with no partitions are spurious
+ device.format = format
return

# if the disk contains protected partitions we will not wipe the
--
1.6.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Hans de Goede 02-26-2010 05:56 PM

Ignore probably-spurious disklabels on unpartitionable devices. (#567832)
 
Hi,

On 02/26/2010 05:26 PM, David Lehman wrote:

---
storage/devicetree.py | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/storage/devicetree.py b/storage/devicetree.py
index 386d23f..e0892d9 100644
--- a/storage/devicetree.py
+++ b/storage/devicetree.py
@@ -1303,7 +1303,11 @@ class DeviceTree(object):
except InvalidDiskLabelError:
pass
else:
- device.format = format
+ if format.partitions:
+ # parted's checks for disklabel presence are less than
+ # rigorous, so we will assume that detected disklabels
+ # with no partitions are spurious
+ device.format = format
return

# if the disk contains protected partitions we will not wipe the


Erm won't this mean that we will pop up a "Drive foo needs to be initialized warning"
when there is a valid but empty disklabel ?

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


All times are GMT. The time now is 02:25 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.