FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Kernel

 
 
LinkBack Thread Tools
 
Old 11-08-2009, 09:20 PM
Jesse Keating
 
Default Use proper logic when checking repo id

Using string.find is a bit deprecated, as you have to do a
"string.find("foo") != -1" instead of just "foo" in string

In this case, it means we throw every single repo out when BETANAG is
turned off, not what we want to happen here. Just fixing the one failing
if statement for F-12, converting all these string.finds to the newer
construct on devel branch.
---
yuminstall.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/yuminstall.py b/yuminstall.py
index df34153..25a445d 100644
--- a/yuminstall.py
+++ b/yuminstall.py
@@ -557,7 +557,7 @@ class AnacondaYum(YumSorter):
raise RepoError, "Repo %s contains -source or -debuginfo, excluding" % name

# this is a little hard-coded, but it's effective
- if not BETANAG and (repo.id.find("rawhide") or repo.id.find("development")):
+ if not BETANAG and ("rawhide" in repo.id or "development" in repo.id):
name = repo.name
del(repo)
raise RepoError, "Excluding devel repo %s for non-devel anaconda" % name
--
1.6.5.2

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 11-08-2009, 09:22 PM
Jesse Keating
 
Default Use proper logic when checking repo id

On Sun, 2009-11-08 at 14:20 -0800, Jesse Keating wrote:
> Using string.find is a bit deprecated, as you have to do a
> "string.find("foo") != -1" instead of just "foo" in string
>
> In this case, it means we throw every single repo out when BETANAG is
> turned off, not what we want to happen here. Just fixing the one failing
> if statement for F-12, converting all these string.finds to the newer
> construct on devel branch.

This is for https://bugzilla.redhat.com/show_bug.cgi?id=533658 which I
have made a blocker issue. I'm going to do a build in F-12 with this
patch for the release, another patch is coming for master.

--
Jesse Keating
Fedora -- Freedom˛ is a feature!
identi.ca: http://identi.ca/jkeating
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 02:55 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org