This is a bit of a big hammer, but disable devkit-disks from touching things
during a live install until we can do something a little bit more fine-grained
---
liveinst/liveinst.sh | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/liveinst/liveinst.sh b/liveinst/liveinst.sh
index 744a2b9..cdba58f 100644
--- a/liveinst/liveinst.sh
+++ b/liveinst/liveinst.sh
@@ -61,7 +61,9 @@ umount /media/*
/sbin/swapoff -a
/sbin/lvm vgchange -an --ignorelockingfailure

-if [ -x /usr/bin/hal-lock -a -e /var/lock/subsys/haldaemon ]; then
+if [ -x /usr/bin/devkit-disks ]; then
+ /usr/bin/devkit-disks --inhibit -- /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
+elif [ -x /usr/bin/hal-lock -a -e /var/lock/subsys/haldaemon ]; then
/usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
else
$ANACONDA $*
--
1.6.1

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

On Thu, 2009-03-19 at 13:15 -0400, Jeremy Katz wrote:
> This is a bit of a big hammer, but disable devkit-disks from touching things
> during a live install until we can do something a little bit more fine-grained

Looks good to me. I didn't expect DK to provide such a nice way to do
this.

> ---
> liveinst/liveinst.sh | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/liveinst/liveinst.sh b/liveinst/liveinst.sh
> index 744a2b9..cdba58f 100644
> --- a/liveinst/liveinst.sh
> +++ b/liveinst/liveinst.sh
> @@ -61,7 +61,9 @@ umount /media/*
> /sbin/swapoff -a
> /sbin/lvm vgchange -an --ignorelockingfailure
>
> -if [ -x /usr/bin/hal-lock -a -e /var/lock/subsys/haldaemon ]; then
> +if [ -x /usr/bin/devkit-disks ]; then
> + /usr/bin/devkit-disks --inhibit -- /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> +elif [ -x /usr/bin/hal-lock -a -e /var/lock/subsys/haldaemon ]; then
> /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> else
> $ANACONDA $*

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Looks good,

Regards,

Hans


Jeremy Katz wrote:

This is a bit of a big hammer, but disable devkit-disks from touching things
during a live install until we can do something a little bit more fine-grained
---
liveinst/liveinst.sh | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/liveinst/liveinst.sh b/liveinst/liveinst.sh
index 744a2b9..cdba58f 100644
--- a/liveinst/liveinst.sh
+++ b/liveinst/liveinst.sh
@@ -61,7 +61,9 @@ umount /media/*
/sbin/swapoff -a
/sbin/lvm vgchange -an --ignorelockingfailure

-if [ -x /usr/bin/hal-lock -a -e /var/lock/subsys/haldaemon ]; then

+if [ -x /usr/bin/devkit-disks ]; then
+ /usr/bin/devkit-disks --inhibit -- /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
+elif [ -x /usr/bin/hal-lock -a -e /var/lock/subsys/haldaemon ]; then
/usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
else
$ANACONDA $*


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

On Thursday, March 19 2009, David Lehman said:

> On Thu, 2009-03-19 at 13:15 -0400, Jeremy Katz wrote:
> > This is a bit of a big hammer, but disable devkit-disks from touching things
> > during a live install until we can do something a little bit more fine-grained
>
> Looks good to me. I didn't expect DK to provide such a nice way to do
> this.

It's a big hammer and it has other downsides (inserted media won't
automount while the user is installing), but the plus is that the
install doesn't break. Seems like the right tradeoff for now at least.

Jeremy

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list