Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Debian Kernel (http://www.linux-archive.org/debian-kernel/)
-   -   pvremove *really* means pvremove! (http://www.linux-archive.org/debian-kernel/259766-pvremove-really-means-pvremove.html)

Joel Granados Moreno 03-09-2009 02:15 PM

pvremove *really* means pvremove!
 
* storage/devicelibs/lvm.py (pvremove): Make sure to erase the PVs with
arguments "-ff"" and "-y". The first one is to force the action, the
other is to make sure lmv does ask for user interaction.
---
storage/devicelibs/lvm.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/storage/devicelibs/lvm.py b/storage/devicelibs/lvm.py
index 0faee10..bdb732a 100644
--- a/storage/devicelibs/lvm.py
+++ b/storage/devicelibs/lvm.py
@@ -130,7 +130,7 @@ def pvresize(device, size):

def pvremove(device):
rc = iutil.execWithRedirect("lvm",
- ["pvremove", device],
+ ["pvremove","-ff", "-y", device],
stdout = "/dev/tty5",
stderr = "/dev/tty5",
searchPath=1)
--
1.6.0.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Joel Granados Moreno 03-09-2009 03:36 PM

pvremove *really* means pvremove!
 
* storage/devicelibs/lvm.py (pvremove): Make sure to erase the PVs with
arguments "-ff"" and "-y". The first one is to force the action, the
other is to make sure lmv does ask for user interaction.
---
storage/devicelibs/lvm.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/storage/devicelibs/lvm.py b/storage/devicelibs/lvm.py
index 0faee10..bdb732a 100644
--- a/storage/devicelibs/lvm.py
+++ b/storage/devicelibs/lvm.py
@@ -130,7 +130,7 @@ def pvresize(device, size):

def pvremove(device):
rc = iutil.execWithRedirect("lvm",
- ["pvremove", device],
+ ["pvremove","-ff", "-y", device],
stdout = "/dev/tty5",
stderr = "/dev/tty5",
searchPath=1)
--
1.6.0.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

David Cantrell 03-09-2009 07:55 PM

pvremove *really* means pvremove!
 
Looks good (ignoring your other patch).

On 03/09/2009 05:15 AM, Joel Granados Moreno wrote:

* storage/devicelibs/lvm.py (pvremove): Make sure to erase the PVs with
arguments "-ff"" and "-y". The first one is to force the action, the
other is to make sure lmv does ask for user interaction.
---
storage/devicelibs/lvm.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/storage/devicelibs/lvm.py b/storage/devicelibs/lvm.py
index 0faee10..bdb732a 100644
--- a/storage/devicelibs/lvm.py
+++ b/storage/devicelibs/lvm.py
@@ -130,7 +130,7 @@ def pvresize(device, size):

def pvremove(device):
rc = iutil.execWithRedirect("lvm",
- ["pvremove", device],
+ ["pvremove","-ff", "-y", device],
stdout = "/dev/tty5",
stderr = "/dev/tty5",
searchPath=1)



--
David Cantrell <dcantrell@redhat.com>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Mon Mar 9 23:30:01 2009
Return-path: <bounce-debian-devel=tom=linux-archive.org@lists.debian.org>
Envelope-to: tom@linux-archive.org
Delivery-date: Mon, 09 Mar 2009 22:50:15 +0200
Received: from liszt.debian.org ([82.195.75.100]:60552)
by s2.java-tips.org with esmtps (TLSv1:AES256-SHA:256)
(Exim 4.69)
(envelope-from <bounce-debian-devel=tom=linux-archive.org@lists.debian.org>)
id 1LgmQQ-0000S4-Uc
for tom@linux-archive.org; Mon, 09 Mar 2009 22:50:15 +0200
Received: from localhost (localhost [127.0.0.1])
by liszt.debian.org (Postfix) with QMQP
id 1B1772D0C43; Mon, 9 Mar 2009 20:55:44 +0000 (UTC)
Old-Return-Path: <gandalf@le-vert.net>
X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on liszt.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-4.9 required=4.0 tests=FOURLA,LDO_WHITELIST

autolearn=failed version=3.2.3
X-Original-To: lists-debian-devel@liszt.debian.org
Delivered-To: lists-debian-devel@liszt.debian.org
Received: from localhost (localhost [127.0.0.1])
by liszt.debian.org (Postfix) with ESMTP id C718A2D0CC4
for <lists-debian-devel@liszt.debian.org>; Mon, 9 Mar 2009 20:55:37 +0000 (UTC)
Received: from liszt.debian.org ([127.0.0.1])
by localhost (lists.debian.org [127.0.0.1]) (amavisd-new, port 2525)
with ESMTP id 05943-52 for <lists-debian-devel@liszt.debian.org>;
Mon, 9 Mar 2009 20:55:34 +0000 (UTC)
X-policyd-weight: using cached result; rate: -6.1
X-Greylist: delayed 456 seconds by postgrey-1.27 at liszt; Mon, 09 Mar 2009 20:55:34 UTC
Received: from dedibox.le-vert.net (dedibox.le-vert.net [88.191.97.204])
by liszt.debian.org (Postfix) with ESMTP id BD31E13A5530
for <debian-devel@lists.debian.org>; Mon, 9 Mar 2009 20:55:28 +0000 (UTC)
Received: from [10.1.0.1] (ip-108.net-81-220-203.roubaix.rev.numericable.fr [81.220.203.108])
by dedibox.le-vert.net (Postfix) with ESMTPSA id 51C4917D39
for <debian-devel@lists.debian.org>; Mon, 9 Mar 2009 21:47:45 +0100 (CET)
Message-ID: <49B57FFE.2070806@le-vert.net>
Date: Mon, 09 Mar 2009 21:45:50 +0100
From: =?ISO-8859-1?Q?=22Adam_C=E9cile_=28Le=5FVert=29=22?=
<gandalf@le-vert.net>
User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103)
MIME-Version: 1.0
To: debian-devel@lists.debian.org
Subject: To the aqualung NMUer....
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: at lists.debian.org with policy bank en-ht
X-Amavis-Spam-Status: No, score=-6.9 tagged_above=3.6 required=5.3
tests=[BAYES_00=-2, FOURLA=0.1, LDO_WHITELIST=-5]
X-Rc-Virus: 2007-09-13_01
X-Rc-Spam: 2008-11-04_01
Resent-Message-ID: <FsT06GyDDHP.A.khH.QJYtJB@liszt>
Resent-From: debian-devel@lists.debian.org
X-Mailing-List: <debian-devel@lists.debian.org> archive/latest/247908
X-Loop: debian-devel@lists.debian.org
List-Id: <debian-devel.lists.debian.org>
List-Post: <mailto:debian-devel@lists.debian.org>
List-Help: <mailto:debian-devel-request@lists.debian.org?subject=help>
List-Subscribe: <mailto:debian-devel-request@lists.debian.org?subject=subscribe>
List-Unsubscribe: <mailto:debian-devel-request@lists.debian.org?subject=unsubscribe>
Precedence: list
Resent-Sender: debian-devel-request@lists.debian.org
Resent-Date: Mon, 9 Mar 2009 20:55:44 +0000 (UTC)

Hello,

I just received a DAK acknowledgement for aqualung 0.9~beta9.1-1.1 but
it's not me who prepared this package.
I guess it's a NMU fixing the ffmpeg/libavcodec issue but I can't found
any related message neither on the BTS nor on debian mailing lists
(-devel and -release).


I would have been great if this people told me he were preparing a NMU
because I was working on new upstream release package that ALSO fix the
ffmpeg issue.


Anyway... If someone is responsible of this upload, please overwrite it
by the new packages I just uploaded to debian-mentors:

http://mentors.debian.net/debian/pool/main/a/aqualung/aqualung_0.9~beta10-1.dsc

Thanks in advance,

Adam.


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

David Lehman 03-10-2009 02:50 PM

pvremove *really* means pvremove!
 
I don't like that we must do this, but we apparently do so... Ack.

On Mon, 2009-03-09 at 17:36 +0100, Joel Granados Moreno wrote:
> * storage/devicelibs/lvm.py (pvremove): Make sure to erase the PVs with
> arguments "-ff"" and "-y". The first one is to force the action, the
> other is to make sure lmv does ask for user interaction.
> ---
> storage/devicelibs/lvm.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/storage/devicelibs/lvm.py b/storage/devicelibs/lvm.py
> index 0faee10..bdb732a 100644
> --- a/storage/devicelibs/lvm.py
> +++ b/storage/devicelibs/lvm.py
> @@ -130,7 +130,7 @@ def pvresize(device, size):
>
> def pvremove(device):
> rc = iutil.execWithRedirect("lvm",
> - ["pvremove", device],
> + ["pvremove","-ff", "-y", device],
> stdout = "/dev/tty5",
> stderr = "/dev/tty5",
> searchPath=1)

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Joel Granados 03-10-2009 04:42 PM

pvremove *really* means pvremove!
 
On Tue, Mar 10, 2009 at 10:50:03AM -0500, David Lehman wrote:
I'm going to got through some lvm testing to see if I can avoid having
to do this. Wont commit untill I am satisfied that I is most likely the
only or the easiest answer to the issue.
> I don't like that we must do this, but we apparently do so... Ack.
>
> On Mon, 2009-03-09 at 17:36 +0100, Joel Granados Moreno wrote:
> > * storage/devicelibs/lvm.py (pvremove): Make sure to erase the PVs with
> > arguments "-ff"" and "-y". The first one is to force the action, the
> > other is to make sure lmv does ask for user interaction.
> > ---
> > storage/devicelibs/lvm.py | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/storage/devicelibs/lvm.py b/storage/devicelibs/lvm.py
> > index 0faee10..bdb732a 100644
> > --- a/storage/devicelibs/lvm.py
> > +++ b/storage/devicelibs/lvm.py
> > @@ -130,7 +130,7 @@ def pvresize(device, size):
> >
> > def pvremove(device):
> > rc = iutil.execWithRedirect("lvm",
> > - ["pvremove", device],
> > + ["pvremove","-ff", "-y", device],
> > stdout = "/dev/tty5",
> > stderr = "/dev/tty5",
> > searchPath=1)
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

--
Joel Andres Granados
Brno, Czech Republic, Red Hat.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


All times are GMT. The time now is 05:39 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.