Package: linux-2.6
Version: 2.6.25-5
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Since I upgraded from Linux 2.6.24, NetworkManager cannot associate my
Intel wireless card, handled by the ipw2200 driver, with my AP, which
has a hidden SSID.

NetworkManager thinks that wpa_supplicant should be able to scan for
specific hidden SSIDs if the underlying driver advertises
IW_SCAN_CAPA_ESSID, which ipw2200 does since 2.6.25. However, this
doesn't work.

I have confirmed that NetworkManager is interpreting this capability
flag correctly and checked that wpa_supplicant has the patch that I
was referred to - see the thread on linux-wireless
<http://thread.gmane.org/gmane.linux.kernel.wireless.general/15560>.
Therefore I believe the driver is at fault.

This should be fixable by removing the capability flag:

diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
index 6e70460..457c078 100644
- --- a/drivers/net/wireless/ipw2200.c
+++ b/drivers/net/wireless/ipw2200.c
@@ -8973,7 +8973,7 @@ static int ipw_wx_get_range(struct net_device *dev,
range->enc_capa = IW_ENC_CAPA_WPA | IW_ENC_CAPA_WPA2 |
IW_ENC_CAPA_CIPHER_TKIP | IW_ENC_CAPA_CIPHER_CCMP;

- - range->scan_capa = IW_SCAN_CAPA_ESSID | IW_SCAN_CAPA_TYPE;
+ range->scan_capa = IW_SCAN_CAPA_TYPE;

IPW_DEBUG_WX("GET Range
");
return 0;
- --- END ---

Ben.

- -- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (100, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.25-2-686 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFIX/n079ZNCRIGYgcRAtTDAJ0QJkA9bMRF6l9AEr5X6TukLEyq9ACf W+YL
rCQutbYqXk8u8vZP8Zawka0=
=pip+
-----END PGP SIGNATURE-----



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

hello ben!

On Mon, 23 Jun 2008, Ben Hutchings wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Since I upgraded from Linux 2.6.24, NetworkManager cannot associate my
> Intel wireless card, handled by the ipw2200 driver, with my AP, which
> has a hidden SSID.
>
> NetworkManager thinks that wpa_supplicant should be able to scan for
> specific hidden SSIDs if the underlying driver advertises
> IW_SCAN_CAPA_ESSID, which ipw2200 does since 2.6.25. However, this
> doesn't work.
>
> I have confirmed that NetworkManager is interpreting this capability
> flag correctly and checked that wpa_supplicant has the patch that I
> was referred to - see the thread on linux-wireless
> <http://thread.gmane.org/gmane.linux.kernel.wireless.general/15560>.
> Therefore I believe the driver is at fault.
>
> This should be fixable by removing the capability flag:
>
> diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
> index 6e70460..457c078 100644
> - --- a/drivers/net/wireless/ipw2200.c
> +++ b/drivers/net/wireless/ipw2200.c
> @@ -8973,7 +8973,7 @@ static int ipw_wx_get_range(struct net_device *dev,
> range->enc_capa = IW_ENC_CAPA_WPA | IW_ENC_CAPA_WPA2 |
> IW_ENC_CAPA_CIPHER_TKIP | IW_ENC_CAPA_CIPHER_CCMP;
>
> - - range->scan_capa = IW_SCAN_CAPA_ESSID | IW_SCAN_CAPA_TYPE;
> + range->scan_capa = IW_SCAN_CAPA_TYPE;
>
> IPW_DEBUG_WX("GET Range
");
> return 0;
> - --- END ---
>
> Ben.

thanks for the patch, could we get it upstream so that we can backport it.
don't want to start wireless divergence.

kind regards

--
maks



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

On Wed, 2008-06-25 at 03:37 +0200, maximilian attems wrote:
<snip>
> > diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
> > index 6e70460..457c078 100644
> > - --- a/drivers/net/wireless/ipw2200.c
> > +++ b/drivers/net/wireless/ipw2200.c
> > @@ -8973,7 +8973,7 @@ static int ipw_wx_get_range(struct net_device *dev,
> > range->enc_capa = IW_ENC_CAPA_WPA | IW_ENC_CAPA_WPA2 |
> > IW_ENC_CAPA_CIPHER_TKIP | IW_ENC_CAPA_CIPHER_CCMP;
> >
> > - - range->scan_capa = IW_SCAN_CAPA_ESSID | IW_SCAN_CAPA_TYPE;
> > + range->scan_capa = IW_SCAN_CAPA_TYPE;
> >
> > IPW_DEBUG_WX("GET Range
");
> > return 0;
> > - --- END ---
> >
> > Ben.
>
> thanks for the patch, could we get it upstream so that we can backport it.
> don't want to start wireless divergence.

I rather suspect that that would not be acceptable upstream!

However, when I reviewed the thread referred to above I realised I had
not tried the patch that Dan Williams suggested. Something similar was
committed as ea177305b321a4127e448b88de20d5792682ace1, between
2.6.26-rc4 and -rc5. I applied this to the kernel source package in
unstable, rebuilt and reloaded ipw2200 and it fixed the bug for me. So
I think you can close this in 2.6.26-1.

Ben.

--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

On Mon, 21 Jul 2008, Ben Hutchings wrote:

> I rather suspect that that would not be acceptable upstream!
>
> However, when I reviewed the thread referred to above I realised I had
> not tried the patch that Dan Williams suggested. Something similar was
> committed as ea177305b321a4127e448b88de20d5792682ace1, between
> 2.6.26-rc4 and -rc5. I applied this to the kernel source package in
> unstable, rebuilt and reloaded ipw2200 and it fixed the bug for me. So
> I think you can close this in 2.6.26-1.
>
> Ben.

ok cool, added to changelog.
thanks for the info.

--
maks



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org