FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian KDE

 
 
LinkBack Thread Tools
 
Old 05-07-2010, 11:49 PM
David Cantrell
 
Default Offer to ignore unformatted DASDs rather than forcing exit (#580456)

Similar to the fix for finding unformatted DASDs in rescue mode, rename
the 'Exit Installer' button to 'Ignore'. Installation continues fine
when you ignore unformatted DASDs. A little backstory, at the point in
time when I was working on this patch, I chose to force exit because
continuing with some unformatted DASDs did not work well with the
storage code at the time. Seems to work now, so the choices users get
are Format and Ignore.

Since this is similar to what the rescue mode change does, I removed the
special "rescue" return value and just have it return 1.

Related: rhbz#582638
---
installinterfacebase.py | 2 +-
rescue.py | 2 +-
storage/dasd.py | 6 +-----
3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/installinterfacebase.py b/installinterfacebase.py
index 59099b6..024a28d 100644
--- a/installinterfacebase.py
+++ b/installinterfacebase.py
@@ -71,7 +71,7 @@ class InstallInterfaceBase(object):
"these devices." % c,
c)
icon = "/usr/share/icons/gnome/32x32/status/dialog-error.png"
- buttons = [_("_Format"), _("_Exit installer")]
+ buttons = [_("_Format"), _("_Ignore")]
return self.detailedMessageWindow(title, msg, devs.strip(),
type="custom",
custom_icon=icon,
diff --git a/rescue.py b/rescue.py
index 2076951..b613bbd 100644
--- a/rescue.py
+++ b/rescue.py
@@ -120,7 +120,7 @@ class RescueInterface(InstallInterfaceBase):

def questionInitializeDASD(self, c, devs):
# Special return value to let dasd.py know we're rescue mode
- return "rescue"
+ return 1

def shutdown (self):
pass
diff --git a/storage/dasd.py b/storage/dasd.py
index 83c3cde..2b95b19 100644
--- a/storage/dasd.py
+++ b/storage/dasd.py
@@ -115,11 +115,7 @@ class DASD:

rc = intf.questionInitializeDASD(c, devs)
if rc == 1:
- log.info(" not running dasdfmt, exiting installer")
- sys.exit(0)
- # Check for special rescue mode return
- elif rc == "rescue":
- log.info(" rescue mode: not running dasdfmt")
+ log.info(" not running dasdfmt, continuing installation")
return

# gather total cylinder count
--
1.6.6.1

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-08-2010, 12:25 AM
"Brian C. Lane"
 
Default Offer to ignore unformatted DASDs rather than forcing exit (#580456)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/07/2010 04:49 PM, David Cantrell wrote:
> Similar to the fix for finding unformatted DASDs in rescue mode, rename
> the 'Exit Installer' button to 'Ignore'. Installation continues fine
> when you ignore unformatted DASDs. A little backstory, at the point in
> time when I was working on this patch, I chose to force exit because
> continuing with some unformatted DASDs did not work well with the
> storage code at the time. Seems to work now, so the choices users get
> are Format and Ignore.
>
> Since this is similar to what the rescue mode change does, I removed the
> special "rescue" return value and just have it return 1.
>
> Related: rhbz#582638

AckAck

- --
Brian C. Lane <bcl@redhat.com>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBS+SvXxF+jBaO/jp/AQJ1cgf+Ke9gYsDssa1AcELr3VvyHuBkplKETYLy
XN4IXldcAkZ7i2LIy+d/4/m3wwgGsVO4+XrmmKFO9+6oC2ijribz/g1p5G5IrW+r
DOXvU5VKHyBRauEKp+MzajohrQNHzFRFwyJgIOMEHdLOfgqU4J N+fBGVNb9yra+/
3nY4Q/1nkeJiGOYo8AhsMCB2FcgOHOmOTIpzYp7IwHrOpY57S5464N4o 6jgUPgjC
GUOKHmCKQi/X7yjLYXourKmC6P7Mb6pd5jdBGDDCcy/5JbRK/l6wslYHTiqL8GJQ
+QRcrX8jV2dikMNaOl+VWEyZTa0ponAf5n5KX0Svn2LmhxtEY6 LtJA==
=r/oj
-----END PGP SIGNATURE-----

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 05:21 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org