FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Java

 
 
LinkBack Thread Tools
 
Old 07-10-2012, 06:41 PM
Jakub Adam
 
Default RFS: tomcat7 7.0.28-2 (fixes RC bug)

Dear java packagers,

I am looking for a sponsor for package "tomcat7".

* Package name : tomcat7
Version : 7.0.28-2
Upstream Author : Apache Software Foundation
* URL : http://tomcat.apache.org
* License : Apache-2.0
Section : java

It builds those binary packages:

tomcat7-common - Servlet and JSP engine -- common files
tomcat7 - Servlet and JSP engine
tomcat7-user - Servlet and JSP engine -- tools to create user instances
libtomcat7-java - Servlet and JSP engine -- core libraries
libservlet3.0-java - Servlet 3.0 and JSP 2.2 Java API classes
libservlet3.0-java-doc - Servlet 3.0 and JSP 2.2 Java API documentation
tomcat7-admin - Servlet and JSP engine -- admin web applications
tomcat7-examples - Servlet and JSP engine -- example web applications
tomcat7-docs - Servlet and JSP engine -- documentation

Package files can be accessed at pkg-java repository:

http://anonscm.debian.org/gitweb/?p=pkg-java/tomcat7.git

This version fixes RC bug #680844 and is thus meant to be included in Wheezy
release.

I would be glad if someone uploaded this package for me.

Kind regards,

Jakub Adam


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4FFC7754.9050705@ktknet.cz">http://lists.debian.org/4FFC7754.9050705@ktknet.cz
 
Old 07-10-2012, 06:46 PM
Niels Thykier
 
Default RFS: tomcat7 7.0.28-2 (fixes RC bug)

On 2012-07-10 20:41, Jakub Adam wrote:
> Dear java packagers,
>
> I am looking for a sponsor for package "tomcat7".
>
> * Package name : tomcat7
> Version : 7.0.28-2
> Upstream Author : Apache Software Foundation
> * URL : http://tomcat.apache.org
> * License : Apache-2.0
> Section : java
>
> It builds those binary packages:
>
> [...]
>
> Package files can be accessed at pkg-java repository:
>
> http://anonscm.debian.org/gitweb/?p=pkg-java/tomcat7.git
>
> This version fixes RC bug #680844 and is thus meant to be included in
> Wheezy
> release.
>
> I would be glad if someone uploaded this package for me.
>
> Kind regards,
>
> Jakub Adam
>
>

Hey,

Looks okay, but can you remove the
<srcfiles file="${user.home}/build.properties" />
line rather adding "failonerror=false"? I do not like the idea of the
build being sensitive to stuff in $HOME.

~Niels


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4FFC788B.50702@thykier.net">http://lists.debian.org/4FFC788B.50702@thykier.net
 
Old 07-10-2012, 07:02 PM
Jakub Adam
 
Default RFS: tomcat7 7.0.28-2 (fixes RC bug)

Hi Niels,

On 10.7.2012 20:46, Niels Thykier wrote:

Looks okay, but can you remove the
<srcfiles file="${user.home}/build.properties" />
line rather adding "failonerror=false"? I do not like the idea of the
build being sensitive to stuff in $HOME.


Changed in git.

Regards,

Jakub


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4FFC7C2B.7020303@ktknet.cz">http://lists.debian.org/4FFC7C2B.7020303@ktknet.cz
 
Old 07-10-2012, 07:33 PM
Niels Thykier
 
Default RFS: tomcat7 7.0.28-2 (fixes RC bug)

On 2012-07-10 21:02, Jakub Adam wrote:
> Hi Niels,
>
> On 10.7.2012 20:46, Niels Thykier wrote:
>> Looks okay, but can you remove the
>> <srcfiles file="${user.home}/build.properties" />
>> line rather adding "failonerror=false"? I do not like the idea of the
>> build being sensitive to stuff in $HOME.
>
> Changed in git.
>
> Regards,
>
> Jakub
>
>

It seems the build changes d/tomcat7.postrm, but the clean rule does not
"undo it". So this would produce the wrong result if rebuilt. It seems
unrelated to your change, which effectively makes it an unreported RC bug.

diff --git a/debian/tomcat7.postrm b/debian/tomcat7.postrm
index 1d451c3..99236af 100644
--- a/debian/tomcat7.postrm
+++ b/debian/tomcat7.postrm
@@ -14,7 +14,7 @@ case "$1" in
RWLOC="/var/lib/tomcat7/webapps/ROOT"
RWFILES="$RWLOC/index.html $RWLOC/META-INF/context.xml"
if [ "`(cat $RWFILES | md5sum -) 2>/dev/null | cut -d ' ' -f 1`"
- = "@ROOT_WEBAPP_MD5SUM@" ] ; then
+ = "0688719927c9ff0b364d2b5bc1eea542" ] ; then
rm $RWFILES
rmdir --ignore-fail-on-non-empty
/var/lib/tomcat7/webapps/ROOT/META-INF

~Niels


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4FFC8398.3070801@thykier.net">http://lists.debian.org/4FFC8398.3070801@thykier.net
 
Old 07-10-2012, 08:02 PM
tony mancill
 
Default RFS: tomcat7 7.0.28-2 (fixes RC bug)

On 07/10/2012 12:33 PM, Niels Thykier wrote:
> On 2012-07-10 21:02, Jakub Adam wrote:
>> Hi Niels,
>>
>> On 10.7.2012 20:46, Niels Thykier wrote:
>>> Looks okay, but can you remove the
>>> <srcfiles file="${user.home}/build.properties" />
>>> line rather adding "failonerror=false"? I do not like the idea of the
>>> build being sensitive to stuff in $HOME.
>>
>> Changed in git.
>>
>> Regards,
>>
>> Jakub
>>
>>
>
> It seems the build changes d/tomcat7.postrm, but the clean rule does not
> "undo it". So this would produce the wrong result if rebuilt. It seems
> unrelated to your change, which effectively makes it an unreported RC bug.
>
> diff --git a/debian/tomcat7.postrm b/debian/tomcat7.postrm
> index 1d451c3..99236af 100644
> --- a/debian/tomcat7.postrm
> +++ b/debian/tomcat7.postrm
> @@ -14,7 +14,7 @@ case "$1" in
> RWLOC="/var/lib/tomcat7/webapps/ROOT"
> RWFILES="$RWLOC/index.html $RWLOC/META-INF/context.xml"
> if [ "`(cat $RWFILES | md5sum -) 2>/dev/null | cut -d ' ' -f 1`"
> - = "@ROOT_WEBAPP_MD5SUM@" ] ; then
> + = "0688719927c9ff0b364d2b5bc1eea542" ] ; then
> rm $RWFILES
> rmdir --ignore-fail-on-non-empty
> /var/lib/tomcat7/webapps/ROOT/META-INF
>
> ~Niels

Hi Niels,

I changed the build to calculate the MD5SUM needed in the postrm because
packages would forget to modify the sum after modifying the app and
reintroduce a piuparts error (see #670440). I see now how this creates
a problem when building twice in a row, but only in the case that the
contents of the root webapp were modified. (Otherwise the MD5SUm is
correct and @ROOT_WEBAPP_MD5SUM@ isn't matched or replaced.) Is that an
RC bug?

I can update the build to use a postrm.in file if this is RC.

Thanks,
tony



--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4FFC8A49.3050003@debian.org">http://lists.debian.org/4FFC8A49.3050003@debian.org
 
Old 07-10-2012, 08:08 PM
Niels Thykier
 
Default RFS: tomcat7 7.0.28-2 (fixes RC bug)

On 2012-07-10 22:02, tony mancill wrote:
> On 07/10/2012 12:33 PM, Niels Thykier wrote:
>> [...]
>>
>> ~Niels
>
> Hi Niels,
>
> I changed the build to calculate the MD5SUM needed in the postrm because
> packages would forget to modify the sum after modifying the app and
> reintroduce a piuparts error (see #670440). I see now how this creates
> a problem when building twice in a row, but only in the case that the
> contents of the root webapp were modified. (Otherwise the MD5SUm is
> correct and @ROOT_WEBAPP_MD5SUM@ isn't matched or replaced.) Is that an
> RC bug?
>
> I can update the build to use a postrm.in file if this is RC.
>
> Thanks,
> tony
>
>
>

I would say it is a bug; imagine that the files contain a bug and they
are fixed in a NMU. If the NMU'er uses the dsc from the archive[1], the
NMU'ed package will use the old md5sum. Then the NMU'ed postrm will not
properly purge.

Beyond that, Policy says the following about "clean":

"""
This must undo any effects that the build and binary targets may have
had, except that it should leave alone any output files created in the
parent directory by a run of a binary target.
"""

Personally I think the postrm change fails that definition of the clean
target.

~Niels

[1] Which is more likely than the NMU'er actually building from git.


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4FFC8BD5.10903@thykier.net">http://lists.debian.org/4FFC8BD5.10903@thykier.net
 
Old 07-10-2012, 08:38 PM
tony mancill
 
Default RFS: tomcat7 7.0.28-2 (fixes RC bug)

On 07/10/2012 01:08 PM, Niels Thykier wrote:
> On 2012-07-10 22:02, tony mancill wrote:
>> On 07/10/2012 12:33 PM, Niels Thykier wrote:
>>> [...]
>>>
>>> ~Niels
>>
>> Hi Niels,
>>
>> I changed the build to calculate the MD5SUM needed in the postrm because
>> packages would forget to modify the sum after modifying the app and
>> reintroduce a piuparts error (see #670440). I see now how this creates
>> a problem when building twice in a row, but only in the case that the
>> contents of the root webapp were modified. (Otherwise the MD5SUm is
>> correct and @ROOT_WEBAPP_MD5SUM@ isn't matched or replaced.) Is that an
>> RC bug?
>>
>> I can update the build to use a postrm.in file if this is RC.
>>
>> Thanks,
>> tony
>>
>>
>>
>
> I would say it is a bug; imagine that the files contain a bug and they
> are fixed in a NMU. If the NMU'er uses the dsc from the archive[1], the
> NMU'ed package will use the old md5sum. Then the NMU'ed postrm will not
> properly purge.
>
> Beyond that, Policy says the following about "clean":
>
> """
> This must undo any effects that the build and binary targets may have
> had, except that it should leave alone any output files created in the
> parent directory by a run of a binary target.
> """
>
> Personally I think the postrm change fails that definition of the clean
> target.
>
> ~Niels
>
> [1] Which is more likely than the NMU'er actually building from git.

Okay. I'll file a separate RC bug and prepare a fix that includes
Jakub's fix.

Thank you,
tony
 

Thread Tools




All times are GMT. The time now is 07:37 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org