Change in default behaviour in maven-debian-helper

02-21-2012, 08:38 AM

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Team

I've noticed a change in behaviour in the latest version of
maven-debian-helper in Debian unstable and I wanted to validate that
this was intentional.

Prior to 1.5 of mdh, jars where by default installed into
/usr/share/maven-repo and symbolic links created in /usr/share/java -
this was not strictly compliant with the Debian Java Policy.

This was fixed under http://bugs.debian.org/636660; however unless the
- --java-lib option is specified in the libXXX-java.poms file then the
jar file ONLY gets installed into /usr/share/maven-repo.

I don't think that earlier versions of mh_make automatically added
this option to the generated libXXX-java.poms file so I suspect that
this may change/break quite a few packages. I have seen a couple already:

http://pad.lv/935254
http://bugs.debian.org/660653

I wanted to validate that this was the desired/required behaviour and
not a bug before I start fixing things up by adding --java-lib flags.

Cheers

James
- --
James Page
Ubuntu Core Developer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJPQ2YxAAoJEL/srsug59jDUekQAKdiJGK6jrtePzt/XAifDbQZ
lfchuQY07X38MUX/CbEPhpK49fhN2oG6PgeqefFDdLJrNx3+y+FiB3mfkXxotGrD
u/pUxVrSDr/vvtpJyyvuqVd8GFLUNDGDpHSKzk0Lru/R1HZPc6uXHaUXrm4MljXh
J3+rebI/jx5rnMZ1pG/u0OivPNq0kw7ofh9tI9EHzf8U96Md+RCnyEv+y19PxF5m
05PW2xxw8rNk0ir6TGXSRS9KodCYHJ0GDjfNRuv0kxZzJ2eiih Vn1lJVhP/R4cHv
OOTksJTtmIRxkvryiwK0LUCnjbO8YRJiw5+Wiu/WS+E9j4tJRFAM/G9mVsT+8Gnr
CO3VIIW6pnuK8ZRuAYvv167f9vfvnbb1ZX9u0yYqKiF2ALy0RH 0HARqOQ+3wgxzO
O5o3QVDJ987+dLo80W9+UZrGdLdtKGhtxnH106vyIXegkas2ur gO/mfpOx9W9MwA
FDAuRj/dUHejz/HYZQJ90DMmdTiV02qM5SDa73BOBdGsgSL9KP5NbwieBlmGtTtr
gzGE9vfKKiMEKKD1kqQ/5/LImawEakk1F0bA2tNBlM/d1Hp09OacvEKKCPmD+zRu
HoZtEjyqTvnyq7girFrYDPkV7xIL6r0muvewyG9ATAjrWLVCYC rZISP6cD4JGZMv
F1lIHh4WW6E1uNwO9c+5
=IFjM
-----END PGP SIGNATURE-----

--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4F436632.1080103@ubuntu.com">http://lists.debian.org/4F436632.1080103@ubuntu.com

02-21-2012, 09:08 PM

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello James,

The new behaviour of maven-debian-helper seems more correct. I think
that for most cases, you explicitely add --java-lib option to publish
your jar in /usr/share/java, but there are cases where a jar is
private, for example Ant or Eclipse plugins. In such cases, you can
create a link to a custom location (with the third argument to
mh_installjar) or install the jar in that custom location (using
- --dest-jar=<path>) and let mh_installjar create a link for the jar in
the Maven repository.

Please file bug reports for those packages which are broken by this
change, I tried to fix such packages some time ago but there are still
some problems in packages I don't know.

Ludovic

On 21/02/2012 10:38, James Page wrote:
> Hi Team
>
> I've noticed a change in behaviour in the latest version of
> maven-debian-helper in Debian unstable and I wanted to validate
> that this was intentional.
>
> Prior to 1.5 of mdh, jars where by default installed into
> /usr/share/maven-repo and symbolic links created in /usr/share/java
> - this was not strictly compliant with the Debian Java Policy.
>
> This was fixed under http://bugs.debian.org/636660; however unless
> the --java-lib option is specified in the libXXX-java.poms file
> then the jar file ONLY gets installed into /usr/share/maven-repo.
>
> I don't think that earlier versions of mh_make automatically added
> this option to the generated libXXX-java.poms file so I suspect
> that this may change/break quite a few packages. I have seen a
> couple already:
>
> http://pad.lv/935254 http://bugs.debian.org/660653
>
> I wanted to validate that this was the desired/required behaviour
> and not a bug before I start fixing things up by adding --java-lib
> flags.
>
> Cheers
>
> James
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJPRBXYAAoJEImmFv6yGz69uPcP/3OomYJ4wsEtaN97JgfYl2Q3
34sL88MirlFT7yZmPQlvVjBAZ3InU+EkhaIb287YTVp9bIVEwJ p6oH59fuomT+Ui
n2ggUjgoJzKsDQQeK8q77KuMkB3X7IB5tnBAsG1qv5k36irUoR R6YxJgkaqNR0/f
0kS/pwCkuGq6APIoUoXCyr2czqHpQX+DwVoGT6eeSVTveBusOnQVlS Ue1VvFnAEk
EXxo3y71zM8BWr4tjjoyyhuFiTDYuCF6r4c4sE1ZVUlrI7fBzy +rvXJEEUsms4OA
n7v7zsiLt7seuu7P52z4bESQmcM3zSlq2HpdEDL2P+p+UciFXO DaeGv/Dp5X3kUq
kYEmlBlxfUyM3sr8OIugkm5bxhnqI5sApcTW79VT2BLHRbK/vAK7EhBSiUgIp/1m
9HzQC7x5zQKP4QObNGvYMwkv6B6fVS7bk9C5zgsguzuh+vrpcK +uSErc3f+VYQiS
4h0yJlZJURz44xfmavZtniw1JbkDTFHmRwcqKzOsh2P2dpiQ/s7UxyxQieoelZxg
zUrxV7zyywbwjXRcOBiF9jMBhex8NiADoXVW+HNJemnOCcyzZK 2FA8A8Nd2UKaYs
G1LHp5oeaBwgLyCFGmuIaV6WpFXww4lDSuBMy/HOLaXO89JNcud+EXrXuroWVoxT
Arxso25UyuMtC3e+/Cq7
=r7s8
-----END PGP SIGNATURE-----

--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4F4415D8.5000909@laposte.net">http://lists.debian.org/4F4415D8.5000909@laposte.net

04-24-2012, 12:32 PM

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Ludovic

On 21/02/12 22:08, Ludovic Claude wrote:
> The new behaviour of maven-debian-helper seems more correct. I
> think that for most cases, you explicitely add --java-lib option to
> publish your jar in /usr/share/java, but there are cases where a
> jar is private, for example Ant or Eclipse plugins. In such cases,
> you can create a link to a custom location (with the third argument
> to mh_installjar) or install the jar in that custom location
> (using - --dest-jar=<path>) and let mh_installjar create a link for
> the jar in the Maven repository.
>
> Please file bug reports for those packages which are broken by
> this change, I tried to fix such packages some time ago but there
> are still some problems in packages I don't know.

It would be nice the m-d-h made more intelligent decisioning on
whether to install to /usr/share/java or not.

For example, if the binary package name that m-d-h is targetting is
named libXXX-java, it would make sense to automatically install to
/usr/share/java. If the package is not a libXXX-java package then it
a) does not want to install to usj or b) has to do it explicitly with
- --java-lib.

Lintian checks that libXXX-java packages install jar files to
/usr/share/java - I don't think mdh should be breaking that rule!

I'd be happy to work up a patch to implement this functionality (feel
it might be a better spend of time rather than continually finding
packages which don't use --java-lib).

Thoughts?

Cheers

James

- --
James Page
Ubuntu Core Developer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJPlp1MAAoJEL/srsug59jDaxwQALZveOsiwd+gD/wWCxGnG/Af
u+ia4YeTHzTRY1WUCif6+LYLpzsthJiTkEt+IbXmurGs9YXL7a ILl5EyGcf+WiIB
aHtVyRreyQtgBzI9MZDjAqiEZM3Lxru1ZLyJQQjIx1txxdaaMJ mY+5xECi6+IBeZ
9uDc1DkEbRCTJ3yYwLy2x187Fv2ff69nmFqZf5NfkNFW++J8+i +mAz/ZdlBRacmz
k9E+e/a2LiIeMV+3yHhrpVWf5b6MhWtFsZiRa5iD5ulDvdtdDVu7R7Dn MEpKy96z
v4oA+V9IAu0Twm5IDmnpEiASMlBL0GldyjY8PHeErc3skkHWzO kJL/Vkt76smvNw
jWL0EHYQbYgEUWNrb/8V6Qc8G6kp61li/PXgXnNSYHOHVrLP4VpxkUspiIpBcu6z
n8VhkZAOqy7mHtRCe9GQZXMza784rbBKhOgcaGS47+7PTUciyn Q9gsfItKaszaIE
5EyTuRAgzMLspNrLaVmuZ2bHCMaRIZwwC1626yek1qqVWIcF4z 8fbQOVU/viRScU
zaD6LFXv3LIIHZcMvgsrHD+eWRsAVeOH4y2nrh+jYEJARxAgMt 57FF+1EP+AxClj
0JmW40MNVm2thTAvtHhNmNywL0ZQjwm8tEijxPJJ2urbOOpaWl iz1+3Ewtc7CM6Z
xRVr+DifDxOqKKfPJETS
=QrY8
-----END PGP SIGNATURE-----

--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4F969D4C.7020204@ubuntu.com">http://lists.debian.org/4F969D4C.7020204@ubuntu.com

08-29-2012, 04:55 PM

On Tue, 2012-04-24 at 13:32 +0100, James Page wrote:
> Hi Ludovic
>
> On 21/02/12 22:08, Ludovic Claude wrote:
> > The new behaviour of maven-debian-helper seems more correct. I
> > think that for most cases, you explicitely add --java-lib option to
> > publish your jar in /usr/share/java, but there are cases where a
> > jar is private, for example Ant or Eclipse plugins. In such cases,
> > you can create a link to a custom location (with the third argument
> > to mh_installjar) or install the jar in that custom location
> > (using - --dest-jar=<path>) and let mh_installjar create a link for
> > the jar in the Maven repository.
> >
> > Please file bug reports for those packages which are broken by
> > this change, I tried to fix such packages some time ago but there
> > are still some problems in packages I don't know.
>
> It would be nice the m-d-h made more intelligent decisioning on
> whether to install to /usr/share/java or not.
>
> For example, if the binary package name that m-d-h is targetting is
> named libXXX-java, it would make sense to automatically install to
> /usr/share/java. If the package is not a libXXX-java package then it
> a) does not want to install to usj or b) has to do it explicitly with
> --java-lib.
>
> Lintian checks that libXXX-java packages install jar files to
> /usr/share/java - I don't think mdh should be breaking that rule!
>
> I'd be happy to work up a patch to implement this functionality (feel
> it might be a better spend of time rather than continually finding
> packages which don't use --java-lib).
>
> Thoughts?

That would be great. I just got bitten by forgetting --java-lib on a
libXXX-java package because mdh was being so wonderfully helpful I
thought it would have done this for me.

Daniel

08-30-2012, 11:19 PM

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello Daniel,

If you use a recent version of maven-debian-helper and the mh_make
tool to package your project, then --java-lib option should have been
included in the generated .poms file.

Ludovic

On 08/29/2012 06:55 PM, Daniel Thomas wrote:
> On Tue, 2012-04-24 at 13:32 +0100, James Page wrote:
>> Hi Ludovic
>>
>> On 21/02/12 22:08, Ludovic Claude wrote:
>>> The new behaviour of maven-debian-helper seems more correct. I
>>> think that for most cases, you explicitely add --java-lib
>>> option to publish your jar in /usr/share/java, but there are
>>> cases where a jar is private, for example Ant or Eclipse
>>> plugins. In such cases, you can create a link to a custom
>>> location (with the third argument to mh_installjar) or install
>>> the jar in that custom location (using - --dest-jar=<path>) and
>>> let mh_installjar create a link for the jar in the Maven
>>> repository.
>>>
>>> Please file bug reports for those packages which are broken by
>>> this change, I tried to fix such packages some time ago but
>>> there are still some problems in packages I don't know.
>>
>> It would be nice the m-d-h made more intelligent decisioning on
>> whether to install to /usr/share/java or not.
>>
>> For example, if the binary package name that m-d-h is targetting
>> is named libXXX-java, it would make sense to automatically
>> install to /usr/share/java. If the package is not a libXXX-java
>> package then it a) does not want to install to usj or b) has to
>> do it explicitly with --java-lib.
>>
>> Lintian checks that libXXX-java packages install jar files to
>> /usr/share/java - I don't think mdh should be breaking that
>> rule!
>>
>> I'd be happy to work up a patch to implement this functionality
>> (feel it might be a better spend of time rather than continually
>> finding packages which don't use --java-lib).
>>
>> Thoughts?
>
> That would be great. I just got bitten by forgetting --java-lib on
> a libXXX-java package because mdh was being so wonderfully helpful
> I thought it would have done this for me.
>
> Daniel
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJQP/TxAAoJEImmFv6yGz69aWwP/jANDQqBZJWmkyoj2uZVH3fp
O9s/wRlYw/3nuJ7QtqPa+pqgF5zCzDeN5sFiPLM/BTIlyoYdR1+RbaYjPXshW4WK
rVA+UGJXE/LmEQ/4gvqAyTRVKc8lWZfksTqXwCIUU1HOCjUehuDjE/mL8v8BUeOO
4u4Ikc4XKm+labOAvUcwnd5f0AhM/RQ4MdOeF8a0Itfyn2UbyCvfrFsagrBuKveS
u2dVMZ50K38BXtFv9vy20xidB9EqhRP6Qx0lWZesIoiHde/H7sZcnyFalf9r42HH
akOLWEOXa6ksRHXDGQqEc1rLJKXb0SlmP3mshHi/+Hs+eBb9F/bORcPGoUL9f3Uq
GKhz9OQe8JVhJw/RemQ671ApkGQTSVwa/kdyB0SI6tVFffijUHYjqN2zVLA+hEwd
W+osM80KzycEfKbZD2oXCW4mmP10aicCuJz0n+u/QIXy7XDGGYmU7XB5cnaK+18L
55i+aWbcibtTD30pPxxXZJ/dAYHGfHSGnNVqSayjQISMgb09oG+OpDpFNLXMuZNL
ed20/unrczz0j+TWX6BiKT+JZV6tSmIKYO0dYHAIgtAHIROI38zJE1C q3aSh2x72
EWU5yWlxAcki630BDgD0U7w5gf85zvFKOLAU9fvxTA0oopw+NO ftTJB2/d1L++5A
ftj/44u4fWJr5kSTLbsV
=U+cs
-----END PGP SIGNATURE-----

--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 503FF4F6.8010104@laposte.net">http://lists.debian.org/503FF4F6.8010104@laposte.net