FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Java

 
 
LinkBack Thread Tools
 
Old 06-05-2011, 10:35 PM
"Damien Raude-Morvan"
 
Default ITS: txw2

Le dimanche 05 juin 2011 19:24:44, Damien Raude-Morvan a écrit :
> Le mercredi 01 juin 2011 15:46:31, James Page a écrit :
> > Hi All
> >
> > I am looking for a sponsor for my package "txw2".
> >
> > * Package name : txw2
> >
> > Version : 0.1+20070624-1
> > Upstream Author : Kohsuke Kawaguchi
> >
> > * URL : https://txw.dev.java.net/
> > * License : CDDL
[...]

Two comments here :
- There is no need to Build-Depends on quilt with 3.0 (quilt) source format
- You have some duplication in your make targets : install/lib$(PACKAGE)-
java:: (install + dh_link) and a binary-post-install/lib$(PACKAGE)-java::
(mh_installpom + mh_installjar). You should just keep mh_installpom +
mh_installjar.

Cheers,
--
Damien - Debian Developper
http://wiki.debian.org/DamienRaudeMorvan
 
Old 06-06-2011, 07:19 AM
James Page
 
Default ITS: txw2

Hi Damien

On Mon, 2011-06-06 at 00:35 +0200, Damien Raude-Morvan wrote:
>
> Two comments here :
> - There is no need to Build-Depends on quilt with 3.0 (quilt) source
> format
> - You have some duplication in your make targets : install/lib
> $(PACKAGE)-
> java:: (install + dh_link) and a binary-post-install/lib
> $(PACKAGE)-java::
> (mh_installpom + mh_installjar). You should just keep mh_installpom +
> mh_installjar.

Both issues resolved and build-tested; I've pushed the changes back to
the git repository (let me know if you would like them on mentors as
well).

Cheers

James

--
James Page
Software Engineer, Ubuntu Server Team
 
Old 06-06-2011, 08:16 PM
"Damien Raude-Morvan"
 
Default ITS: txw2

Le lundi 06 juin 2011 09:19:21, James Page a écrit :
> Both issues resolved and build-tested; I've pushed the changes back to
> the git repository (let me know if you would like them on mentors as
> well).

Uploaded.

Cheers,
--
Damien - Debian Developper
http://wiki.debian.org/DamienRaudeMorvan
 
Old 06-07-2011, 09:43 AM
James Page
 
Default ITS: txw2

On Mon, 2011-06-06 at 22:16 +0200, Damien Raude-Morvan wrote:
> Le lundi 06 juin 2011 09:19:21, James Page a écrit :
> > Both issues resolved and build-tested; I've pushed the changes back to
> > the git repository (let me know if you would like them on mentors as
> > well).
>
> Uploaded.

Thankyou!

--
James Page
Software Engineer, Ubuntu Server Team
 

Thread Tools




All times are GMT. The time now is 02:07 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org