FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Java

 
 
LinkBack Thread Tools
 
Old 04-16-2011, 08:28 AM
Nicolas Dandrimont
 
Default Bug#613293: RFS: svgsalamander (updated, take 4)

Le 30/03/2011 à 22:21, Niels Thykier <niels@thykier.net> écrivit*:
>
> I am thinking that 0~svn95 might still be a better version; you never
> know what the future brings. Maybe upstream start making formal
> releases if/as more people get involved in it.
> Obviously we could still handle that with an epoch, so using 95 (or
> 0095) as a version would not be the end of the world for us.
>
> [...]
>
> If you are "repacking" the source package anyway (which you did for the
> PDF), please remove this copy as well. Since we have lost the "pristine
> tar" (or rather, there never was a tarball to begin with?) we might as
> well reduce the risks of compiling/using the embedded code copy (not to
> mention reduce the size of the tarball).
>
> [...]
>
> I also noted a minor thing like "cd $dir && dostuff && cd $(CURDIR)".
> The last cd $(CURDIR) is not necessary (every line is executed in a
> separate shell). This is a feature of "make".
> The dh --with maven_repo_helper can be written as "maven-repo-helper".
> Personally I find the dashed version nicer to read (but this is a
> "pedantic" personal preference).

Hi,

I addressed your comments and uploaded the new version to mentors.d.n
and to git.

- URL: http://mentors.debian.net/debian/pool/main/s/svgsalamander
- Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/s/svgsalamander/svgsalamander_0~svn95-1.dsc

I guess we're closing in

Cheers,
--
Nicolas Dandrimont
 
Old 05-09-2011, 08:29 PM
Niels Thykier
 
Default Bug#613293: RFS: svgsalamander (updated, take 4)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2011-04-16 10:28, Nicolas Dandrimont wrote:
> Le 30/03/2011 à 22:21, Niels Thykier <niels@thykier.net> écrivit :
>>
>> I am thinking that 0~svn95 might still be a better version; you never
>> know what the future brings. Maybe upstream start making formal
>> releases if/as more people get involved in it.
>> Obviously we could still handle that with an epoch, so using 95 (or
>> 0095) as a version would not be the end of the world for us.
>>
>> [...]
>>
>> If you are "repacking" the source package anyway (which you did for the
>> PDF), please remove this copy as well. Since we have lost the "pristine
>> tar" (or rather, there never was a tarball to begin with?) we might as
>> well reduce the risks of compiling/using the embedded code copy (not to
>> mention reduce the size of the tarball).
>>
>> [...]
>>
>> I also noted a minor thing like "cd $dir && dostuff && cd $(CURDIR)".
>> The last cd $(CURDIR) is not necessary (every line is executed in a
>> separate shell). This is a feature of "make".
>> The dh --with maven_repo_helper can be written as "maven-repo-helper".
>> Personally I find the dashed version nicer to read (but this is a
>> "pedantic" personal preference).
>
> Hi,
>
> I addressed your comments and uploaded the new version to mentors.d.n
> and to git.
>
> - URL: http://mentors.debian.net/debian/pool/main/s/svgsalamander
> - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/s/svgsalamander/svgsalamander_0~svn95-1.dsc
>
> I guess we're closing in
>
> Cheers,

Hi,

This reply is long overdue and I am sorry for that.

Here are my comments; the package FTBFS at least if it is checked out
from git. I strongly suspect that this is caused by git not tracking
empty directories. After creating svg-core/src/gen/{java,res} it seems
to work just fine.

The debian/copyright: you list the
svg-core/src/main/java/com/kitfox/svg/batik/*, but it is (no longer)
present in the tarball. Hench you should not list it[1].

By now Standards-Version is 3.9.2 (as I recall it is a "non-change", so
it should not be a lot of trouble).

... and a couple of hints:

Strictly speaking you need a version build depends of >= 0.32~ to use
${java:Recommends}. This is guaranteed in Wheezy, so this is just a
heads up if you ever need to backport the package to an older version of
Debian or Ubuntu.

As far as I can tell, you probably want to put "unapply-patches" into
debian/source/local-options so dpkg-source unapplies the patches after a
successful build. But this is only a suggestion and not related to the
package itself (the file will not end up in the resulting package).

I think that should about cover it...

Thanks for your patience with me on this,
~Niels

[1] I suspect I worded myself poorly or you misunderstood me, when I
wrote about this part originally. Or maybe you just forgot to update
the copyright file.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNyE6/AAoJEAVLu599gGRC1WwP/25VRYcaCqoUWXiiJEovuTiQ
AZcsXNzzR+dSoTbVjTf8G2UKPDTxsk1s6VyrOGdjssVSDjrbMT 4kd9Vwq/s2qSxK
RUjaqbCT+HwLWrsNtSwGyLJix+3YFmWcHpYIsGPJ7AKKa5CNgI JED6WuKTvxHX28
CpGKbeUaYvz6N1tMMLXfCCaK++sqkFfI/vWpaBqGiFMf7MdqEkiZCC7nSrL4UBQi
YOd3EYB1obWxphS/2mpFJZw7eoXkQYVXleRA6Iswd+uYkTn1uxSpMrcb9YvuGbl3
y7GQaT5ahG9ljDBLpQ3EWueKOdUhAWK0Cqw1Y+mNIzMAnve1gA wspSOhhhm4m4df
3RwU41m2E8Qas1HdEia5Q1+wqx5OLwhUn8ERmX4dtq9SL3biZA InUViisEpuIUgF
1+T38zCGCx+IQtsUQhPtkevU4Wl7JBwrrMgQUggAM+2sIGUSGe 4PIm2h0kDAkqOE
rvXmpSQdRdW3nqFj3g8kR+HWzjuhmFdj2RC0T9RX7R7fR5/tpp7Dov8K8GJyTMHA
8n5Cu79MBwOtTmlM8st1r7ScxR2OQt28IhJ2TtxlVdnv2/YalaqyvF/HewE3TfKa
wrvgY0AhWIQs1phLZ1XTVxI7WMiOAkt5o8ohFkKWCpp6JVvKYZ PXxg2VwPD0c5lG
+OJzT6ubu9q/Ep8lVr5A
=BU5f
-----END PGP SIGNATURE-----


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4DC84EC0.40207@thykier.net">http://lists.debian.org/4DC84EC0.40207@thykier.net
 
Old 05-10-2011, 05:05 PM
Nicolas Dandrimont
 
Default Bug#613293: RFS: svgsalamander (updated, take 4)

Hi Niels,

Le 09/05/2011 à 22:29, Niels Thykier <niels@thykier.net> écrivit*:

> This reply is long overdue and I am sorry for that.
>
> Here are my comments; the package FTBFS at least if it is checked out
> from git. I strongly suspect that this is caused by git not tracking
> empty directories. After creating svg-core/src/gen/{java,res} it seems
> to work just fine.

Yep, I thought I fixed that. Added a mkdir in d/rules and checked the
package to build in a checkout.

> The debian/copyright: you list the
> svg-core/src/main/java/com/kitfox/svg/batik/*, but it is (no longer)
> present in the tarball. Hench you should not list it[1].

Well, I thought about it but I guess it slipped out of my mind, fixed.

>
> By now Standards-Version is 3.9.2 (as I recall it is a "non-change", so
> it should not be a lot of trouble).

Bumped.

> ... and a couple of hints:
>
> Strictly speaking you need a version build depends of >= 0.32~ to use
> ${java:Recommends}. This is guaranteed in Wheezy, so this is just a
> heads up if you ever need to backport the package to an older version of
> Debian or Ubuntu.

I put the dependency in as I guess it won't do any harm anyway.

> As far as I can tell, you probably want to put "unapply-patches" into
> debian/source/local-options so dpkg-source unapplies the patches after a
> successful build. But this is only a suggestion and not related to the
> package itself (the file will not end up in the resulting package).

That is a great tip, as I'm using git-buildpackage it's very helpful,
thanks.

> I think that should about cover it...
>
> Thanks for your patience with me on this,

Well I was also quite busy, but I would have pinged you about this
sooner or later

I pushed the changes to git and to mentors.d.n:
- URL: http://mentors.debian.net/debian/pool/main/s/svgsalamander
- Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/s/svgsalamander/svgsalamander_0~svn95-1.dsc

Thanks,
--
Nicolas Dandrimont


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 87r586trk2.fsf@poincare.crans.org">http://lists.debian.org/87r586trk2.fsf@poincare.crans.org
 
Old 05-10-2011, 05:46 PM
Niels Thykier
 
Default Bug#613293: RFS: svgsalamander (updated, take 4)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2011-05-10 19:05, Nicolas Dandrimont wrote:
>
> Hi Niels,
>
> [...]
>
> Well I was also quite busy, but I would have pinged you about this
> sooner or later
>
> I pushed the changes to git and to mentors.d.n:
> - URL: http://mentors.debian.net/debian/pool/main/s/svgsalamander
> - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/s/svgsalamander/svgsalamander_0~svn95-1.dsc
>
> Thanks,

Hi,

Did you perhaps forget to push the changes to the pkg-java repository,
because git pull says there are no changes?

~Niels

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNyXnrAAoJEAVLu599gGRC2yoP/jht3tQT8LLNWUB2F/93Fn3v
YcCo8WeHBwvtG+ho5svgqa5WMAY1L7Erqb0gA2XtOImp+P6MYZ TxO4/aRKHYpMGm
hAiLgnnQ58SshCI0ZUUvaEGfW4zd5symO+8lnhRsvGjv4HGUyt UAn/mbnKHBPY8v
LZTkPkW9UA6mBoWg6Mf1e7e+CT2eBXPQ3pN37mH0aapl7jsnIg repxfAT3IDIehf
6pjiiuX9o0d4MBIXBE9PPFsTvZrPz3ChqlNxQOu/FSwf1cZ9rlA9PNMy4iDELxlF
8z0Av4A2eCyLJrqHIVivH/vqs6I2lv2J8RKqCLCI7xpcQ6k/5nK8Vcu6MHARjUlZ
yJPxQQz7q/LHFc88VQoDfebvbhTDY5cA63NPQ6T6XiXpCaNBsjqNTxFYGs0t YUTk
vcy4q4hmC4SLQSFXZ8xGqV+xtUdvp19Eo555mqKsIHfhmhSZj9 Z4jiFUYIpOQ+hV
qFlg+tBWOiwOtFlB+P7Xb6rMBdhxehSphUmmINFZp93npEPn+S oeM1vtgEGq1Utg
FcHuc4Az22X/aQqudvwnRtKj4Rj0M21a2wkaFpDQOGtiYBZ7YDJ3m3xVnwSCat X5
Nn+61JDQllmeqw6mHrfU6AUycae72ouiJ3+XeENUZ/ygMZOtO4ZZo4WZ/cLyReS2
q05R/yhq+tCMGglPIjGy
=TCjt
-----END PGP SIGNATURE-----


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4DC979EC.1000103@thykier.net">http://lists.debian.org/4DC979EC.1000103@thykier.net
 
Old 05-10-2011, 06:29 PM
Nicolas Dandrimont
 
Default Bug#613293: RFS: svgsalamander (updated, take 4)

Le 10/05/2011 à 19:46, Niels Thykier <niels@thykier.net> écrivit*:
> On 2011-05-10 19:05, Nicolas Dandrimont wrote:
> >
> > Hi Niels,
> >
> > [...]
> >
> > Well I was also quite busy, but I would have pinged you about this
> > sooner or later
> >
> > I pushed the changes to git and to mentors.d.n:
> > - URL: http://mentors.debian.net/debian/pool/main/s/svgsalamander
> > - Source repository: deb-src http://mentors.debian.net/debian unstable main
> > contrib non-free
> > - dget http://mentors.debian.net/debian/pool/main/s/svgsalamander/svgsalamander_0~svn95-1.dsc
> >
> > Thanks,
>
> Hi,
>
> Did you perhaps forget to push the changes to the pkg-java repository,
> because git pull says there are no changes?

D'oh... Now I did.

Thanks,
--
Nicolas Dandrimont


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 87liyetnni.fsf@poincare.crans.org">http://lists.debian.org/87liyetnni.fsf@poincare.crans.org
 
Old 05-10-2011, 08:37 PM
Niels Thykier
 
Default Bug#613293: RFS: svgsalamander (updated, take 4)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2011-05-10 20:29, Nicolas Dandrimont wrote:
> Le 10/05/2011 à 19:46, Niels Thykier <niels@thykier.net> écrivit :
>> On 2011-05-10 19:05, Nicolas Dandrimont wrote:
>>>
>>> Hi Niels,
>>>
>>> [...]
>>>
>>> Well I was also quite busy, but I would have pinged you about this
>>> sooner or later
>>>
>>> I pushed the changes to git and to mentors.d.n:
>>> - URL: http://mentors.debian.net/debian/pool/main/s/svgsalamander
>>> - Source repository: deb-src http://mentors.debian.net/debian unstable main
>>> contrib non-free
>>> - dget http://mentors.debian.net/debian/pool/main/s/svgsalamander/svgsalamander_0~svn95-1.dsc
>>>
>>> Thanks,
>>
>> Hi,
>>
>> Did you perhaps forget to push the changes to the pkg-java repository,
>> because git pull says there are no changes?
>
> D'oh... Now I did.
>
> Thanks,

Uploaded. I modified the release date in the changelog (mostly because
it was triggering a lintian warning). I have *not* tagged it in git - I
was not sure how you prefer handling the ~ in the tag; as I recall
git-buildpackage uses "-" instead, but I will lead you have the honour
of deciding this.

~Niels

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNyaH0AAoJEAVLu599gGRCtfQP/0BkhmXqSIYNkzxtdi9Aa/Mk
8Y22UyU4OG8/0XOmqfoh3xL97z1F3HjL87zc3p1B3oY8yy9g1LWY/p1Bd24uqDfx
qoUV3xJbNm7fHT/DpgiP5vdv/pRnaRclCfsEXoenlSD/OXTYV7rAbr+sumW715up
5A4TLMe0jIuD+yfztIt6bnRjgLvUNSnDWxU7E0k2hqjPImQpDF xLEpemRTsiyond
/hVEAAacdUZgo14CxwJeGxtyhk/xzNI8IEYTLFovhN+F/OFvyQ79B9Zotiqrpt37
0EdDqcwTJRrxwCD/639YeIeK3szI5Odeoq29jQC6XQahRikA9cUq+fLz0owY2uSA
KcxsifhXKAp1ICJdGTNCAtIaxSNgng+79PQvGev8CAOxr7z7dE vuE+bDFjdFpUkC
Z9nTodfFXdEOG91tficsO7vwdp4DX87hMM3Ag8KszAR4Q3xmfQ jksS1uJ0vXov4B
dIp4xCKfuScPioQiaPOHBAUiocrFHN2RME1gavFYfN6FXl/FfSq09Ex2YF+x9aMf
coZSZjwi3jNP4AXU0WvcNlVuvwNyN70ekUAuLY12OcNsB0VTLn uftfOt89UoztNj
+bZX+9Fe/ocnQx58NSMSCqUivmQKahvg5fwDcwpZ9NV95qS7N+nqs0PN+ty Ym0IR
XQD5vMOQNWTfRn104cKQ
=ZGBK
-----END PGP SIGNATURE-----


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4DC9A1F5.8090503@thykier.net">http://lists.debian.org/4DC9A1F5.8090503@thykier.net
 

Thread Tools




All times are GMT. The time now is 06:13 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org