FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Java

 
 
LinkBack Thread Tools
 
Old 03-30-2010, 02:01 PM
Damien Raude-Morvan
 
Default Bug#575850: RFS: libspring-webflow-2.0-java

On Mon, 29 Mar 2010 20:41:49 -0430, Miguel Landaeta <miguel@miguel.cc>
wrote:
> Hi mentors,

Hi Miguel,

> I am looking for a sponsor for my package "libspring-webflow-2.0-java".
>
> * Package name : libspring-webflow-2.0-java
> Version : 2.0.8.RELEASE-1
> Upstream Author : SpringSource Inc.
> * URL : http://www.springsource.com/webflow
> * License : Apache-2.0, BSD and others
> Section : java

I'm interested in sponsoring your package.
I'll try to have a look at it this evening or tomorow.

FYI, you might check your Homepage field (debian/control) :
http://www.springsource.com/webflow may be replaced by
http://www.springsource.ORG/webflow
(first version won't work - just redirect to spring source inc. main site)

Cheers,
--
Damien - Debian Developper
http://wiki.debian.org/DamienRaudeMorvan


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: b06f631684f8f67be222978c286fbebb@drazzib.com">http ://lists.debian.org/b06f631684f8f67be222978c286fbebb@drazzib.com
 
Old 03-30-2010, 02:15 PM
Miguel Landaeta
 
Default Bug#575850: RFS: libspring-webflow-2.0-java

On Tue, Mar 30, 2010 at 9:31 AM, Damien Raude-Morvan <drazzib@debian.org> wrote:
> Hi Miguel,

Hi Damien, thanks for review this package.

> I'm interested in sponsoring your package.
> I'll try to have a look at it this evening or tomorow.
>
> FYI, you might check your Homepage field (debian/control) :
> http://www.springsource.com/webflow may be replaced by
> http://www.springsource.ORG/webflow
> (first version won't work - just redirect to spring source inc. main site)

Yes, that was a silly typo only with my RFS email.
The Homepage field in the package is correct.
Homepage: http://www.springsource.org/webflow

I'll wait for your review.
Cheers,

--
Miguel Landaeta, miguel at miguel.cc
secure email with PGP 0x7D8967E9 available at http://keyserver.pgp.com/
"Faith means not wanting to know what is true." -- Nietzsche


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 86aeadee1003300715u79fc5d1n59ff8531e8540150@mail.g mail.com">http://lists.debian.org/86aeadee1003300715u79fc5d1n59ff8531e8540150@mail.g mail.com
 
Old 03-31-2010, 08:42 PM
"Damien Raude-Morvan"
 
Default Bug#575850: RFS: libspring-webflow-2.0-java

Hi Miguel,

Here we go for libspring-webflow-2.0-java review :

- debian/patches/02_fix_compilation.diff
You should try to forward your patch upstream (maybe they'll be please to
deliver you a parser compliant with OGNL version in debian)

- debian/README.Debian-source
Should be renamed to debian/README.source (as per Debian Policy § 4.14)

- debian/control:
* libspring-js-2.0-java short description seems a bit too generic
"Javascript abstraction framework". What about "server-side Javascript
abstraction framework" ?
* libspring-webflow-2.0-java:
junit seems removable
libhibernate3-java is twice + should be Recommends
...

- projects/spring-js/src/main/resources/META-INF/dojo/
Seems already available inside libjs-dojo-core package
1) you can of course ship it inside original tarball (after all it's DFSG-
compliant)
2) you should try to use existing JS and don't embedded it in JAR file. I
don't exactly know how Spring.js can handle this :/ As a general guideline, we
should try to avoid embedded code copies.
Same apply for META-INF/dijix/ (in libjs-dojo-dijix package)

- notice.txt (install)
There is no need to install this file as we already ship it in source form
(orig tarball) and copyright notice are provided by "copyright" file in each
binary package (compliant with Apache License 2.0 §4d)

- readme.txt
Debhelper already take care of changelog.txt, but maybe you should install
readme.txt too ?

- docs/spring-webflow-reference/
As you already strip Javadoc from source package, you may want to remove all
this. (As you may know, docbook source is here : projects/spring-webflow-
reference/)

Embedded code copies is the only blocking issue for me to upload your package.
Can you provide me some feedback about this ?

Cheers,
--
Damien Raude-Morvan - http://www.damien-raude-morvan.com/
 
Old 04-01-2010, 12:09 AM
Miguel Landaeta
 
Default Bug#575850: RFS: libspring-webflow-2.0-java

Hi again Damien, thanks for the review.
Please see my comments below.

On Wed, Mar 31, 2010 at 4:12 PM, Damien Raude-Morvan <drazzib@debian.org> wrote:
> Hi Miguel,
>
> Here we go for libspring-webflow-2.0-java review :
>
> - debian/patches/02_fix_compilation.diff
> You should try to forward your patch upstream (maybe they'll be please to
> deliver you a parser compliant with OGNL version in debian)

Ok, I will try to find how to send that patch to upstream.

> - debian/README.Debian-source
> Should be renamed to debian/README.source (as per Debian Policy § 4.14)

Renamed. Done.

> - debian/control:
> ** libspring-js-2.0-java short description seems a bit too generic
> "Javascript abstraction framework". What about "server-side Javascript
> abstraction framework" ?
> ** libspring-webflow-2.0-java:
> *junit seems removable
> *libhibernate3-java is twice + should be Recommends

Done. I updated the short description for libspring-js-2.0 and fixed the
Depends/Recommends for this package.

> - projects/spring-js/src/main/resources/META-INF/dojo/
> Seems already available inside libjs-dojo-core package
> 1) you can of course ship it inside original tarball (after all it's DFSG-
> compliant)
> 2) you should try to use existing JS and don't embedded it in JAR file. I
> don't exactly know how Spring.js can handle this :/ As a general guideline, we
> should try to avoid embedded code copies.
> Same apply for META-INF/dijix/ (in libjs-dojo-dijix package)

Yes, I forgot that those Javascript frameworks are already available in Debian.
I removed those embedded code copies. Thanks for pointing this out.

> - notice.txt (install)
> There is no need to install this file as we already ship it in source form
> (orig tarball) and copyright notice are provided by "copyright" file in each
> binary package (compliant with Apache License 2.0 §4d)

Done. I removed notice.txt from the binary packages.

> - readme.txt
> Debhelper already take care of changelog.txt, but maybe you should install
> readme.txt too ?

Done. I included that file in the binary packages.

> - docs/spring-webflow-reference/
> As you already strip Javadoc from source package, you may want to remove all
> this. (As you may know, docbook source is here : projects/spring-webflow-
> reference/)

I prefer to not remove those docs yet. The reference manual can be generated
from the source but the ant target provided by upstream to build that
documentation
depends on some libraries not available in Debian yet.

> Embedded code copies is the only blocking issue for me to upload your package.
> Can you provide me some feedback about this ?

I removed those embedded code copies from spring-js jar file.
The right thing should be Recommends libjs-dojo-core and libjs-dojo-dijit
and document this change from upstream in README.Debian.

I uploaded a new version to mentors and pushed the changes to the git repo.
Let me know if more changes are needed.
Cheers,

- URL: http://mentors.debian.net/debian/pool/main/l/libspring-webflow-2.0-java
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/l/libspring-webflow-2.0-java/libspring-webflow-2.0-java_2.0.8.RELEASE-1.dsc
- Vcs-Git: git://git.debian.org/pkg-java/libspring-webflow-2.0-java.git


--
Miguel Landaeta, miguel at miguel.cc
secure email with PGP 0x7D8967E9 available at http://keyserver.pgp.com/
"Faith means not wanting to know what is true." -- Nietzsche


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: u2s86aeadee1003311709q5ed2f2ccjf857657709ce3c27@ma il.gmail.com">http://lists.debian.org/u2s86aeadee1003311709q5ed2f2ccjf857657709ce3c27@ma il.gmail.com
 
Old 04-06-2010, 05:32 PM
"Damien Raude-Morvan"
 
Default Bug#575850: RFS: libspring-webflow-2.0-java

Hi Miguel,

Le jeudi 01 avril 2010 02:09:47, Miguel Landaeta a écrit :
> I uploaded a new version to mentors and pushed the changes to the git repo.
> Let me know if more changes are needed.
> Cheers,
>
> - URL:
> http://mentors.debian.net/debian/pool/main/l/libspring-webflow-2.0-java -
> Source repository: deb-src http://mentors.debian.net/debian unstable main
> contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/l/libspring-webflow-2.0-java/li
> bspring-webflow-2.0-java_2.0.8.RELEASE-1.dsc - Vcs-Git:
> git://git.debian.org/pkg-java/libspring-webflow-2.0-java.git

I've uploaded your last mentors upload as is.
Remember to tag this release in your Git VCS.

Cheers,
--
Damien - Debian Developper
http://wiki.debian.org/DamienRaudeMorvan
 
Old 04-06-2010, 05:50 PM
Miguel Landaeta
 
Default Bug#575850: RFS: libspring-webflow-2.0-java

On Tue, Apr 6, 2010 at 1:02 PM, Damien Raude-Morvan <drazzib@debian.org> wrote:
> I've uploaded your last mentors upload as is.
> Remember to tag this release in your Git VCS.
>

Thank you very much for uploading this package.
Cheers,

--
Miguel Landaeta, miguel at miguel.cc
secure email with PGP 0x7D8967E9 available at http://keyserver.pgp.com/
"Faith means not wanting to know what is true." -- Nietzsche


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: o2r86aeadee1004061050g32166619p5d3cee527fab3@mail. gmail.com">http://lists.debian.org/o2r86aeadee1004061050g32166619p5d3cee527fab3@mail. gmail.com
 

Thread Tools




All times are GMT. The time now is 10:47 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org