FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Java

 
 
LinkBack Thread Tools
 
Old 03-16-2010, 09:31 AM
Radek Vykydal
 
Default Use None, not ', for empty repo proxy attributes (#572460)

Concerns repo setting UI. For proxy_username and proxy_pasword repo
attributes, using empty strings causes creating of invalid proxy specification
string in yum, e.g. http://:@172.16.22.129:8080.

This means that setting proxy without user and password in repo UI
doesn't work.

---
iw/task_gui.py | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/iw/task_gui.py b/iw/task_gui.py
index 0a18da8..2fa916e 100644
--- a/iw/task_gui.py
+++ b/iw/task_gui.py
@@ -200,8 +200,8 @@ class RepoEditor:
self.proxyCheckbox.set_active(True)
self.proxyTable.set_sensitive(True)
self.proxyEntry.set_text(self.repo.proxy)
- self.usernameEntry.set_text(self.repo.proxy_userna me)
- self.passwordEntry.set_text(self.repo.proxy_passwo rd)
+ self.usernameEntry.set_text(self.repo.proxy_userna me or ')
+ self.passwordEntry.set_text(self.repo.proxy_passwo rd or ')
else:
self.proxyCheckbox.set_active(False)
self.proxyTable.set_sensitive(False)
@@ -250,8 +250,9 @@ class RepoEditor:
return False

repo.proxy = proxy
- repo.proxy_username = self.usernameEntry.get_text()
- repo.proxy_password = self.passwordEntry.get_text()
+ # with empty string yum would create invalid proxy string
+ repo.proxy_username = self.usernameEntry.get_text() or None
+ repo.proxy_password = self.passwordEntry.get_text() or None

repourl = self.baseurlEntry.get_text()
repourl.strip()
--
1.6.0.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 05:27 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org