FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Java

 
 
LinkBack Thread Tools
 
Old 01-29-2010, 07:03 PM
Gabriele Giacone
 
Default RFS: sunflow

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dear java people,

I am looking for a sponsor for my package "sunflow".

* Package name : sunflow
Version : 0.07.2.svn396+dfsg-1
Upstream Author : Christopher Kulla <ckulla@gmail.com>
* URL : http://sunflow.sourceforge.net/
* License : MIT
Section : java

It builds these binary packages:
sunflow - rendering system for photo-realistic image synthesis

The package appears to be lintian clean.

My motivation for maintaining this package is:
sweethome3d (ITP [1]) depends on it.
Cyril "KiBi" Brulebois let me to become its new maintainer [2] without
O,RFA,ITA.

http://mentors.debian.net/debian/pool/main/s/sunflow/sunflow_0.07.2.svn396+dfsg-1.dsc

I would be glad if someone reviewed and possibly uploaded this package
for me.

Kind regards
Gabriele Giacone

[1] http://bugs.debian.org/475922
[2] http://bugs.debian.org/557230#12
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAktjPxYACgkQp3cdCbVcnCs5ZACbB4uTUx6is4 qggkXmxjJxiKwo
OKoAoKnSeup1ieI1+YU9NIDSOrjF7Uqb
=5G/7
-----END PGP SIGNATURE-----


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 01-29-2010, 10:04 PM
Damien Raude-Morvan
 
Default RFS: sunflow

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Gabriele,

On 29/01/2010 21:03, Gabriele Giacone wrote:
> I am looking for a sponsor for my package "sunflow".
>
> * Package name : sunflow
[..]
> http://mentors.debian.net/debian/pool/main/s/sunflow/sunflow_0.07.2.svn396+dfsg-1.dsc
>
> I would be glad if someone reviewed and possibly uploaded this package
> for me.

I'll review this new upload.

Cheers,
- --
Damien Raude-Morvan - http://damien.raude-morvan.com/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAktjaWwACgkQyIFXyIXHk4n9lACgnJ61maz9Yn QRaorWdVpGOliD
pKYAn3I4lRDpdEZlBcJE/4KfYP4wsIcS
=ANiv
-----END PGP SIGNATURE-----


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 01-29-2010, 10:45 PM
Gabriele Giacone
 
Default RFS: sunflow

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Damien Raude-Morvan wrote:
> I'll review this new upload.

Thanks for your time.
Cheers,
Gabriele
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAktjcxoACgkQp3cdCbVcnCui8QCgjL8i8E0WJa R4U78ojJaN7wtE
F1QAn3/efBCD9hawKJfDhcS2w8QSbV5q
=Ilk3
-----END PGP SIGNATURE-----


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 01-29-2010, 10:48 PM
Damien Raude-Morvan
 
Default RFS: sunflow

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 29/01/2010 21:03, Gabriele Giacone wrote:
> I am looking for a sponsor for my package "sunflow".
>
> * Package name : sunflow
[...]
> I would be glad if someone reviewed and possibly uploaded this package
> for me.

Here we go !
[Hi Cyril! I've CCed you if you want to add some comments]

debian/copyright:
missing "(C) 2006 by Mad Crew" from
exporters/maya/sunflowExporter/src/skylight.cpp
exporters/maya/sunflowExporter/src/sunskyConstants.h
exporters/maya/sunflowExporter/src/skylight.h

debian/control:
- - I'm not sure about your move "Section: from graphics to java", but YMMV.
- - I'm not really found of "Removed VCS fields" item AFAIK, sunflow is
in in collab-maint [1] and I tend to prefer package to be maintained in
some sort of $VCS (Gabriele, we already had this discussion . You can
request account on Alioth Collab-Maint [2]

debian/patches/20_disable_wheel_movement:
Can you explain what was your build failure with this method ?
(and, by the way, add this explenation to patch header)
#addMouseWheelListener() exist in Java API since 1.4

debian/rules:
- - You are using debian/docs and dh_install release/javadoc/*
usr/share/doc/sunflow/html : you should make a choice
- - You should register your docs with doc-base
- - ... but I don't think there added value by providing Javadoc for Java
applications

[1] http://git.debian.org/?p=collab-maint/sunflow.git
[2] http://wiki.debian.org/Alioth/Git

Cheers,
- --
Damien Raude-Morvan - http://damien.raude-morvan.com/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAktjc9sACgkQyIFXyIXHk4lqIwCguoy/9g91ZKzp4IbwyBKlWmsd
ABEAnRGb3efjKid9SaBV9ZDxlxf8Qb7x
=ESrB
-----END PGP SIGNATURE-----


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 01-30-2010, 09:41 PM
Gabriele Giacone
 
Default RFS: sunflow

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Damien,
Damien Raude-Morvan wrote:
> debian/copyright:
> missing "(C) 2006 by Mad Crew" from
> exporters/maya/sunflowExporter/src/skylight.cpp
> exporters/maya/sunflowExporter/src/sunskyConstants.h
> exporters/maya/sunflowExporter/src/skylight.h
Added.
> debian/control:
> - I'm not sure about your move "Section: from graphics to java", but YMMV.
> - I'm not really found of "Removed VCS fields" item AFAIK, sunflow is
> in in collab-maint [1] and I tend to prefer package to be maintained in
> some sort of $VCS
> (Gabriele, we already had this discussion .
I took a look at my mail archive and no, we didn't have it You talked
to someone else.
I got your point but I tend to prefer the opposite.
Anyway, pushed [1]
> debian/patches/20_disable_wheel_movement:
> Can you explain what was your build failure with this method ?
> (and, by the way, add this explenation to patch header)
> #addMouseWheelListener() exist in Java API since 1.4
Build failure disappeared :| so now mouse wheel works too.
Patch removed.
> debian/rules:
> - You are using debian/docs and dh_install release/javadoc/*
> usr/share/doc/sunflow/html : you should make a choice
> - You should register your docs with doc-base
> - ... but I don't think there added value by providing Javadoc for Java
> applications
Until now, I tried to modify as less as possible Cyril's work because
svn snapshot shouldn't be too much different from the latest Debian
version 0.07.2 and even because Cyril is a DD and we all trust in his
work, don't we?
"no added value with javadoc for java apps": THIS is a discussion we had
for jxplorer and I removed javadoc.
IMHO, this case is different because sunflow is a dependency of
sweethome3d which uses sunflow's API in svn snapshot version (that's why
I'm packaging it). Would adding -doc binary be better?
What about following this draft about javadoc?
http://wiki.debian.org/Java/Draft#line-43

Cheers,
Gabriele

[1] git://git.debian.org/collab-maint/sunflow.git
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAktktbUACgkQp3cdCbVcnCtppgCfd3r9A4XkB9 3+2HBguTb5XGOD
rKoAoO+EbyS+H9FRFJOTLRhbGRu0GVdB
=9wmK
-----END PGP SIGNATURE-----


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 01-31-2010, 10:38 AM
Damien Raude-Morvan
 
Default RFS: sunflow

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

On 30/01/2010 23:41, Gabriele Giacone wrote:
>> debian/rules:
>> - You are using debian/docs and dh_install release/javadoc/*
>> usr/share/doc/sunflow/html : you should make a choice
>> - You should register your docs with doc-base
>> - ... but I don't think there added value by providing Javadoc for Java
>> applications
> Until now, I tried to modify as less as possible Cyril's work because
> svn snapshot shouldn't be too much different from the latest Debian
> version 0.07.2 and even because Cyril is a DD and we all trust in his
> work, don't we?

I don't blindly trust in my own work, so there is little chance that I
do for others

> "no added value with javadoc for java apps": THIS is a discussion we had
> for jxplorer and I removed javadoc.
> IMHO, this case is different because sunflow is a dependency of
> sweethome3d which uses sunflow's API in svn snapshot version (that's why
> I'm packaging it). Would adding -doc binary be better?
> What about following this draft about javadoc?

[As disclaimer, I would say that Debian Java policy is clearly outdated
and I don't know if someone is currently working on it...]

I had a look at Sunflow Javadoc and there is some interessing bits, so
you might keep it.

Furthermore, if you want to update your package to follow Java Policy,
you might split packages :
- - libsunflow-java (library part) :
* JAR file in /usr/share/java/ (org/sunflow/*)
- - libsunflow-java-doc :
* Javadoc and doc-base registration
- - sunflow (main part) :
* JAR file in /usr/share/java/sunflow-gui.jar (SunflowGUI*.class)
* wrapper script in /usr/bin/
* Depends on JRE (no headless)
So that, sweethome3d can Depends on libsunflow-java without pulling
.desktop/menu files or Javadoc HTML files.

I don't know if its possible with Sunflow and I won't request that to
accept sponsoring your package. But it may be a wise task

Could you provide me an updated .dsc with your previous fix ?

Greetings,
- --
Damien Raude-Morvan - http://damien.raude-morvan.com/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAktla5cACgkQyIFXyIXHk4kYiACfb6NiXuAcWJ zOXbWtPjOwF70E
z4EAn16z0pYHUYvJoBcAnO6D38e9dvOT
=33Uz
-----END PGP SIGNATURE-----


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 

Thread Tools




All times are GMT. The time now is 12:28 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org