Request for review
 

Hello,

I'd like to get my package png-sixlegs
(svn://svn.debian.org/wsvn/pkg-java/trunk/png-sixlegs/) reviewed by
potential sponsor.

I definitely need some feedback before continuing to work.

Package is uploaded at
http://mentors.debian.net/debian/pool/main/p/png-sixlegs too, but I'm
not sure if it's still needed (when it's in SVN already).

Thanks a lot.

Dominik Smatana


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

Request for review
 

On Mon Mar 23 23:51, Dominik Smatana wrote:
> Hello,
>
> I'd like to get my package png-sixlegs
> (svn://svn.debian.org/wsvn/pkg-java/trunk/png-sixlegs/) reviewed by
> potential sponsor.

Hi, I've had a look at the stuff in svn.

You should not have an alternate build dep, they don't work properly in
pbuilder and we want repeatable build every time with the same JDK no
matter which is installed. Pick one; if default-jdk works, we recommend
that. For the dependency on the library we are now requesting that
libraries do not depend on runtimes at all. I also wouldn't recommend a
web browser for the doc either, it's really not necessary.

The long description seems malformatted with stray ^Ms, please make sure
it's wrapped at 80 cols and uses unix line endings.

Because we want repeatability you also need to ensure that you always
use the same javac to build, no matter what the alternative is. Since
you are manually compiling and jaring, may I suggest javahelper, which
has a module to do this for you (and also a bunch of other useful
things). There is documentation in the javahelper package.

Current java policy says you should install a versionned jar and a plain
symlink in /usr/share/java. I'm unconvinced of the utility of this, but
it's what's recommended. javahelper also can do this for you.

Finally, please remove all the dh_ lines which are commented out if you
aren't using them.

HTH,
Matt

--
Matthew Johnson

Request for review
 

Hello,

On Tue, Mar 24, 2009 at 12:06 AM, Matthew Johnson <mjj29@debian.org> wrote:
> On Mon Mar 23 23:51, Dominik Smatana wrote:
>> Hello,
>>
>> I'd like to get my package png-sixlegs
>> (svn://svn.debian.org/wsvn/pkg-java/trunk/png-sixlegs/) reviewed by
>> potential sponsor.
>
> Hi, I've had a look at the stuff in svn.
>
> You should not have an alternate build dep, they don't work properly in
> pbuilder and we want repeatable build every time with the same JDK no
> matter which is installed. Pick one; if default-jdk works, we recommend
> that.

Thanks for explanation, fixed in r8112.


> For the dependency on the library we are now requesting that
> libraries do not depend on runtimes at all.

Fixed in r8112, I think "Debian policy for Java" (
http://www.debian.org/doc/packaging-manuals/java-policy/x105.html )
should be updated to stop confusing newbie packagers like me :)


>I also wouldn't recommend a
> web browser for the doc either, it's really not necessary.

Fixed in r8112.


> The long description seems malformatted with stray ^Ms, please make sure
> it's wrapped at 80 cols and uses unix line endings.

What a shame! No comment... fixed in r8112 :(



> Because we want repeatability you also need to ensure that you always
> use the same javac to build, no matter what the alternative is. Since
> you are manually compiling and jaring, may I suggest javahelper, which
> has a module to do this for you (and also a bunch of other useful
> things). There is documentation in the javahelper package.
>
> Current java policy says you should install a versionned jar and a plain
> symlink in /usr/share/java. I'm unconvinced of the utility of this, but
> it's what's recommended. javahelper also can do this for you.

TBD, I'm getting myself familiar with javahelper and cdbs, I didn't
know about these...


> Finally, please remove all the dh_ lines which are commented out if you
> aren't using them.

Fixed in r8112 (debian/rules will be replaced by cdbs version anyway soon).

Thanks a lot for your feedback, I really appreciate it.

Regards
Dominik Smatana


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

Request for review
 

On Tue Mar 24 18:53, Dominik Smatana wrote:
> > For the dependency on the library we are now requesting that
> > libraries do not depend on runtimes at all.
>
> Fixed in r8112, I think "Debian policy for Java" (
> http://www.debian.org/doc/packaging-manuals/java-policy/x105.html )
> should be updated to stop confusing newbie packagers like me :)

Yeah, it's on the list of things to do at debconf.

> > Because we want repeatability you also need to ensure that you always
> > use the same javac to build, no matter what the alternative is. Since
> > you are manually compiling and jaring, may I suggest javahelper, which
> > has a module to do this for you (and also a bunch of other useful
> > things). There is documentation in the javahelper package.

You still don't explicitly set which javac and jar program you are
using. You must use /usr/lib/jvm/default-jdk/bin/javac instead of javac
(or whichever path you are using). Also, I think the recommended depend
is actually default-jdk-builddep (I always forget that).

Things like javahelper make this easy, since you can just set JAVA_HOME
at the top of rules.

> > Current java policy says you should install a versionned jar and a plain
> > symlink in /usr/share/java. I'm unconvinced of the utility of this, but
> > it's what's recommended. javahelper also can do this for you.
>
> TBD, I'm getting myself familiar with javahelper and cdbs, I didn't
> know about these...

Ditto, whether you use javahelper/cdbs (or both, there's a cdbs class
for it now) or not, you should install the jar as png-$version.jar and
then a symlink from png.jar to it.

Looking pretty good though,

Matt

--
Matthew Johnson

Request for review
 

On Wed, Mar 25, 2009 at 5:15 PM, Matthew Johnson <mjj29@debian.org> wrote:
> On Tue Mar 24 18:53, Dominik Smatana wrote:
>> > For the dependency on the library we are now requesting that
>> > libraries do not depend on runtimes at all.
>>
>> Fixed in r8112, I think "Debian policy for Java" (
>> http://www.debian.org/doc/packaging-manuals/java-policy/x105.html )
>> should be updated to stop confusing newbie packagers like me :)
>
> Yeah, it's on the list of things to do at debconf.
>
>> > Because we want repeatability you also need to ensure that you always
>> > use the same javac to build, no matter what the alternative is. Since
>> > you are manually compiling and jaring, may I suggest javahelper, which
>> > has a module to do this for you (and also a bunch of other useful
>> > things). There is documentation in the javahelper package.
>
> You still don't explicitly set which javac and jar program you are
> using. You must use /usr/lib/jvm/default-jdk/bin/javac instead of javac
> (or whichever path you are using). Also, I think the recommended depend
> is actually default-jdk-builddep (I always forget that).

Setting JAVA_HOME is the preferred way instead of using complete path for javac.
default-jdk-builddep is to be used only when you are also creating a
-gcj binary package.

By the way, I am not sure how well javahelper and cdbs go. But if you
write a small ant build script (if you are familiar with ant) then the
ant/cdbs combo will make life easier.


Onkar


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

Request for review
 

On Wed Mar 25 18:17, Onkar Shinde wrote:
> > You still don't explicitly set which javac and jar program you are
> > using. You must use /usr/lib/jvm/default-jdk/bin/javac instead of javac
> > (or whichever path you are using). Also, I think the recommended depend
> > is actually default-jdk-builddep (I always forget that).
>
> Setting JAVA_HOME is the preferred way instead of using complete path for javac.
> default-jdk-builddep is to be used only when you are also creating a
> -gcj binary package.

Setting JAVA_HOME doesn't help if you then call javac unqualified...

> By the way, I am not sure how well javahelper and cdbs go. But if you
> write a small ant build script (if you are familiar with ant) then the
> ant/cdbs combo will make life easier.

javahelper + cdbs works fine, you just have to set two variables and
it'll do what Dominik needs, no writing of ant scripts at all

Matt

--
Matthew Johnson

Request for review
 

On Wed, Mar 25, 2009 at 6:33 PM, Matthew Johnson <mjj29@debian.org> wrote:
> On Wed Mar 25 18:17, Onkar Shinde wrote:
>> > You still don't explicitly set which javac and jar program you are
>> > using. You must use /usr/lib/jvm/default-jdk/bin/javac instead of javac
>> > (or whichever path you are using). Also, I think the recommended depend
>> > is actually default-jdk-builddep (I always forget that).
>>
>> Setting JAVA_HOME is the preferred way instead of using complete path for javac.
>> default-jdk-builddep is to be used only when you are also creating a
>> -gcj binary package.
>
> Setting JAVA_HOME doesn't help if you then call javac unqualified...

It works, believe me. You can check xml-commons-external package if you wish.


Onkar


--
To UNSUBSCRIBE, email to debian-java-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

Request for review
 

On Wed Mar 25 19:53, Onkar Shinde wrote:
> On Wed, Mar 25, 2009 at 6:33 PM, Matthew Johnson <mjj29@debian.org> wrote:
> > On Wed Mar 25 18:17, Onkar Shinde wrote:
> >> > You still don't explicitly set which javac and jar program you are
> >> > using. You must use /usr/lib/jvm/default-jdk/bin/javac instead of javac
> >> > (or whichever path you are using). Also, I think the recommended depend
> >> > is actually default-jdk-builddep (I always forget that).
> >>
> >> Setting JAVA_HOME is the preferred way instead of using complete path for javac.
> >> default-jdk-builddep is to be used only when you are also creating a
> >> -gcj binary package.
> >
> > Setting JAVA_HOME doesn't help if you then call javac unqualified...
>
> It works, believe me. You can check xml-commons-external package if you wish.

Really?

This would seem to suggest not:

$ javac -version
Eclipse Java Compiler v_774_R33x, 3.3.1, Copyright IBM Corp 2000, 2007. All rights reserved.
$ JAVA_HOME=/usr/lib/jvm/java-1.5.0-sun javac -version
Eclipse Java Compiler v_774_R33x, 3.3.1, Copyright IBM Corp 2000, 2007. All rights reserved.
$ export JAVA_HOME=/usr/lib/jvm/java-1.5.0-sun
$ javac -version
Eclipse Java Compiler v_774_R33x, 3.3.1, Copyright IBM Corp 2000, 2007. All rights reserved.
$ $JAVA_HOME/bin/javac -version
javac 1.5.0_17
javac: no source files

I also looked at xml-commons-external; if I use update-alternatives to point
javac to java-1.5.0-sun, then dpkg-buildpackage produces (trimmed):

Note: org/w3c/dom/bootstrap/DOMImplementationRegistry.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

whereas, with the alternative set to java-gcj it produces:

----------
1. WARNING in org/w3c/css/sac/CSSException.java (at line 18)
public class CSSException extends RuntimeException {
^^^^^^^^^^^^
The serializable class CSSException does not declare a static final serialVersionUID field of type long
----------
----------
2. WARNING in org/w3c/css/sac/CSSParseException.java (at line 30)
public class CSSParseException extends CSSException {
^^^^^^^^^^^^^^^^^
The serializable class CSSParseException does not declare a static final serialVersionUID field of type long
----------
2 problems (2 warnings)

Clearly different behavior. The point of setting $JAVA_HOME is that
ant/javahelper will use that rather than what's on path and therefore there's
no difference. Just calling javac, however, will use whatever is on path. You
need to have $JAVA_HOME/bin/javac in debian/rules if you are going to do it by
hand.

If you were to use the new javahelper cdbs class you could almost certainly
replace everything with:

JH_BUILD_SRC=org
JH_BUILD_JAR=external.jar

and a debian/xml-commons-external.jlibs

Matt

--
Matthew Johnson

Request for review
 

Hello,

On Wed, Mar 25, 2009 at 12:45 PM, Matthew Johnson <mjj29@debian.org> wrote:

You still don't explicitly set which javac and jar program you are
using. You must use /usr/lib/jvm/default-jdk/bin/javac instead of javac
(or whichever path you are using).
Things like javahelper make this easy, since you can just set JAVA_HOME

at the top of rules.


fixed in r8112


Also, I think the recommended depend
is actually default-jdk-builddep (I always forget that).


Should I change:
Build-Depends-Indep: default-jdk
to:
Build-Depends-Indep: default-jdk-builddep
?



Current java policy says you should install a versionned jar and a plain
symlink in /usr/share/java. I'm unconvinced of the utility of this, but
it's what's recommended. javahelper also can do this for you.


fixed in r8112


I got this warning:
jh_libs -i
Warning: This command has been deprecated in favour of jh_installibs

I'm going to check jh_installibs then...


Thanks for feedback.
Dominik Smatana

Request for review
 

On Wed Mar 25 16:40, Dominik Smatana wrote:
>> Also, I think the recommended depend
>> is actually default-jdk-builddep (I always forget that).
>
> Should I change:
> Build-Depends-Indep: default-jdk
> to:
> Build-Depends-Indep: default-jdk-builddep

Well, currently default-jdk-builddep => default-jdk, so it's pretty
irrelevant, but yeah, it's probably a good idea

> I got this warning:
> jh_libs -i
> Warning: This command has been deprecated in favour of jh_installibs
>
> I'm going to check jh_installibs then...

Oh, yeah, they are identical, but someone said jh_installibs was more in
line with the dh_ command names.

It all seems to build properly. My only question, why aren't you
packaging version 2.0, which seems to be on the project page?

Matt

--
Matthew Johnson