Hi,

Le Sunday 17 August 2008 17:42:18 Cyril Brulebois, vous avez écritÂ*:
> - I assume libjline-java will pull the needed java machinery so you
> don't have to depend on a java runtime environment; is that correct?

As said by Matthew, sqlline is an application so it must depends on JRE.
I've added that to debian/control, see changelog.

> - I assume ant doesn't call any java-ish stuff in the clean target;
> otherwise you would have to move java-gcj-compat-dev to B-D.

Ant call build.xml clean target during debian/rules clean rules, so I need
java-gcj-compat-dev in B-D. Done.

> - debian/rules:
> - whitespaces line 2.
> - if you're using dh_install in “install/sqlline:�, no need to add
> this directory to the “dirs� file.
> - you could modify this target like that:
> - put the jar file and its location in an “install� file.
> - do the same for the wrapper.
> - only do a “mv� in this target.
> - the “dirs� file can go away.

Done.

> - Please add full stops at the end of the sentences of your long
> description. The other dots are only here for “folding� (see RFC
> (2)822).
> - Nothing important, but you have trailing spaces in debian/copyright,
> you may want to use show-wspace.el if you're an Emacs user.
> - You may want to limit the line length of your README.Debian to <= 80
> characters; might improve readibility, especially on servers with
> only the default 80x25 console.
> - No space before “:�, “;�, “!�, etc. in English (same file).
> - Also, s/take/takes/.
> - README.source (whitespaces again) can disappear. All copyright info
> must be in debian/copyright, so please move its contents there.
> - I'd s/(C)/©/ in your copyright statement (about Debian packaging)
> since only “Copyright�, “Copr.�, and “©� are legally recognized.

I've corrected all those tiny things.

> - Also, when packaging something under a “liberal� license (like the
> BSD licenses), you may want to license the packaging under the same
> license, that might help upstream integrate patches, and so on.

You're right. Done.

I've uploaded a new version (same revision) to mentors so you can have a look.

Good night,
--
Damien Raude-Morvan / www.drazzib.com