Hi Salvatore,

In src/ansi-c/c_preprocess.cpp, the #include <unistd.h> changed by
KiBi's patch is still wrapped in #ifdef __linux__.

I would think:

#if defined(__linux__) || defined(__GNU__) || defined(__GLIBC__)

is the best way to cover Linux/kFreeBSD/Hurd.

Regards,
--
Steven Chamberlain
steven@pyro.eu.org


--
To UNSUBSCRIBE, email to debian-gcc-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4FB814C5.5030609@pyro.eu.org">http://lists.debian.org/4FB814C5.5030609@pyro.eu.org

Hi!

Steven Chamberlain <steven@pyro.eu.org> writes:
> #if defined(__linux__) || defined(__GNU__) || defined(__GLIBC__)

__GLIBC__ should cover all of them alone. Or alternatively consistently
checking for kernels:

#if defined(__linux__) || defined(__GNU__) || defined(__FreeBSD_kernel__)

Regards

Christoph

--
9FED 5C6C E206 B70A 5857 70CA 9655 22B9 D49A E731
Debian Developer | Lisp Hacker | CaCert Assurer


--
To UNSUBSCRIBE, email to debian-gcc-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 87fwav7rtr.fsf@hepworth.siccegge.de">http://lists.debian.org/87fwav7rtr.fsf@hepworth.siccegge.de

tags 673579 + patch
thanks

On 19/05/12 23:02, Christoph Egger wrote:
> Steven Chamberlain <steven@pyro.eu.org> writes:
>> #if defined(__linux__) || defined(__GNU__) || defined(__GLIBC__)
>
> __GLIBC__ should cover all of them alone. Or alternatively consistently
> checking for kernels [...]

Oh I see, thanks. I think it is the userland we are interested in here
so __GLIBC__ sounds right.

Please find a patch attached (to apply after KiBi's) which I have tested
on kfreebsd-i386.

I've no idea if __GLIBC__ exists on __APPLE__ or other non-Debian
platforms but I guess we don't need to worry about them, so I've left
that alone.

Regards,
--
Steven Chamberlain
steven@pyro.eu.org

tags 673579 + pending
thanks

Hi

(I added Michael Taautschnig directly to the loop)

On Sat, May 19, 2012 at 11:25:41PM +0100, Steven Chamberlain wrote:
> tags 673579 + patch
> thanks
>
> On 19/05/12 23:02, Christoph Egger wrote:
> > Steven Chamberlain <steven@pyro.eu.org> writes:
> >> #if defined(__linux__) || defined(__GNU__) || defined(__GLIBC__)
> >
> > __GLIBC__ should cover all of them alone. Or alternatively consistently
> > checking for kernels [...]
>
> Oh I see, thanks. I think it is the userland we are interested in here
> so __GLIBC__ sounds right.
>
> Please find a patch attached (to apply after KiBi's) which I have tested
> on kfreebsd-i386.
>
> I've no idea if __GLIBC__ exists on __APPLE__ or other non-Debian
> platforms but I guess we don't need to worry about them, so I've left
> that alone.

Steven, many thanks for pointing to this.

Michael, I did the NMU some days ago, trying to help on some RC bugs
for wheezy. I will upload the package with the fix again, with
DELAYED/2 only.

Please let me know if I should cancel, and if you would like to do the
upload.

Regards, and sorry for the noise
Salvatore

2012/5/20 Christoph Egger <christoph@debian.org>:
> __GLIBC__ should cover all of them alone. Or alternatively consistently
> checking for kernels:
>
> #if defined(__linux__) || defined(__GNU__) || defined(__FreeBSD_kernel__)

Please keep in mind __FreeBSD_kernel__ doesn't imply anything about
userland. In fact this macro is defined in recent versions of
FreeBSD.

--
Robert Millan


--
To UNSUBSCRIBE, email to debian-gcc-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: CAOfDtXMUdWK9TaqiR6xKRqYa2B1QWUMg-Xq_XTezJb5FZ=f_zw@mail.gmail.com">http://lists.debian.org/CAOfDtXMUdWK9TaqiR6xKRqYa2B1QWUMg-Xq_XTezJb5FZ=f_zw@mail.gmail.com