Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Debian dpkg (http://www.linux-archive.org/debian-dpkg/)
-   -   dpkg's main repository branch, master, updated. 1.16.2-81-g3d5278b (http://www.linux-archive.org/debian-dpkg/655876-dpkgs-main-repository-branch-master-updated-1-16-2-81-g3d5278b.html)

Sven Joachim 04-14-2012 09:27 AM

dpkg's main repository branch, master, updated. 1.16.2-81-g3d5278b
 
On 2012-04-14 09:17 +0200, Guillem Jover wrote:

> The following commit has been merged in the master branch:
> commit a354992c67411ed10499786012701faa33ed8565
> Author: Guillem Jover <guillem@debian.org>
> Date: Sat Apr 14 04:26:52 2012 +0200
>
> dpkg-deb: Add epoch when needed to built package names
>
> The upstream part of the version can already contain colons, so there's
> no reason not to add it for the epoch, and this allows to store on the
> same directory packages with same version but different epoch.
>
> Closes: #551323

This seems to break dpkg-genchanges, e.g. when building acpid:

,----
| dpkg-deb: building package `acpid' in `../acpid_1:2.0.16-1_i386.deb'.
| dpkg-deb: building package `kacpimon' in `../kacpimon_1:2.0.16-1_i386.deb'.
| dpkg-genchanges >../acpid_2.0.16-1_i386.changes
| dpkg-genchanges: including full source code in upload
| dpkg-genchanges: error: cannot fstat file ../acpid_2.0.16-1_i386.deb: No such file or directory
| dpkg-buildpackage: error: dpkg-genchanges gave error exit status 2
`----

> diff --git a/debian/changelog b/debian/changelog
> index a299312..214e240 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -27,6 +27,8 @@ dpkg (1.16.3) UNRELEASED; urgency=low
> current locale (although this was only affecting the old deb format).
> * Ignore the minor format version number for deb-split format, unifying
> the behaviour with the deb format.
> + * Add epoch when needed to package names generated by dpkg-deb.
> + Closes: #551323
>
> [ Helge Kreutzmann ]
> * Fix a typo in man/dpkg-buildflags.1.
> diff --git a/dpkg-deb/build.c b/dpkg-deb/build.c
> index 7efb244..d44b3a6 100644
> --- a/dpkg-deb/build.c
> +++ b/dpkg-deb/build.c
> @@ -373,7 +373,7 @@ pkg_get_pathname(const char *dir, struct pkginfo *pkg)
> char *path;
> const char *versionstring, *arch_sep;
>
> - versionstring = versiondescribe(&pkg->available.version, vdew_never);
> + versionstring = versiondescribe(&pkg->available.version, vdew_nonambig);
> arch_sep = pkg->available.arch->type == arch_none ? "" : "_";
> m_asprintf(&path, "%s/%s_%s%s%s%s", dir, pkg->set->name, versionstring,
> arch_sep, pkg->available.arch->name, DEBEXT);

Cheers,
Sven


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 87aa2e64to.fsf@turtle.gmx.de">http://lists.debian.org/87aa2e64to.fsf@turtle.gmx.de

Raphael Hertzog 04-14-2012 12:44 PM

dpkg's main repository branch, master, updated. 1.16.2-81-g3d5278b
 
On Sat, 14 Apr 2012, Sven Joachim wrote:
> This seems to break dpkg-genchanges, e.g. when building acpid:

And it will break many infrastructure tools. I know that various QA tools
build the path name directly from the package name and the version without
referring to any "Packages" files. And they explicitely strip the epoch
when doing so...

It means the archive will be inconsistent during quite a long time with
packages where the epoch is and is not in the filename.

IMO this change needs further discussion and buy in before being deployed.

Also why doing it only for .deb and not for the source package too ? At
least the ".dsc/.debian.tar.gz/.diff.gz" should follow the same rule IMO.

Cheers,
--
Raphaël Hertzog ◈ Debian Developer

Pre-order a copy of the Debian Administrator's Handbook and help
liberate it: http://debian-handbook.info/liberation/


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20120414124404.GA16920@rivendell.home.ouaza.com">h ttp://lists.debian.org/20120414124404.GA16920@rivendell.home.ouaza.com

Joerg Jaspert 04-14-2012 04:20 PM

dpkg's main repository branch, master, updated. 1.16.2-81-g3d5278b
 
>> This seems to break dpkg-genchanges, e.g. when building acpid:
> And it will break many infrastructure tools. I know that various QA tools
> build the path name directly from the package name and the version without
> referring to any "Packages" files. And they explicitely strip the epoch
> when doing so...

Uh, yes, such a major change shouldn't make it into any dpkg in use
until it got properly discussed and tools adapted.

> It means the archive will be inconsistent during quite a long time with
> packages where the epoch is and is not in the filename.

The archive won't "break", I think, from a quick look - it will just refuse
to process any upload of a package with files with an epoch in it for
not finding the files. No wonder, they unexpectedly changed names.

> IMO this change needs further discussion and buy in before being deployed.

Ack.

--
bye, Joerg
Bart, with $10,000, we'd be millionaires! We could buy all kinds of
useful things like...love!


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 87y5pyjner.fsf@gkar.ganneff.de">http://lists.debian.org/87y5pyjner.fsf@gkar.ganneff.de


All times are GMT. The time now is 10:42 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.