FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian dpkg

 
 
LinkBack Thread Tools
 
Old 12-02-2011, 01:55 PM
Raphael Hertzog
 
Default 2 small patches

Hi Guillem,

I have these two small patches sitting in my pu/master. One helps to fail
earlier when a .list file is not a regular file (usually due to filesystem
corruption, see http://bugs.launchpad.net/bugs/369898) and the other fixes
ensure_package_clientdata() to initializes all fields (cleaner API wise
but makes no practical difference since in the few cases where that field
was used it was already manually reset).

Any objection to those changes ?

(For the first change, since we already do a fstat() adding the check
has almost no cost.)

Cheers,
--
Raphaël Hertzog ◈ Debian Developer

Pre-order a copy of the Debian Administrator's Handbook and help
liberate it: http://debian-handbook.info/liberation/
 
Old 12-05-2011, 07:57 AM
Guillem Jover
 
Default 2 small patches

On Fri, 2011-12-02 at 15:55:12 +0100, Raphael Hertzog wrote:
> I have these two small patches sitting in my pu/master. One helps to fail
> earlier when a .list file is not a regular file (usually due to filesystem
> corruption, see http://bugs.launchpad.net/bugs/369898) and the other fixes
> ensure_package_clientdata() to initializes all fields (cleaner API wise
> but makes no practical difference since in the few cases where that field
> was used it was already manually reset).
>
> Any objection to those changes ?

I've pushed those two to master now, with a modified error message, and
reworded and extended commit logs.

thanks,
guillem


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20111205085728.GB17383@gaara.hadrons.org">http://lists.debian.org/20111205085728.GB17383@gaara.hadrons.org
 

Thread Tools




All times are GMT. The time now is 04:13 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org