FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian dpkg

 
 
LinkBack Thread Tools
 
Old 09-13-2011, 03:38 AM
Guillem Jover
 
Default dpkg's main repository branch, master, updated. 1.16.0.3-319-gbf9cefe

On Mon, 2011-09-12 at 08:25:13 +0000, RaphaŽl Hertzog wrote:
> The following commit has been merged in the master branch:
> commit 9dcb50a59414e1fe0e6a8a4c8ee9f59d10706396
> Author: RaphaŽl Hertzog <hertzog@debian.org>
> Date: Mon Sep 12 09:42:11 2011 +0200
>
> update-alternatives: new non-regression test
>
> This one catches the regression introduced in
> 6c481e19a532080643e3cf5c76760df8009ea2c7 and fixed in
> 9dceac005a0331ceb840f9c8273c7fd195413516.
>
> It should also catch the former problem of passing NULL to stat() (via
> new_file). But this did not trigger any segfault, merely a failure
> with EFAULT.

Hrmm, should not have trusted the existing code when changing to
xreadlink. Because even if on Linux (and other kernels) it returns
EFAULT, due to the argument being handled directly by the kernel,
there's no guarantee it cannot segfault, and the system has all the
right to do so, as such that's not a portable assumption to make.
For example it *does* segfault on the Hurd.

thanks,
guillem


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20110913033837.GA8690@gaara.hadrons.org">http://lists.debian.org/20110913033837.GA8690@gaara.hadrons.org
 
Old 09-13-2011, 05:51 AM
Raphael Hertzog
 
Default dpkg's main repository branch, master, updated. 1.16.0.3-319-gbf9cefe

On Tue, 13 Sep 2011, Guillem Jover wrote:
> On Mon, 2011-09-12 at 08:25:13 +0000, Rapha√ęl Hertzog wrote:
> > The following commit has been merged in the master branch:
> > commit 9dcb50a59414e1fe0e6a8a4c8ee9f59d10706396
> > Author: Rapha√ęl Hertzog <hertzog@debian.org>
> > Date: Mon Sep 12 09:42:11 2011 +0200
> >
> > update-alternatives: new non-regression test
> >
> > This one catches the regression introduced in
> > 6c481e19a532080643e3cf5c76760df8009ea2c7 and fixed in
> > 9dceac005a0331ceb840f9c8273c7fd195413516.
> >
> > It should also catch the former problem of passing NULL to stat() (via
> > new_file). But this did not trigger any segfault, merely a failure
> > with EFAULT.
>
> Hrmm, should not have trusted the existing code when changing to
> xreadlink. Because even if on Linux (and other kernels) it returns
> EFAULT, due to the argument being handled directly by the kernel,
> there's no guarantee it cannot segfault, and the system has all the
> right to do so, as such that's not a portable assumption to make.
> For example it *does* segfault on the Hurd.

Yeah, there definitely was a theoretical bug there. But in practice
it's almost never triggered as the alternative link usually only exists
if the corresponding /etc/alternatives link is there too.

Cheers,
--
Rapha√ęl Hertzog ‚óą Debian Developer

Follow my Debian News ‚Ė∂ http://RaphaelHertzog.com (English)
‚Ė∂ http://RaphaelHertzog.fr (Fran√ßais)


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20110913055101.GN13263@rivendell.home.ouaza.com">h ttp://lists.debian.org/20110913055101.GN13263@rivendell.home.ouaza.com
 

Thread Tools




All times are GMT. The time now is 07:25 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org