FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Development

 
 
LinkBack Thread Tools
 
Old 05-18-2008, 07:51 AM
Andreas Tille
 
Default Should dpkg-source -x list patches ( How to handle Debian patches)

On Fri, 16 May 2008, Raphael Hertzog wrote:


I totally agree that we need to make our changes more visible. In the
openssl case, the patch in question is inside the .diff.gz and you don't
notice it in the unpacked source package. I tend to give a look to what's
in debian/patches/ when I rebuild a package but not to what's in .diff.gz
only.


If I inspect an unknown package I always do

zgrep "^+++ " *.diff.gz | grep -v "/debian/"

and I wonder whether I should file a bug report against "dpkg-source -x"
to do this by default.

Kind regards

Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 05-18-2008, 01:28 PM
Russ Allbery
 
Default Should dpkg-source -x list patches ( How to handle Debian patches)

Neil Williams <codehelp@debian.org> writes:

> Incidentally, you can collapse the zgrep into lsdiff -z:
>
> $ lsdiff -z *.diff.gz | grep -v debian

lsdiff -z -x '*/debian/*' *.diff.gz

--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 05-18-2008, 09:19 PM
Andreas Tille
 
Default Should dpkg-source -x list patches ( How to handle Debian patches)

On Sun, 18 May 2008, Raphael Hertzog wrote:


With the 3.0 quilt format, dpkg-source -x will list each patch that it
applies (and since the debian directory is stored in a tarball and not in
a .diff, it always means _real_ changes contrary to the v1 format where we
always see the line "applying ....diff.gz").


Well, I don't know anything about quilt 3.0 and I was actually talking about
packages that do *not* using quilt or any other patch system, but just "hide"
some patches in the diff.gz. I would like to see dpkg-source -x make some
noise about this fact - actually this idea came to me when you said that your
normally overlook those patches. So we might nead this feature for all the
packages that *do* *not* use quilt.

And I aczually do not really care whether it is implemented using grep or

lsdiff -z -x '*/debian/*' *.diff.gz
or whatever - as long as I get a list of patched files brought up to my

intention immediately.

Kind regards

Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 05-18-2008, 10:27 PM
Bernd Eckenfels
 
Default Should dpkg-source -x list patches ( How to handle Debian patches)

In article <alpine.DEB.1.10.0805182312210.25290@wr-linux02> you wrote:
> lsdiff -z -x '*/debian/*' *.diff.gz
> or whatever - as long as I get a list of patched files brought up to my
> intention immediately.

I dont see a reason why the normal unpack action should spam the user. If
you care about the changes, just use the command. You can even have an alias
if you prefer that.

BTW:
+++ openssl-0.9.8g/Makefile
+++ openssl-0.9.8g/Configure
+++ openssl-0.9.8g/Makefile.shared
+++ openssl-0.9.8g/config
+++ openssl-0.9.8g/Makefile.org
+++ openssl-0.9.8g/openssl.ld
+++ openssl-0.9.8g/debian/libcrypto0.9.8-udeb.dirs
+++ openssl-0.9.8g/VMS/VMSify-conf.pl
+++ openssl-0.9.8g/Netware/do_tests.pl
+++ openssl-0.9.8g/apps/s_time.c
+++ openssl-0.9.8g/apps/CA.sh
+++ openssl-0.9.8g/apps/CA.pl.in
+++ openssl-0.9.8g/apps/speed.c
+++ openssl-0.9.8g/apps/CA.pl
+++ openssl-0.9.8g/os2/backwardify.pl
+++ openssl-0.9.8g/engines/Makefile
+++ openssl-0.9.8g/engines/openssl.ld
+++ openssl-0.9.8g/tools/c_rehash
+++ openssl-0.9.8g/tools/c_rehash.in
+++ openssl-0.9.8g/ssl/t1_lib.c
+++ openssl-0.9.8g/ms/uplink.pl
+++ openssl-0.9.8g/demos/tunala/configure.in
+++ openssl-0.9.8g/doc/Makefile
+++ openssl-0.9.8g/doc/apps/c_rehash.pod
+++ openssl-0.9.8g/crypto/Makefile
+++ openssl-0.9.8g/crypto/x86cpuid.pl
+++ openssl-0.9.8g/crypto/opensslconf.h
+++ openssl-0.9.8g/crypto/x86_64cpuid.pl
+++ openssl-0.9.8g/crypto/md5/asm/md5-x86_64.pl
+++ openssl-0.9.8g/crypto/md5/asm/md5-sparcv9.S
+++ openssl-0.9.8g/crypto/sha/sha.h
+++ openssl-0.9.8g/crypto/sha/asm/sha1-ia64.pl
+++ openssl-0.9.8g/crypto/sha/asm/sha512-sse2.pl
+++ openssl-0.9.8g/crypto/sha/asm/sha512-ia64.pl
+++ openssl-0.9.8g/crypto/rand/md_rand.c
+++ openssl-0.9.8g/crypto/des/asm/desboth.pl
+++ openssl-0.9.8g/crypto/rc4/asm/rc4-x86_64.pl
+++ openssl-0.9.8g/crypto/perlasm/x86unix.pl
+++ openssl-0.9.8g/crypto/perlasm/cbc.pl
+++ openssl-0.9.8g/crypto/perlasm/x86_64-xlate.pl
+++ openssl-0.9.8g/crypto/pkcs7/pk7_mime.c
+++ openssl-0.9.8g/crypto/bn/asm/ppc.pl
+++ openssl-0.9.8g/crypto/aes/asm/aes-586.pl
+++ openssl-0.9.8g/crypto/asn1/charmap.pl
+++ openssl-0.9.8g/util/mkerr.pl
+++ openssl-0.9.8g/util/clean-depend.pl
+++ openssl-0.9.8g/util/extract-names.pl
+++ openssl-0.9.8g/util/pod2man.pl
+++ openssl-0.9.8g/util/mkstack.pl
+++ openssl-0.9.8g/util/selftest.pl
+++ openssl-0.9.8g/util/extract-section.pl
+++ openssl-0.9.8g/util/mkdef.pl
+++ openssl-0.9.8g/util/pl/netware.pl

Gruss
Bernd


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 05-19-2008, 07:20 AM
Andreas Tille
 
Default Should dpkg-source -x list patches ( How to handle Debian patches)

On Mon, 19 May 2008, Bernd Eckenfels wrote:


I dont see a reason why the normal unpack action should spam the user.


If a user feels spammed there might be means to switch this off. A command
line option that reduces the verbosity comes to mind even /dev/null might be
a place to foreward this stuff if you really feel spammed.


If
you care about the changes, just use the command. You can even have an alias
if you prefer that.

BTW:
+++ openssl-0.9.8g/Makefile
+++ openssl-0.9.8g/Configure
+++ ... (50 lines deleted)
+++ openssl-0.9.8g/util/pl/netware.pl


This is *exactly* what I want the user to see. The information that the
source has *a lot* (53) files that are patched by the Debian maintainer
is no spam at all but might make the user aware that there might be reasons
to inspect the diff carefully and that it is not enough to look into
debian/patches (which might not exist in this case, did not checked).

Kind regards

Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 05-19-2008, 02:33 PM
Manoj Srivastava
 
Default Should dpkg-source -x list patches ( How to handle Debian patches)

On Mon, 19 May 2008 09:20:11 +0200 (CEST), Andreas Tille <tillea@rki.de> said:

>> If you care about the changes, just use the command. You can even
>> have an alias if you prefer that.
>>
>> BTW:
>> +++ openssl-0.9.8g/Makefile
>> +++ openssl-0.9.8g/Configure
>> +++ ... (50 lines deleted)
>> +++ openssl-0.9.8g/util/pl/netware.pl

> This is *exactly* what I want the user to see. The information that
> the source has *a lot* (53) files that are patched by the Debian
> maintainer is no spam at all but might make the user aware that there
> might be reasons to inspect the diff carefully and that it is not
> enough to look into debian/patches (which might not exist in this
> case, did not checked).

In that case, I fail to see why you are only interested in this
information if the maintainer did not use quilt. Seems like you should
be concerned about changes made to upstream, period, regardless of
whether the changes are recorded in quilt or not.

Am I missing something?

manoj
--
Peace cannot be kept by force; it can only be achieved by
understanding. Albert Einstein
Manoj Srivastava <srivasta@debian.org> <http://www.debian.org/~srivasta/>
1024D/BF24424C print 4966 F272 D093 B493 410B 924B 21BA DABB BF24 424C


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 05-19-2008, 06:46 PM
Andreas Tille
 
Default Should dpkg-source -x list patches ( How to handle Debian patches)

On Mon, 19 May 2008, Manoj Srivastava wrote:


In that case, I fail to see why you are only interested in this
information if the maintainer did not use quilt. Seems like you should
be concerned about changes made to upstream, period, regardless of
whether the changes are recorded in quilt or not.

Am I missing something?


Yes. You are missing the fact that anybody who inspects a package will
inspect the debian dir anyway. If there is a patches directory it is
obvious that upstream files are patched and there is no need to explicitely
give a hint about this. If patches are "hidden" anywhere in the upstream
code some developers fail to realise this and my suggestion might help
noticing this fact.

Kind regards

Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 05-19-2008, 08:25 PM
Bernd Eckenfels
 
Default Should dpkg-source -x list patches ( How to handle Debian patches)

In article <alpine.DEB.1.10.0805192043220.12434@wr-linux02> you wrote:
> give a hint about this. If patches are "hidden" anywhere in the upstream
> code some developers fail to realise this and my suggestion might help
> noticing this fact.

The debian Diff is not hiding patches in the upstream code. It is the
canonical place to publish them (at least for some (most?) of the debian
packages following policy).

Gruss
Bernd

PS: are we going to somehow react to the massive loss of trust into debian,
for example by publishing a new policy, a qa task force or anything? From
quite some discussions I know it is expected (however I dont claim to have a
practcable answer). I just wonder why we currently discuss Mailing List
netiqette instead of the current issue.


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 05-19-2008, 10:01 PM
Andreas Tille
 
Default Should dpkg-source -x list patches ( How to handle Debian patches)

On Mon, 19 May 2008, Bernd Eckenfels wrote:


The debian Diff is not hiding patches in the upstream code. It is the
canonical place to publish them (at least for some (most?) of the debian
packages following policy).


Well, I'm DD for 10 years - I know this fact. But did you read about
habits of other fellow developers in this thread. Just reread and come back
if you are really sure that an extra hint about patches is really useless.


PS: are we going to somehow react to the massive loss of trust into debian,


No I just try to think about implementing what I regularly do and would
call a reasonable habit that might help others.


I just wonder why we currently discuss Mailing List
netiqette instead of the current issue.


I do so as well, but my 'd'-key works perfectly for this kind of subjects ...

Kind regards

Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 05-20-2008, 06:33 AM
Charles Plessy
 
Default Should dpkg-source -x list patches ( How to handle Debian patches)

Le Mon, May 19, 2008 at 10:25:35PM +0200, Bernd Eckenfels a écrit :
> In article <alpine.DEB.1.10.0805192043220.12434@wr-linux02> you wrote:
> > give a hint about this. If patches are "hidden" anywhere in the upstream
> > code some developers fail to realise this and my suggestion might help
> > noticing this fact.
>
> The debian Diff is not hiding patches in the upstream code. It is the
> canonical place to publish them (at least for some (most?) of the debian
> packages following policy).

Hi all,

If we take openssl as an example, we can see that many .pl files are
modified. A quick inspection shows that for most of them the only change
is the path to Perl in the first line. The only way to know if it is the
case for all is to look at all of them one by one. The Debian diff.gz
file is a technical way to apply the Debian modifications to the
original sources, but it seems to me a very suboptimal way to publish
patches of the quality level that one would expect for his own software.
To keep on the openssl example, the patched .pl are dispersed within the
.diff.gz file. That is, different logical units are mixed, and to submit
one of them would necessitate to generate a new patch that is not a
contiguous extract of the original diff.gz. This is how I understand -
and agree with - the claim that patches are "hidden" in the diff.gz.

Have a nice day

--
Charles Plessy
http://charles.plessy.org
Wakō, Saitama, Japan


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 

Thread Tools




All times are GMT. The time now is 02:37 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org