FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Development

 
 
LinkBack Thread Tools
 
Old 04-16-2008, 12:18 AM
Charles Plessy
 
Default Misc development news (#6) (DEB_BUILD_OPTIONS=noopt)

Le Tue, Apr 15, 2008 at 10:58:29PM +0200, Raphael Hertzog a écrit :
>
> Since dpkg 1.14.17, dpkg-buildpackage will define the environment
> variables CFLAGS, CXXFLAGS, CPPFLAGS, LDFLAGS and FFLAGS. The goal is to
> be able to easily recompile packages with supplementary compilation flags
> and to simplify the debian/rules files since CFLAGS has the right default
> value (no need to special case for DEB_BUILD_OPTIONS=noopt).

Hi Raphaël,

When do you recommend to drop the support for this option? I
personnaly like to keep debian/rules minimal. Do we need to wait for a
Policy update?

Have a nice day,

--
Charles Plessy
http://charles.plessy.org
Wakō, Saitama, Japan


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 04-16-2008, 06:38 AM
Raphael Hertzog
 
Default Misc development news (#6) (DEB_BUILD_OPTIONS=noopt)

On Wed, 16 Apr 2008, Charles Plessy wrote:
> Le Tue, Apr 15, 2008 at 10:58:29PM +0200, Raphael Hertzog a crit :
> >
> > Since dpkg 1.14.17, dpkg-buildpackage will define the environment
> > variables CFLAGS, CXXFLAGS, CPPFLAGS, LDFLAGS and FFLAGS. The goal is to
> > be able to easily recompile packages with supplementary compilation flags
> > and to simplify the debian/rules files since CFLAGS has the right default
> > value (no need to special case for DEB_BUILD_OPTIONS=noopt).
>
> Hi Raphal,
>
> When do you recommend to drop the support for this option? I
> personnaly like to keep debian/rules minimal. Do we need to wait for a
> Policy update?

I would not yet update the rules files. The change is very recent
and it will need some time until the policy is updated. If that feature
makes it into lenny, in lenny+1 it will be ok to clean the rules files
IMO.

Cheers,
--
Raphal Hertzog

Le best-seller franais mis jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 04-16-2008, 01:17 PM
Darren Salt
 
Default Misc development news (#6) (DEB_BUILD_OPTIONS=noopt)

I demand that Raphael Hertzog may or may not have written...

> On Wed, 16 Apr 2008, Charles Plessy wrote:
>> Le Tue, Apr 15, 2008 at 10:58:29PM +0200, Raphael Hertzog a crit :
>>> Since dpkg 1.14.17, dpkg-buildpackage will define the environment
>>> variables CFLAGS, CXXFLAGS, CPPFLAGS, LDFLAGS and FFLAGS. The goal is to
>>> be able to easily recompile packages with supplementary compilation flags
>>> and to simplify the debian/rules files since CFLAGS has the right default
>>> value (no need to special case for DEB_BUILD_OPTIONS=noopt).

>> When do you recommend to drop the support for this option? I personally
>> like to keep debian/rules minimal. Do we need to wait for a Policy
>> update?

> I would not yet update the rules files. [...]

I'd rather that this just got left in debian/rules, where it belongs:
xine-lib, for example, needs more than just -O0 for disabling optimisations.
Then there are the times when I find it useful to run "debian/rules build" or
something similar...

--
| Darren Salt | linux or ds at | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
| + At least 4000 million too many people. POPULATION LEVEL IS UNSUSTAINABLE.

I'd like to, but I'm going down to the bakery to watch the buns rise.
 
Old 04-16-2008, 02:20 PM
Raphael Hertzog
 
Default Misc development news (#6) (DEB_BUILD_OPTIONS=noopt)

On Wed, 16 Apr 2008, Darren Salt wrote:
> I'd rather that this just got left in debian/rules, where it belongs:
> xine-lib, for example, needs more than just -O0 for disabling optimisations.

You can keep it there for special cases like this one.

But I disagree that debian/rules is necessarily the place where it belongs.
It looks like cruft/bad design to have the same snippet of code in all
packages.

Cheers,
--
Raphal Hertzog

Le best-seller franais mis jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 04-16-2008, 03:32 PM
Adeodato Sim
 
Default Misc development news (#6) (DEB_BUILD_OPTIONS=noopt)

* Raphael Hertzog [Wed, 16 Apr 2008 16:20:36 +0200]:

> On Wed, 16 Apr 2008, Darren Salt wrote:
> > I'd rather that this just got left in debian/rules, where it belongs:
> > xine-lib, for example, needs more than just -O0 for disabling optimisations.

> You can keep it there for special cases like this one.

> But I disagree that debian/rules is necessarily the place where it belongs.
> It looks like cruft/bad design to have the same snippet of code in all
> packages.

On the other hand, the bit about running `debian/rules build` by hand
seems valid to me.

Cheers,

--
Adeodato Sim dato at net.com.org.es
Debian Developer adeodato at debian.org

He who has not a good memory should never take upon himself the trade of lying.
-- Michel de Montaigne


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 04-16-2008, 04:29 PM
Loc Minier
 
Default Misc development news (#6) (DEB_BUILD_OPTIONS=noopt)

On Wed, Apr 16, 2008, Raphael Hertzog wrote:
> But I disagree that debian/rules is necessarily the place where it belongs.
> It looks like cruft/bad design to have the same snippet of code in all
> packages.

Perhaps this should be fixed in another way then? For example a shared
Makefile included by all debian/rules (if they are a makefile -- ala
cdbs, but with a simple documented interface such as documenting that
this will set *FLAGS based on deb_build_opts. e.g.
/usr/share/dpkg/flags.mk with:
CFLAGS += -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)

--
Loc Minier


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 04-16-2008, 05:38 PM
Darren Salt
 
Default Misc development news (#6) (DEB_BUILD_OPTIONS=noopt)

I demand that Loc Minier may or may not have written...

> On Wed, Apr 16, 2008, Raphael Hertzog wrote:
>> But I disagree that debian/rules is necessarily the place where it
>> belongs. It looks like cruft/bad design to have the same snippet of code
>> in all packages.

> Perhaps this should be fixed in another way then? For example a shared
> Makefile included by all debian/rules (if they are a makefile -- ala
> cdbs, but with a simple documented interface such as documenting that
> this will set *FLAGS based on deb_build_opts. e.g.
> /usr/share/dpkg/flags.mk with:
> CFLAGS += -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)

That looks reasonable to me.

However, care should be taken to avoid ending up with cdbs-buildpackage ;-)

--
| Darren Salt | linux or ds at | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
| Kill all extremists!

I couldn't possibly fail to disagree with you less.
 
Old 04-16-2008, 07:28 PM
Matthew Woodcraft
 
Default Misc development news (#6) (DEB_BUILD_OPTIONS=noopt)

Adeodato wrote:
> On the other hand, the bit about running `debian/rules build` by hand
> seems valid to me.

Indeed, that's what my fingers are used to typing if I just want a
patched package for local use. I wouldn't be surprised if there were
lots of other users who are the same.

The various wrappers want to do extra stuff which doesn't seem relevant
for a package you aren't going to publish.

-M-


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 04-16-2008, 09:32 PM
Manoj Srivastava
 
Default Misc development news (#6) (DEB_BUILD_OPTIONS=noopt)

On Wed, 16 Apr 2008 18:38:39 +0100, Darren Salt <linux@youmustbejoking.demon.co.uk> said:

> I demand that Loc Minier may or may not have written...
>> On Wed, Apr 16, 2008, Raphael Hertzog wrote:
>>> But I disagree that debian/rules is necessarily the place where it
>>> belongs. It looks like cruft/bad design to have the same snippet of
>>> code in all packages.

>> Perhaps this should be fixed in another way then? For example a
>> shared Makefile included by all debian/rules (if they are a makefile
>> -- ala cdbs, but with a simple documented interface such as
>> documenting that this will set *FLAGS based on deb_build_opts. e.g.
>> /usr/share/dpkg/flags.mk with:
>> CFLAGS += -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)

> That looks reasonable to me.

Hmm. Smells a lot like:
--8<---------------cut here---------------start------------->8---
ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
CFLAGS += -O0
else
CFLAGS += -O2
endif
--8<---------------cut here---------------end--------------->8---

See 10.1. Binaries.

> However, care should be taken to avoid ending up with
> cdbs-buildpackage ;-)

manoj
--
"I'd love to go out with you, but I want to spend more time with my
blender."
Manoj Srivastava <srivasta@debian.org> <http://www.debian.org/~srivasta/>
1024D/BF24424C print 4966 F272 D093 B493 410B 924B 21BA DABB BF24 424C


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 04-17-2008, 02:39 PM
Loc Minier
 
Default Misc development news (#6) (DEB_BUILD_OPTIONS=noopt)

On Wed, Apr 16, 2008, Manoj Srivastava wrote:
> Hmm. Smells a lot like:

Yes, it's the same, except eating less screen space; I don't
particularly care how it ends up being implemented

--
Loc Minier


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 

Thread Tools




All times are GMT. The time now is 05:14 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org