FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Development

 
 
LinkBack Thread Tools
 
Old 09-16-2012, 01:57 PM
Bart Martens
 
Default mass bug filing about packages with empty /usr/share/doc/$package/ (no copyright file)?

On Sun, Sep 16, 2012 at 03:12:09PM +0200, Andreas Beckmann wrote:
> Hi,
>
> someone asked me to add a piuparts check for packages that don't have a
> copyright file /usr/share/doc/$package/copyright. I added something
> (it's now in the git repository and running on piuparts.d.o) and filed a
> few bugs already, but now it seems the problem is more widespread. The
> problem usually occurs after an upgrade (e.g. squeeze->wheezy) where the
> package does change something w.r.t directories and symlinks in
> /usr/share/doc.
> As dpkg intentionally does not replace a directory with a symlink (or
> vice versa), these package usually end up with an empty /u/s/d/$package/
> directory instead of a symlink like
> /u/s/d/$package -> $package-common , so maintainer scripts are needed to
> do the conversion.
>
> The list of buggy packages can be found here:
> http://piuparts.debian.org/squeeze2wheezy/unknown_failures.html
> (There are some logs with different "unclassified" problems, but most of
> them have this problem.)

Since this is related to upgrading, I guess that this cannot be checked by
lintian. If you're looking for a consensus on debian-devel on whether mass bug
filing is appropriate in this case, then I can say that I agree.

>
> I'm afraid I don't have the time right now to thoroughly analyze these
> logs and report all the bugs, so some help would be welcome.

I'm offering help, but only for part of the work : I could write a perl script
that periodically scans the logfiles and submits additional bugs.

> Right now there are about 30 packages being buggy, but more will
> probably show up as squeeze2wheezy gets retested with the new check.
>
> Also we should formulate some advice how to fix this issue, probably
> including some maintainer script snippets. There are several DDs that
> have already fixed these bugs (thanks!), so they should know how to do
> this :-)

Maybe this advice can be put on a wiki page and the mass bug filing can point
to that wiki page, so that additional aspects to give advice on can be added on
that wiki page. (But I'm currently not voluteering to write the advice.)

>
> As missing a copyright file is a violation of policy 12.5, these would
> be RC bugs affecting wheezy.
>
> The error output at the end of the logfile looks like this:
>
> MISSING COPYRIGHT FILE: /usr/share/doc/bitlbee/copyright
> drwxr-xr-x 2 root root 4096 Sep 15 12:45 /usr/share/doc/bitlbee
> total 8
> drwxr-xr-x 2 root root 4096 Sep 15 12:45 .
> drwxr-xr-x 92 root root 4096 Sep 15 12:45 ..
>
> and was generated with
>
> echo MISSING COPYRIGHT FILE: $PKGDOCDIR/copyright
> ls -lad $PKGDOCDIR
> ls -la $PKGDOCDIR/
>
>
> A bug template should probably start with:
>
> <------------- snip ------------------>
> To: submit@bugs.debian.org
> Subject: $PACKAGE: copyright file missing after upgrade (policy 12.5)
>
> Package: $PACKAGE
> Version: $VERSION
> Severity: serious
> User: debian-qa@lists.debian.org
> Usertags: piuparts
> Control: found -1 $PACKAGE/$VERSION
>
> Hi,
>
> during a test with piuparts I noticed your package misses the copyright
> file after an upgrade from squeeze to wheezy, which is a violation of
> Policy 12.5:
> http://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile
>
> After the upgrade /usr/share/doc/$PACKAGE/ is just an empty directory.
>
> ...
>
>
> Cheers,
> <------------- snap ------------------>

Looks like a good start for the bug reports.

Regards,

Bart Martens


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20120916135704.GB22661@master.debian.org">http://lists.debian.org/20120916135704.GB22661@master.debian.org
 
Old 09-16-2012, 04:36 PM
Bart Martens
 
Default mass bug filing about packages with empty /usr/share/doc/$package/ (no copyright file)?

On Sun, Sep 16, 2012 at 01:57:04PM +0000, Bart Martens wrote:
> On Sun, Sep 16, 2012 at 03:12:09PM +0200, Andreas Beckmann wrote:
> > I'm afraid I don't have the time right now to thoroughly analyze these
> > logs and report all the bugs, so some help would be welcome.
>
> I'm offering help, but only for part of the work : I could write a perl script
> that periodically scans the logfiles and submits additional bugs.

I have written that script, and I think it's ready for use.

> > Also we should formulate some advice how to fix this issue, probably
> > including some maintainer script snippets. There are several DDs that
> > have already fixed these bugs (thanks!), so they should know how to do
> > this :-)
>
> Maybe this advice can be put on a wiki page and the mass bug filing can point
> to that wiki page, so that additional aspects to give advice on can be added on
> that wiki page. (But I'm currently not voluteering to write the advice.)

I have opened this wiki page :
http://wiki.debian.org/MissingCopyrightFile

Anyone feel free to write advice on that wiki page.

Regards,

Bart Martens


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20120916163621.GA13914@master.debian.org">http://lists.debian.org/20120916163621.GA13914@master.debian.org
 
Old 09-16-2012, 05:29 PM
Julien Cristau
 
Default mass bug filing about packages with empty /usr/share/doc/$package/ (no copyright file)?

On Sun, Sep 16, 2012 at 15:12:09 +0200, Andreas Beckmann wrote:

> Also we should formulate some advice how to fix this issue, probably
> including some maintainer script snippets. There are several DDs that
> have already fixed these bugs (thanks!), so they should know how to do
> this :-)
>
I think the advice should be to reconsider whether symlinking the doc
directories is really a good idea.

Cheers,
Julien
 
Old 09-16-2012, 06:21 PM
 
Default mass bug filing about packages with empty /usr/share/doc/$package/ (no copyright file)?

On Sep 16, Julien Cristau <jcristau@debian.org> wrote:

> I think the advice should be to reconsider whether symlinking the doc
> directories is really a good idea.
I think it really is, since it saves space with minimal effort.
It only becomes an issue when you switch a package to a symlinked
directory and get wrong the code in the maintainer scripts.

--
ciao,
Marco
 
Old 09-21-2012, 12:35 PM
Andreas Beckmann
 
Default mass bug filing about packages with empty /usr/share/doc/$package/ (no copyright file)?

On 2012-09-16 18:36, Bart Martens wrote:
>> I'm offering help, but only for part of the work : I could write a perl script
>> that periodically scans the logfiles and submits additional bugs.
>
> I have written that script, and I think it's ready for use.

Thanks a lot for filing these bugs! Would you mind sharing the script?
Perhaps we could reuse it for future piuparts MBFs.

Andreas


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 505C5F1C.8070701@abeckmann.de">http://lists.debian.org/505C5F1C.8070701@abeckmann.de
 
Old 09-21-2012, 10:13 PM
Bart Martens
 
Default mass bug filing about packages with empty /usr/share/doc/$package/ (no copyright file)?

On Fri, Sep 21, 2012 at 02:35:40PM +0200, Andreas Beckmann wrote:
> On 2012-09-16 18:36, Bart Martens wrote:
> >> I'm offering help, but only for part of the work : I could write a perl script
> >> that periodically scans the logfiles and submits additional bugs.
> >
> > I have written that script, and I think it's ready for use.
>
> Thanks a lot for filing these bugs!

My pleasure.

> Would you mind sharing the script?

Yes of course. It's on quantz in /home/bartm/src/misscopyfile and it's GPL.

> Perhaps we could reuse it for future piuparts MBFs.

Sure why not.

Regards,

Bart Martens


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20120921221300.GA9889@master.debian.org">http://lists.debian.org/20120921221300.GA9889@master.debian.org
 

Thread Tools




All times are GMT. The time now is 10:40 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org