FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Development

 
 
LinkBack Thread Tools
 
Old 01-11-2011, 12:17 PM
Martin Gracik
 
Default Use the same error message in text mode and GUI (#625809)

On Tue, 2011-01-11 at 13:42 +0100, Radek Vykydal wrote:
> It is a weak password message.
> ---
> textw/userauth_text.py | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/textw/userauth_text.py b/textw/userauth_text.py
> index 8798348..ab7abd0 100644
> --- a/textw/userauth_text.py
> +++ b/textw/userauth_text.py
> @@ -81,10 +81,10 @@ class RootPasswordWindow:
> except ValueError, e:
> msg = gettext.ldgettext("cracklib", e)
> ret = anaconda.intf.messageWindow(_("Weak Password"),
> - _("You have provided a weak password: %s

"
> - "Would you like to continue with this password?"
> - % (msg, )),
> - type = "yesno", default="no")
> + _("You have provided a weak password: %s") % msg,
> + type="custom", custom_icon="error",
> + default=0,
> + custom_buttons=[_("Cancel"), _("_Use Anyway")])
> if ret == 1:
> break
> else:

ack,

but what about the Cancel mnemonic, don't we want that too ?

--
Martin Gracik <mgracik@redhat.com>

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-12-2011, 07:10 AM
Martin Gracik
 
Default Use the same error message in text mode and GUI (#625809)

Yeah, I've looked ad the gui.py, the mnemonic isn't there either, so the
real question is, don't we want to add the mnemonic for Cancel to both
dialogs?


On Tue, 2011-01-11 at 10:10 -0500, Chris Lumens wrote:
> > but what about the Cancel mnemonic, don't we want that too ?
>
> These are both translated elsewhere as well:
>
> iw/account_gui.py: custom_buttons=[_("Cancel"), _("_Use Anyway")])
>
> So it should be fine.
>
> - Chris
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

--
Martin Gracik <mgracik@redhat.com>

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-12-2011, 01:23 PM
Martin Gracik
 
Default Use the same error message in text mode and GUI (#625809)

That's exactly what I was asking

On Wed, 2011-01-12 at 09:09 -0500, Chris Lumens wrote:
> > Yeah, I've looked ad the gui.py, the mnemonic isn't there either, so the
> > real question is, don't we want to add the mnemonic for Cancel to both
> > dialogs?
>
> In fact, a quick search of the source reveals a ton of places where we
> use "Cancel" instead of "_Cancel". At the least we need to fix this on
> master. Doing so for RHEL6 might be overreaching, at least without a
> bug report.
>
> - Chris
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

--
Martin Gracik <mgracik@redhat.com>

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 07:07 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org