FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Development

 
 
LinkBack Thread Tools
 
Old 05-10-2010, 05:26 PM
Jesse Keating
 
Default bootloader timeout default should be None not 0

We compare to None later in booty/x86.py and if it is 0 things like the
chainloader timeout don't get set right. Resolves 590661
---
installclass.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/installclass.py b/installclass.py
index d87b5bb..2e8fcf6 100644
--- a/installclass.py
+++ b/installclass.py
@@ -53,7 +53,7 @@ class BaseInstallClass(object):
pkgstext = ""
# default to showing the upgrade option
showUpgrade = True
- bootloaderTimeoutDefault = 0
+ bootloaderTimeoutDefault = None
bootloaderExtraArgs = ""

# list of of (txt, grplist) tuples for task selection screen
--
1.7.0.1

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-10-2010, 05:37 PM
Hans de Goede
 
Default bootloader timeout default should be None not 0

Ack.

On 05/10/2010 07:26 PM, Jesse Keating wrote:

We compare to None later in booty/x86.py and if it is 0 things like the
chainloader timeout don't get set right. Resolves 590661
---
installclass.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/installclass.py b/installclass.py
index d87b5bb..2e8fcf6 100644
--- a/installclass.py
+++ b/installclass.py
@@ -53,7 +53,7 @@ class BaseInstallClass(object):
pkgstext = ""
# default to showing the upgrade option
showUpgrade = True
- bootloaderTimeoutDefault = 0
+ bootloaderTimeoutDefault = None
bootloaderExtraArgs = ""

# list of of (txt, grplist) tuples for task selection screen


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-10-2010, 05:53 PM
Peter Jones
 
Default bootloader timeout default should be None not 0

On 05/10/2010 01:26 PM, Jesse Keating wrote:
> We compare to None later in booty/x86.py and if it is 0 things like the
> chainloader timeout don't get set right. Resolves 590661
> ---
> installclass.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/installclass.py b/installclass.py
> index d87b5bb..2e8fcf6 100644
> --- a/installclass.py
> +++ b/installclass.py
> @@ -53,7 +53,7 @@ class BaseInstallClass(object):
> pkgstext = ""
> # default to showing the upgrade option
> showUpgrade = True
> - bootloaderTimeoutDefault = 0
> + bootloaderTimeoutDefault = None
> bootloaderExtraArgs = ""
>
> # list of of (txt, grplist) tuples for task selection screen

Definitely ACK for rawhide. I don't really think this should is
a reason to slip F13, though.

--
Peter

When in doubt, debug-on-entry the function you least suspect has
anything to do with something.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 11:46 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org