FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Development

 
 
LinkBack Thread Tools
 
Old 03-31-2010, 02:46 PM
Mehdi Dogguy
 
Default Bug#575938: ITP: dh-autoreconf -- debhelper add-on to call autoreconf and clean up after the build

Julian Andres Klode wrote:
> A 'debuild; debuild' should have a different result than a single
> debuild then. If you build from a clean directory, the first build
> will contain no changes. But after the build, the directory is not
> clean anymore and debian/rules clean does not do enough to keep the
> changes from appearing in the source package if you build again.
>

I should have done that earlier (but didn't see the git repo, only now). I
had a look at dh-autoreconf's code and the difference between what I do
and what your script does is that I manually specify a list of files to
"monitor" while you monitor all files.

IMO, dh-autoreconf may be not specific to autoreconf but all same kind of
tools and thus, can be enhanced by making, for example, the command to
execute an argument which could be the command "true" (and keep
"autoreconf" as a default) because, sometimes, it may be needed to make
"debian/autoreconf.after" a bit later than just after executing
"autoreconf". Hopefully, we can do that by overriding the file.

If you have these options, dh-autoreconf becomes nothing more than a call
to autoreconf if we have dh_backup (name proposed by buxy in the same
thread). dh_backup can be integrated to debhelper and all that remains to
be done is a call to "autoreconf" (depending on the implementation of
dh_backup).

--
Mehdi Dogguy مهدي الدڤي
http://dogguy.org/


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4BB36028.7020800@dogguy.org">http://lists.debian.org/4BB36028.7020800@dogguy.org
 
Old 03-31-2010, 03:45 PM
Julian Andres Klode
 
Default Bug#575938: ITP: dh-autoreconf -- debhelper add-on to call autoreconf and clean up after the build

On Wed, Mar 31, 2010 at 04:46:00PM +0200, Mehdi Dogguy wrote:
> Julian Andres Klode wrote:
> > A 'debuild; debuild' should have a different result than a single
> > debuild then. If you build from a clean directory, the first build
> > will contain no changes. But after the build, the directory is not
> > clean anymore and debian/rules clean does not do enough to keep the
> > changes from appearing in the source package if you build again.
> >
>
> I should have done that earlier (but didn't see the git repo, only now). I
> had a look at dh-autoreconf's code and the difference between what I do
> and what your script does is that I manually specify a list of files to
> "monitor" while you monitor all files.
>
> IMO, dh-autoreconf may be not specific to autoreconf but all same kind of
> tools and thus, can be enhanced by making, for example, the command to
> execute an argument which could be the command "true" (and keep
> "autoreconf" as a default) because, sometimes, it may be needed to make
> "debian/autoreconf.after" a bit later than just after executing
> "autoreconf". Hopefully, we can do that by overriding the file.

The idea is that I want to keep debian/autoreconf.{before,after}
only related to the autoreconf run.


> If you have these options, dh-autoreconf becomes nothing more than a call
> to autoreconf if we have dh_backup (name proposed by buxy in the same
> thread). dh_backup can be integrated to debhelper and all that remains to
> be done is a call to "autoreconf" (depending on the implementation of
> dh_backup).
A backup and restore approach is a completely different and more
complicated (in I/O sense) way than just deleting the files; e.g.
for a single file:

dh_backup:
1. mkdir() - Create the backup directory
2. read() - Read the original source
3. write() - Write the backup file
4. rename() - Rename backup to source

dh_autoreconf:
1. read() - Create md5sum before (unneeded if --mode=timesize)
2. read() - Create md5sum after (unneded if --mode=timesize)
3. unlink() - Unlink the changed file

Furthermore, the second read() in dh_autoreconf could also be in
the cache already.

--
Julian Andres Klode - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
 
Old 03-31-2010, 04:24 PM
Mehdi Dogguy
 
Default Bug#575938: ITP: dh-autoreconf -- debhelper add-on to call autoreconf and clean up after the build

Julian Andres Klode wrote:
> A backup and restore approach is a completely different and more
> complicated (in I/O sense) way than just deleting the files; e.g.
> for a single file:
>

… except that they do not operate on the same set of files. dh_backup's
list would be a lot smaller than dh_autoreconf's one. Besides, dh_backup
(or whatever its name is) could also delete files upon request ("dh_backup
--remove" would then be dh_autoreconf minus "autoreconf").

> dh_backup:
> 1. mkdir() - Create the backup directory

you can use then "debian/" directory here (provided you add a suffix to
backup's name). And, dh_autoreconf also creates a directory for excluded
files (if any). So, I don't think that this part is really relevant for
the comparison.

I think that all arguments in favour or against have been mentioned. I
don't have anything to add. If it really makes you happy to have this
package, then so be it

Cheers,

--
Mehdi Dogguy مهدي الدڤي
http://dogguy.org/


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4BB37759.3070101@dogguy.org">http://lists.debian.org/4BB37759.3070101@dogguy.org
 
Old 04-01-2010, 09:06 AM
Fabian Greffrath
 
Default Bug#575938: ITP: dh-autoreconf -- debhelper add-on to call autoreconf and clean up after the build

It seems that we could also read the requested versions of automake and
autoconf from debian/control and export them automatically using:

[...]

Does this sound like a good idea?


IMHO this sounds like a very good idea.

Consequently, dh_autoreconf should become a no-op if autoconf is
missing from the build-depends (how about automake and autopoint?).
Similarly, the LIBTOOLIZE variable should be set to "true" is libtool
is missing from the build-depends. In any case, dh-autoreconf should
be *verbose* about what it does or does not (and maybe even call
autoreconf with the '-v' parameter to achieve more meaningful logs).


- Fabian


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4BB461FB.4020107@leat.rub.de">http://lists.debian.org/4BB461FB.4020107@leat.rub.de
 

Thread Tools




All times are GMT. The time now is 10:29 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org