FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Development

 
 
LinkBack Thread Tools
 
Old 03-30-2010, 02:58 PM
David Lehman
 
Default Do not try to commit diskLabels on non partitionable devices (#576145)

Ack, given that parted.Device.clobber actually writes to the device. Are
you planning to clone for F13? It's probably not needed since the patch
to ignore most of the spurious disklabel detection is already there --
I'm hoping to get the same patch onto rhel6-branch in the next day or
two.

Dave

On Mon, 2010-03-29 at 13:55 +0200, Hans de Goede wrote:
> There is no reason to call partedDisk.commit() when destroying
> disklabels. partedDevice.clobber() is sufficient. More over calling
> partedDisk.commit() causes issues, as we now recognize disk labels
> on non partitionable devices and calling partedDisk.commit() on a non
> partitionable device will always fails, as the device node will reject
> the partition table reload ioctl.
> ---
> storage/formats/disklabel.py | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/storage/formats/disklabel.py b/storage/formats/disklabel.py
> index 3e78f27..d4a706d 100644
> --- a/storage/formats/disklabel.py
> +++ b/storage/formats/disklabel.py
> @@ -232,11 +232,7 @@ class DiskLabel(DeviceFormat):
> if not os.access(self.device, os.W_OK):
> raise DeviceFormatError("device path does not exist")
>
> - self._partedDisk = parted.freshDisk(device=self.partedDevice,
> - ty=self.partedDisk.type)
> - self.commit()
> self.partedDevice.clobber()
> - self.commit()
> self.exists = False
>
> def commit(self):


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-31-2010, 08:24 AM
Hans de Goede
 
Default Do not try to commit diskLabels on non partitionable devices (#576145)

Hi,

On 03/30/2010 04:58 PM, David Lehman wrote:

Ack, given that parted.Device.clobber actually writes to the device.


It does.


Are
you planning to clone for F13?


I wasn't planning on this, but feel free to cherry pick this if you
think it is useful to have for F-13.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 12:52 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org