Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Debian Development (http://www.linux-archive.org/debian-development/)
-   -   Fix visibility counting on filter notebook pages. (http://www.linux-archive.org/debian-development/314917-fix-visibility-counting-filter-notebook-pages.html)

Chris Lumens 01-25-2010 08:17 PM

Fix visibility counting on filter notebook pages.
 
Since all notebook pages share the same store, a device being visible on one
page means it'll be counted as being visible on all pages. That means
flipping to the correct initial page doesn't work. Instead, we need to count
using the visible methods on callback objects to only count the devices that
are members of each page as visible.
---
iw/filter_gui.py | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/iw/filter_gui.py b/iw/filter_gui.py
index 4247503..efdb5a4 100644
--- a/iw/filter_gui.py
+++ b/iw/filter_gui.py
@@ -357,7 +357,16 @@ class NotebookPage(object):
self.filteredModel.refilter()

def getNVisible(self):
- return self.ds.getNVisible()
+ retval = 0
+ iter = self.filteredModel.get_iter_first()
+
+ while iter:
+ if self.cb.visible(self.filteredModel, iter, self.treeView):
+ retval += 1
+
+ iter = self.filteredModel.iter_next(iter)
+
+ return retval

class FilterWindow(InstallWindow):
windowTitle = N_("Device Filter")
--
1.6.5.1

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Ales Kozumplik 01-26-2010 07:38 AM

Fix visibility counting on filter notebook pages.
 
@@ -357,7 +357,16 @@ class NotebookPage(object):
self.filteredModel.refilter()

def getNVisible(self):
- return self.ds.getNVisible()
+ retval = 0
+ iter = self.filteredModel.get_iter_first()
+
+ while iter:
+ if self.cb.visible(self.filteredModel, iter, self.treeView):
+ retval += 1
+
+ iter = self.filteredModel.iter_next(iter)
+
+ return retval

class FilterWindow(InstallWindow):
windowTitle = N_("Device Filter")


I can't really see the details, but it looks good to me.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


All times are GMT. The time now is 07:34 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.