FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Development

 
 
LinkBack Thread Tools
 
Old 07-19-2008, 01:21 PM
"Sergei Golovan"
 
Default Clarification about bug #463538 is needed

Hi!

Currently APT fails to start all services which are based on Erlang
(see bug #463538, [1]). It starts the service successfully but after
apt-get finishes the service process get killed.

I've found a one-line-patch which fixes this bug (see [2]) but I'm not
sure if it's correct and doesn't break something else.

Could someone review the patch and either apply it to the next APT
version or may be help to fix this in some other way? (It might be an
Erlang fault but I can't find anything wrong in how it detaches from a
controlling terminal.)

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=463538
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=20;filename=tty.diff;att=1;bug=4 63538

Cheers!
--
Sergei Golovan


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 07-19-2008, 05:06 PM
"Martijn van Oosterhout"
 
Default Clarification about bug #463538 is needed

On Sat, Jul 19, 2008 at 3:21 PM, Sergei Golovan <sgolovan@nes.ru> wrote:
> Hi!
>
> Currently APT fails to start all services which are based on Erlang
> (see bug #463538, [1]). It starts the service successfully but after
> apt-get finishes the service process get killed.
>
> I've found a one-line-patch which fixes this bug (see [2]) but I'm not
> sure if it's correct and doesn't break something else.

Umm, if that patch fixes it (removing the TIOCSCTTY) then it seems to
me that the erlang-based service will instead exit when the user who
installed the server logs out. Evidently the services in erlang are
not properly disassociating themselves from the terminal and this
patch just makes it more obvious...

Have a nice day,

>
> Could someone review the patch and either apply it to the next APT
> version or may be help to fix this in some other way? (It might be an
> Erlang fault but I can't find anything wrong in how it detaches from a
> controlling terminal.)
>
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=463538
> [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=20;filename=tty.diff;att=1;bug=4 63538
>
> Cheers!
> --
> Sergei Golovan
>
>
> --
> To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
>
>



--
Martijn van Oosterhout <kleptog@gmail.com> http://svana.org/kleptog/


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 
Old 07-19-2008, 05:28 PM
"Sergei Golovan"
 
Default Clarification about bug #463538 is needed

On 7/19/08, Martijn van Oosterhout <kleptog@gmail.com> wrote:
>
> Umm, if that patch fixes it (removing the TIOCSCTTY) then it seems to
> me that the erlang-based service will instead exit when the user who
> installed the server logs out. Evidently the services in erlang are
> not properly disassociating themselves from the terminal and this
> patch just makes it more obvious...

Erlang does exactly the following when detaches from a terminal:

if (start_detached) {
int status = fork();
if (status != 0)
return 0;
status = fork();
if (status != 0)
return 0;

close(0);
open("/dev/null", O_RDONLY);
close(1);
open("/dev/null", O_WRONLY);
close(2);
open("/dev/null", O_WRONLY);
}
{
execv(emu, Eargsp); /* executing the main Erlang emulator */
}

Is this behavior incorrect?

--
Sergei Golovan


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
 

Thread Tools




All times are GMT. The time now is 03:18 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org