FAQ Search Today's Posts Mark Forums Read

» Linux Archive
Home
New Posts
Search
FAQ


Go Back   Linux Archive > Redhat > Crash Utility

 
 
LinkBack Thread Tools
 
Old 05-21-2008, 06:46 AM
Akio Takebe
 
Default Fix backtrace of xen-ia64

Hi,

This patch improves backtrace of xen-ia64.
If the cpu map is not contiguous, we cannot get the stack address.

Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>

Best Regards,

Akio Takebe
---

--- crash-4.0-6.3.orig/ia64.c 2008-04-30 02:39:16.000000000 +0900
+++ crash-4.0-6.3/ia64.c 2008-05-21 15:05:53.000000000 +0900
@@ -4167,14 +4167,14 @@ ia64_in_mca_stack_hyper(ulong addr, stru
if (!machdep->kvtop(NULL, addr, &paddr, 0))
return 0;

- __per_cpu_mca = (ulong *)GETBUF(sizeof(ulong) * xht->pcpus);
+ __per_cpu_mca = (ulong *)GETBUF(sizeof(ulong) * plen);

if (!readmem(symbol_value("__per_cpu_mca"), KVADDR, __per_cpu_mca,
- sizeof(ulong) * xht->pcpus, "__per_cpu_mca", RETURN_ON_ERROR|QUIET))
+ sizeof(ulong) * plen, "__per_cpu_mca", RETURN_ON_ERROR|QUIET))
return 0;

if (CRASHDEBUG(1)) {
- for (i = 0; i < xht->pcpus; i++) {
+ for (i = 0; i < plen; i++) {
fprintf(fp, "__per_cpu_mca[%d]: %lx
",
i, __per_cpu_mca[i]);
}

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 05-21-2008, 12:48 PM
Dave Anderson
 
Default Fix backtrace of xen-ia64

Akio Takebe wrote:

Hi,

This patch improves backtrace of xen-ia64.
If the cpu map is not contiguous, we cannot get the stack address.

Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>

Best Regards,

Akio Takebe
---

--- crash-4.0-6.3.orig/ia64.c 2008-04-30 02:39:16.000000000 +0900
+++ crash-4.0-6.3/ia64.c 2008-05-21 15:05:53.000000000 +0900
@@ -4167,14 +4167,14 @@ ia64_in_mca_stack_hyper(ulong addr, stru
if (!machdep->kvtop(NULL, addr, &paddr, 0))
return 0;

- __per_cpu_mca = (ulong *)GETBUF(sizeof(ulong) * xht->pcpus);

+ __per_cpu_mca = (ulong *)GETBUF(sizeof(ulong) * plen);

if (!readmem(symbol_value("__per_cpu_mca"), KVADDR, __per_cpu_mca,

- sizeof(ulong) * xht->pcpus, "__per_cpu_mca", RETURN_ON_ERROR|QUIET))
+ sizeof(ulong) * plen, "__per_cpu_mca", RETURN_ON_ERROR|QUIET))
return 0;

if (CRASHDEBUG(1)) {

- for (i = 0; i < xht->pcpus; i++) {
+ for (i = 0; i < plen; i++) {
fprintf(fp, "__per_cpu_mca[%d]: %lx
",
i, __per_cpu_mca[i]);

}



ACK -- queued for the next release.

Thanks,
Dave

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 

Thread Tools




All times are GMT. The time now is 08:22 PM.

VBulletin, Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org