FAQ Search Today's Posts Mark Forums Read

» Linux Archive
Home
New Posts
Search
FAQ


Go Back   Linux Archive > Redhat > Crash Utility

 
 
LinkBack Thread Tools
 
Old 04-11-2008, 04:10 PM
Michael Holzheu
 
Default Add large page support for s390x

Hi Dave,

Please include this patch in the next crash release:

The new z10 System z (s390x) machines have now support for large pages (1MB). This patch
updates the s390x page table walk function in order to handle this.

Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
---

s390x.c | 5 +++++
1 files changed, 5 insertions(+)

diff -Naurp crash-4.0-6.2/s390x.c crash-4.0-6.2-s390x-large-page/s390x.c
--- crash-4.0-6.2/s390x.c 2008-04-11 14:42:35.000000000 +0200
+++ crash-4.0-6.2-s390x-large-page/s390x.c 2008-04-11 14:42:41.000000000 +0200
@@ -337,6 +337,11 @@ int s390x_vtop(ulong table, ulong vaddr,
level--;
}

+ /* Check if this is a large page. */
+ if (entry & 0x400ULL)
+ /* Add the 1MB page offset and return the final value. */
+ return table + (vaddr & 0xfffffULL);
+
/* Get the page table entry */
entry = _kl_pg_table_deref_s390x(vaddr, entry & ~0x7ffULL);
if (!entry)


--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 04-11-2008, 04:24 PM
Dave Anderson
 
Default Add large page support for s390x

Michael Holzheu wrote:

Hi Dave,

Please include this patch in the next crash release:

The new z10 System z (s390x) machines have now support for large pages (1MB). This patch
updates the s390x page table walk function in order to handle this.

Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
---

s390x.c | 5 +++++
1 files changed, 5 insertions(+)

diff -Naurp crash-4.0-6.2/s390x.c crash-4.0-6.2-s390x-large-page/s390x.c
--- crash-4.0-6.2/s390x.c 2008-04-11 14:42:35.000000000 +0200
+++ crash-4.0-6.2-s390x-large-page/s390x.c 2008-04-11 14:42:41.000000000 +0200
@@ -337,6 +337,11 @@ int s390x_vtop(ulong table, ulong vaddr,
level--;
}

+ /* Check if this is a large page. */

+ if (entry & 0x400ULL)
+ /* Add the 1MB page offset and return the final value. */
+ return table + (vaddr & 0xfffffULL);
+
/* Get the page table entry */
entry = _kl_pg_table_deref_s390x(vaddr, entry & ~0x7ffULL);
if (!entry)




OK -- queued for the next release.

Thanks,
Dave



--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 

Thread Tools




All times are GMT. The time now is 01:53 AM.

VBulletin, Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org