Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Crash Utility (http://www.linux-archive.org/crash-utility/)
-   -   add -t option for runq command (http://www.linux-archive.org/crash-utility/670008-add-t-option-runq-command.html)

"WeiJiangang" 05-23-2012 10:14 AM

add -t option for runq command
 
Hi Dave,

I agree with your opinion,the first suggestion (1) seems better.I have already accepted
your specification and modified the patch. Specific modification as follows:

(1) The option “-t” is accepted, while the option "-c" was abandoned.
(2) Turn key word '*_clock' into '*_timestamp'.
(3) Add information about active task on each cpu,like this:
CPU 0: 67393251944103
[67393251944103] PID: 14776 TASK: ea54aab0 COMMAND: "crash"
CPU 1: 66789719628339
[67393251858710] PID: 14769 TASK: f4bdc030 COMMAND: "crash"

Do you have any other suggestion or requirement?
--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility

"WeiJiangang" 05-23-2012 10:21 AM

add -t option for runq command
 
Hi Dave,

I agree with your opinion,the first suggestion (1) seems better.I have already accepted
your specification and modified the patch. Specific modification as follows:

(1) The option “-t” is accepted, while the option "-c" was abandoned.
(2) Turn key word '*_clock' into '*_timestamp'.
(3) Add information about active task on each cpu,like this:
CPU 0: 67393251944103
[67393251944103] PID: 14776 TASK: ea54aab0 COMMAND: "crash"
CPU 1: 66789719628339
[67393251858710] PID: 14769 TASK: f4bdc030 COMMAND: "crash"

Do you have any other suggestion or requirement?

Regards,
Wei Jiangang
--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility

Dave Anderson 05-23-2012 07:56 PM

add -t option for runq command
 
----- Original Message -----
> Hi Dave,
>
> I agree with your opinion,the first suggestion (1) seems better.I
> have already accepted
> your specification and modified the patch. Specific modification as
> follows:
>
> (1) The option “-t” is accepted, while the option "-c" was
> abandoned.
> (2) Turn key word '*_clock' into '*_timestamp'.
> (3) Add information about active task on each cpu,like this:
> CPU 0: 67393251944103
> [67393251944103] PID: 14776 TASK: ea54aab0 COMMAND: "crash"
> CPU 1: 66789719628339
> [67393251858710] PID: 14769 TASK: f4bdc030 COMMAND: "crash"
>
> Do you have any other suggestion or requirement?

No, that's fine.

I did make a slight change to the output display so that the task's
timestamp value is directly under the cpu's value and without the
brackets, making a comparison much easier. I also re-worded the help
page description, and added the display of the new rq_timestamp offset
value in dump_offset_table().

The patch is queued for crash-6.0.7.

Thanks,
Dave

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility


All times are GMT. The time now is 07:10 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.