FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Crash Utility

 
 
LinkBack Thread Tools
 
Old 01-01-1970, 01:00 AM
HATAYAMA Daisuke
 
Default crash gcore command, version 1.1 available

From: Dave Anderson <anderson@redhat.com>
Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1 available
Date: Thu, 22 Mar 2012 11:23:36 -0400 (EDT)

> Can you please format the crash-gcore-command-1.1.tar.gz file in
> the same manner as crash-gcore-command-1.0.tar.gz? Here is the
> current version:

Thanks for pointing out that, Dave. I attached new one.

And for Lei, I made bigger fault that I missed arm source
file... Could you confirm that the new one can work on arm
environment?

Thanks.
HATAYAMA, Daisuke
--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 01-01-1970, 01:00 AM
HATAYAMA Daisuke
 
Default crash gcore command, version 1.1 available

Hello Lei,

From: Lei Wen <leiwen@marvell.com>
Subject: RE: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1 available
Date: Fri, 23 Mar 2012 07:15:31 -0700

> Hi HATAYAMA,
>
>> -----Original Message-----
>> From: HATAYAMA Daisuke [mailto:d.hatayama@jp.fujitsu.com]
>> Sent: Friday, March 23, 2012 8:38 AM
>> To: crash-utility@redhat.com; Lei Wen
>> Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1
>> available
>>
>> From: Dave Anderson <anderson@redhat.com>
>> Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1
>> available
>> Date: Thu, 22 Mar 2012 11:23:36 -0400 (EDT)
>>
>> > Can you please format the crash-gcore-command-1.1.tar.gz file in
>> > the same manner as crash-gcore-command-1.0.tar.gz? Here is the
>> > current version:
>>
>> Thanks for pointing out that, Dave. I attached new one.
>>
>> And for Lei, I made bigger fault that I missed arm source
>> file... Could you confirm that the new one can work on arm
>> environment?
>
> Yes, this version works for me.
>

I see.

> However, I think there is a point may need to be enhanced:
> diff --git a/extensions/libgcore/gcore_coredump.c b/extensions/libgcore/gcore_coredump.c
> index e2d9941..fec8ffc 100644
> --- a/extensions/libgcore/gcore_coredump.c
> +++ b/extensions/libgcore/gcore_coredump.c
> @@ -200,7 +200,8 @@ void gcore_coredump(void)
> "readmem vma list",
> gcore_verbose_error_handle());
> } else {
> - pagefaultf("page fault at %lx
", addr);
> + if (paddr == PADDR_NOT_AVAILABLE)
> + pagefaultf("page fault at %lx
", addr);
> BZERO(buffer, PAGE_SIZE);
> }
>
> Without this, I would see many " page fault at XXX" for the lazy mapping as we talked in the previous thread:
> http://www.redhat.com/archives/crash-utility/2012-February/msg00112.html
>

As Dave explains, gcore needs to inform users of the fact that some
part of memory is lost. However, it is cerntain that currnet
implementation displays ``page fault' even for the pages that should
be displayed differently. I want to change the message for such pages
to proper one.

Also, to be honest, I didn't know PADDR_NOT_AVAILABLE. Looking at
source code, it appears to be used in Xen path. I have yet to know
whether or not to use the macro. I'll consider it more.

BTW, if you feel the page-fault message noisy, please use -v 0. Then,
gcore doesn't say almost anything.

Thanks.
HATAYAMA, Daisuke

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 01-01-1970, 01:00 AM
HATAYAMA Daisuke
 
Default crash gcore command, version 1.1 available

From: Dave Anderson <anderson@redhat.com>
Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1 available
Date: Fri, 23 Mar 2012 11:26:06 -0400 (EDT)

>
>
> ----- Original Message -----
>> Hi HATAYAMA,
>>
>> > -----Original Message-----
>> > From: HATAYAMA Daisuke [mailto:d.hatayama@jp.fujitsu.com]
>> > Sent: Friday, March 23, 2012 8:38 AM
>> > To: crash-utility@redhat.com; Lei Wen
>> > Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command,
>> > version 1.1
>> > available
>> >
>> > From: Dave Anderson <anderson@redhat.com>
>> > Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command,
>> > version 1.1
>> > available
>> > Date: Thu, 22 Mar 2012 11:23:36 -0400 (EDT)
>> >
>> > > Can you please format the crash-gcore-command-1.1.tar.gz file in
>> > > the same manner as crash-gcore-command-1.0.tar.gz? Here is the
>> > > current version:
>> >
>> > Thanks for pointing out that, Dave. I attached new one.
>> >
>> > And for Lei, I made bigger fault that I missed arm source
>> > file... Could you confirm that the new one can work on arm
>> > environment?
>>
>> Yes, this version works for me.
>>
>> However, I think there is a point may need to be enhanced:
>> diff --git a/extensions/libgcore/gcore_coredump.c
>> b/extensions/libgcore/gcore_coredump.c
>> index e2d9941..fec8ffc 100644
>> --- a/extensions/libgcore/gcore_coredump.c
>> +++ b/extensions/libgcore/gcore_coredump.c
>> @@ -200,7 +200,8 @@ void gcore_coredump(void)
>> "readmem vma list",
>> gcore_verbose_error_handle());
>> } else {
>> - pagefaultf("page fault at %lx
", addr);
>> + if (paddr == PADDR_NOT_AVAILABLE)
>> + pagefaultf("page fault at %lx
", addr);
>> BZERO(buffer, PAGE_SIZE);
>> }
>>
>> Without this, I would see many " page fault at XXX" for the lazy
>> mapping as we talked in the previous thread:
>> http://www.redhat.com/archives/crash-utility/2012-February/msg00112.html
>
> Given Daisuke's reply in http://www.redhat.com/archives/crash-utility/2012-February/msg00113.html:
>
> I overlooked lazy allocation case in my explanation... In this sense,
> the warning message might be unkind to users. Still, there's a way of
> checking each page's status by a variety of crash sub-commands.
>
> I was under the impression that Daisuke would prefer to keep the messages
> in place in order to give the user notification that those pages are not
> accessible. But I may have misunderstood his intentions.
>
> In any case, since the new version functions correctly, I have posted
> the version 1.1 on the extensions page.
>
> Thanks,
> Dave
>

Thanks for your explanation, Dave.

I feel need to explain to users that what gcore can do and what cannot
do. Some people, in particular who are not OS guys, tend to believe
that gcore collects everything. I'll write some documentation for such
explanation.

Thanks.
HATAYAMA, Daisuke

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 03-23-2012, 01:15 PM
Lei Wen
 
Default crash gcore command, version 1.1 available

Hi HATAYAMA,

> -----Original Message-----
> From: HATAYAMA Daisuke [mailto:d.hatayama@jp.fujitsu.com]
> Sent: Friday, March 23, 2012 8:38 AM
> To: crash-utility@redhat.com; Lei Wen
> Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1
> available
>
> From: Dave Anderson <anderson@redhat.com>
> Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1
> available
> Date: Thu, 22 Mar 2012 11:23:36 -0400 (EDT)
>
> > Can you please format the crash-gcore-command-1.1.tar.gz file in
> > the same manner as crash-gcore-command-1.0.tar.gz? Here is the
> > current version:
>
> Thanks for pointing out that, Dave. I attached new one.
>
> And for Lei, I made bigger fault that I missed arm source
> file... Could you confirm that the new one can work on arm
> environment?

Yes, this version works for me.

However, I think there is a point may need to be enhanced:
diff --git a/extensions/libgcore/gcore_coredump.c b/extensions/libgcore/gcore_coredump.c
index e2d9941..fec8ffc 100644
--- a/extensions/libgcore/gcore_coredump.c
+++ b/extensions/libgcore/gcore_coredump.c
@@ -200,7 +200,8 @@ void gcore_coredump(void)
"readmem vma list",
gcore_verbose_error_handle());
} else {
- pagefaultf("page fault at %lx
", addr);
+ if (paddr == PADDR_NOT_AVAILABLE)
+ pagefaultf("page fault at %lx
", addr);
BZERO(buffer, PAGE_SIZE);
}

Without this, I would see many " page fault at XXX" for the lazy mapping as we talked in the previous thread:
http://www.redhat.com/archives/crash-utility/2012-February/msg00112.html


>
> Thanks.
> HATAYAMA, Daisuke

Thanks,
Lei

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 03-26-2012, 01:26 AM
Lei Wen
 
Default crash gcore command, version 1.1 available

Hi HATAYAMA,

> -----Original Message-----
> From: HATAYAMA Daisuke [mailto:d.hatayama@jp.fujitsu.com]
> Sent: Monday, March 26, 2012 8:13 AM
> To: Lei Wen
> Cc: crash-utility@redhat.com
> Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1
> available
>
> Hello Lei,
>
> From: Lei Wen <leiwen@marvell.com>
> Subject: RE: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1
> available
> Date: Fri, 23 Mar 2012 07:15:31 -0700
>
> > Hi HATAYAMA,
> >
> >> -----Original Message-----
> >> From: HATAYAMA Daisuke [mailto:d.hatayama@jp.fujitsu.com]
> >> Sent: Friday, March 23, 2012 8:38 AM
> >> To: crash-utility@redhat.com; Lei Wen
> >> Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1
> >> available
> >>
> >> From: Dave Anderson <anderson@redhat.com>
> >> Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1
> >> available
> >> Date: Thu, 22 Mar 2012 11:23:36 -0400 (EDT)
> >>
> >> > Can you please format the crash-gcore-command-1.1.tar.gz file in
> >> > the same manner as crash-gcore-command-1.0.tar.gz? Here is the
> >> > current version:
> >>
> >> Thanks for pointing out that, Dave. I attached new one.
> >>
> >> And for Lei, I made bigger fault that I missed arm source
> >> file... Could you confirm that the new one can work on arm
> >> environment?
> >
> > Yes, this version works for me.
> >
>
> I see.
>
> > However, I think there is a point may need to be enhanced:
> > diff --git a/extensions/libgcore/gcore_coredump.c
> b/extensions/libgcore/gcore_coredump.c
> > index e2d9941..fec8ffc 100644
> > --- a/extensions/libgcore/gcore_coredump.c
> > +++ b/extensions/libgcore/gcore_coredump.c
> > @@ -200,7 +200,8 @@ void gcore_coredump(void)
> > "readmem vma list",
> > gcore_verbose_error_handle());
> > } else {
> > - pagefaultf("page fault at %lx
", addr);
> > + if (paddr == PADDR_NOT_AVAILABLE)
> > + pagefaultf("page fault at %lx
",
> addr);
> > BZERO(buffer, PAGE_SIZE);
> > }
> >
> > Without this, I would see many " page fault at XXX" for the lazy mapping as
> we talked in the previous thread:
> > http://www.redhat.com/archives/crash-utility/2012-February/msg00112.html
> >
>
> As Dave explains, gcore needs to inform users of the fact that some
> part of memory is lost. However, it is cerntain that currnet
> implementation displays ``page fault' even for the pages that should
> be displayed differently. I want to change the message for such pages
> to proper one.
>
> Also, to be honest, I didn't know PADDR_NOT_AVAILABLE. Looking at
> source code, it appears to be used in Xen path. I have yet to know
> whether or not to use the macro. I'll consider it more.
>
> BTW, if you feel the page-fault message noisy, please use -v 0. Then,
> gcore doesn't say almost anything.

Yep, this way sounds good to me.

>
> Thanks.
> HATAYAMA, Daisuke

Thanks,
Lei


--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 

Thread Tools




All times are GMT. The time now is 09:18 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org