FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Crash Utility

 
 
LinkBack Thread Tools
 
Old 01-19-2012, 01:52 PM
Dave Anderson
 
Default add option -s and -S for subcommand irq

----- Original Message -----
> Hi,
>
> I can confirm that hooking in generic_show_interrupts() and
> generic_get_irq_affinity() results in meaningful output for ARM as
> well, using PATCH v3.

OK good, I'll add that. I'll change the machine_type() iteration into
"if (machdep->show_interrupts)" and "if (machdep->get_irq_affinity)"
before it gets out of hand...

>
> I've got another suggestion however. How about mimicking the kernel
> code a little closer?
>
> fs/proc/interrupts.c
>
> will keep going for one more iteration, i.e. while <=nr_irqs and
>
> kernel/irq/proc.c:show_interrupts()
>
> will call arch_show_interrupts() when called with ==nr_irqs.
>
> In Crash we could do this in cmd_irq
>
> for (i = 0; i <= nr_irqs; i++)
> machdep->show_interrupts(i, cpus);
>
> and this at the start of generic_show_interrupts():
>
> if (irq >= machdep->nr_irqs) {
> return;
> }
>
> making it possible to have machdep->show_interrupts point to a wrapper
> function like:
>
> static void arm_show_interrupts(int irq, ulong *cpus)
> {
> if (irq == machdep->nr_irqs) {
> // Show FIQ
> // Show IPI
> }
> else {
> generic_show_interrupts(irq, cpus);
> }
> }
>
> Just an idea.
>
> Regards,
> Per

How about we get this patch into place first, and then you can
post a patch after crash-6.0.3 is released.

Thanks,
Dave

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 

Thread Tools




All times are GMT. The time now is 07:17 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org