Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Crash Utility (http://www.linux-archive.org/crash-utility/)
-   -   Compressed KDUMP core analysis support for PPC32 (http://www.linux-archive.org/crash-utility/622603-compressed-kdump-core-analysis-support-ppc32.html)

"Suzuki K. Poulose" 01-19-2012 04:55 AM

Compressed KDUMP core analysis support for PPC32
 
Suzuki K. Poulose wrote:

Dave Anderson wrote:



----- Original Message -----


I don't feel comfortable accepting this piece as is -- can you
restrict it to just PPC?:

--- a/netdump.c
+++ b/netdump.c
@@ -1696,6 +1696,8 @@ dump_Elf32_Nhdr(Elf32_Off offset, int store)
}
}
}
+ if (nd->num_prstatus_notes> 0)
+ pc->flags2 |= ELF_NOTES;
break;
case NT_PRPSINFO:
netdump_print("(NT_PRPSINFO)
");



Actually, for that matter, why is it even there? You're already
setting ELF_NOTES in ppc_process_elf_notes() the same way
that the X86 does it in x86_process_elf_notes().


ppc_process_elf_notes is called only for diskdump, not for netdump.
And all the process_elf_notes(), update the diskdump_data->nt_prstatus_percpu[],
which(dd) is not available in the arch specific files.


For netdump we don't end up calling the ppc_process_elf_notes(), which is true
for any other archs. I am setting this for the netdump case, so that we can reuse
the same function for stack frame from the pt_regs.

Thanks
Suzuki

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility


All times are GMT. The time now is 07:37 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.