when tracking full slabs, check kmem_cache flag
i-kitayama@ap.jp.nec.com wrote:
Hi Dave,
Thanks for reviewing.
For 2.6.22 only, kmem_cache_node.full is always there, so in that
case, the SLAB_STORE_USER flag would never get checked above, and
the full slab would be shown as "(empty)".
And for 2.6.23 kernels and above, the SLAB_STORE_USER flag
would *only* be checked if CONFIG_SLUB_DEBUG was *not* set.
And if CONFIG_SLUB_DEBUG is not set, then full slabs would not
be tracked because add_full() is a no-op -- regardless whether
the SLAB_STORE_USER flag was set or not.
Shouldn't it be "||" instead of "&&"?
Right. I have attached the modified patch.
Itaru
I've made a couple additions (patch attached), but the
logic is the same -- queued for the next release.
Thanks,
Dave
--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
|
