FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Crash Utility

 
 
LinkBack Thread Tools
 
Old 02-08-2011, 08:05 AM
Ales Kozumplik
 
Default fwparam_sysfs: fix pathname manipulation error in fwparam_sysfs_boot_info.

A slash was missing in the pathname producing nonexistent filenames
starting with "/sys/firmwareiscsi_boot5" instead of
"/sys/firmware/iscsi_boot5". Also see fwparam_sysfs_get_targets().
---
utils/fwparam_ibft/fwparam_sysfs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/utils/fwparam_ibft/fwparam_sysfs.c b/utils/fwparam_ibft/fwparam_sysfs.c
index b5568c5..3997363 100644
--- a/utils/fwparam_ibft/fwparam_sysfs.c
+++ b/utils/fwparam_ibft/fwparam_sysfs.c
@@ -365,7 +365,7 @@ int fwparam_sysfs_boot_info(struct boot_context *context)
if (strncmp(dent->d_name, ISCSI_LLD_SUBSYS_PREFIX, 10))
continue;

- snprintf(lld_root, FILENAMESZ, ISCSI_LLD_ROOT"%s",
+ snprintf(lld_root, FILENAMESZ, ISCSI_LLD_ROOT"%s/",
dent->d_name);
if (!get_boot_info(context, lld_root, dent->d_name))
goto done;
--
1.7.3.3

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 02-09-2011, 04:04 AM
Mike Christie
 
Default fwparam_sysfs: fix pathname manipulation error in fwparam_sysfs_boot_info.

On 02/08/2011 03:05 AM, Ales Kozumplik wrote:

A slash was missing in the pathname producing nonexistent filenames
starting with "/sys/firmwareiscsi_boot5" instead of
"/sys/firmware/iscsi_boot5". Also see fwparam_sysfs_get_targets().
---
utils/fwparam_ibft/fwparam_sysfs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/utils/fwparam_ibft/fwparam_sysfs.c b/utils/fwparam_ibft/fwparam_sysfs.c
index b5568c5..3997363 100644
--- a/utils/fwparam_ibft/fwparam_sysfs.c
+++ b/utils/fwparam_ibft/fwparam_sysfs.c
@@ -365,7 +365,7 @@ int fwparam_sysfs_boot_info(struct boot_context *context)
if (strncmp(dent->d_name, ISCSI_LLD_SUBSYS_PREFIX, 10))
continue;

- snprintf(lld_root, FILENAMESZ, ISCSI_LLD_ROOT"%s",
+ snprintf(lld_root, FILENAMESZ, ISCSI_LLD_ROOT"%s/",
dent->d_name);
if (!get_boot_info(context, lld_root, dent->d_name))
goto done;


Ah shoot. Missed that. Nice catch and thanks. Merged.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 04:33 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org