Crash-utility mailing list
01-28-2011, 08:21 PM
Cleanup: GDB does not need struct syment
----- Original Message -----
> The syment struct is not used for anything by the embedded GDB,
> so we can remove it completely.
> Signed-off-by: Petr Tesarik <email@example.com>
There is a capability that allows you to continue to use an older
version of gdb with the current crash sources. That's what the
setup_gdb_defaults() function in configure.c does if there's
a ".gdb" file placed in the top-level directory. And given the
fact that gdb-6.1 and earlier does need the struct syment declaration,
defs.h can't be changed.
But yes, the declarations in gdb-7.0/gdb/symtab.c are superfluous.
I never noticed -- I would have thought that the -Wall in the
gdb compile line would complain about it, but it doesn't.
Anyway, when changing the gdb-7.0-patch, I prefer that the patch
be added to the end of the file as a discrete diff, especially
since there is already a subsequent change to symtab.c. I'll
do that, so consider the symtab.c part of your patch queued for