FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Crash Utility

 
 
LinkBack Thread Tools
 
Old 01-28-2011, 07:17 AM
Mika Westerberg
 
Default ARM: update some comments

There are few comments which are not relevant anymore. Update the
comments to reflect the current situation.

Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
---
arm.c | 3 ---
unwind_arm.c | 5 ++---
2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/arm.c b/arm.c
index 4e6ab3d..1752f62 100644
--- a/arm.c
+++ b/arm.c
@@ -1048,9 +1048,6 @@ arm_get_frame(struct bt_info *bt, ulong *pcp, ulong *spp)

/*
* Get the starting point for the active cpu in a diskdump.
- *
- * Note that we currently support only UP machines. In future we might want to
- * support SMP machines as well.
*/
static int
arm_get_dumpfile_stack_frame(struct bt_info *bt, ulong *nip, ulong *ksp)
diff --git a/unwind_arm.c b/unwind_arm.c
index 58fb5da..18fdad9 100644
--- a/unwind_arm.c
+++ b/unwind_arm.c
@@ -250,9 +250,8 @@ read_module_unwind_table(struct unwind_table *tbl, ulong addr)
idx_size = idx_stop - idx_start;

/*
- * We know the size of the index table. Allocate memory for the table
- * (including the EH table) and read the contents from the kernel
- * memory.
+ * We know the size of the index table. Allocate memory for
+ * the table and read the contents from the kernel memory.
*/
tbl->idx = calloc(idx_size, 1);
if (!tbl->idx)
--
1.7.3.2

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 01-28-2011, 02:15 PM
Dave Anderson
 
Default ARM: update some comments

----- Original Message -----
> There are few comments which are not relevant anymore. Update the
> comments to reflect the current situation.
>
> Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>

Now there's a nice safe patch -- queued for the next release.

Thanks,
Dave

> ---
> arm.c | 3 ---
> unwind_arm.c | 5 ++---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arm.c b/arm.c
> index 4e6ab3d..1752f62 100644
> --- a/arm.c
> +++ b/arm.c
> @@ -1048,9 +1048,6 @@ arm_get_frame(struct bt_info *bt, ulong *pcp,
> ulong *spp)
>
> /*
> * Get the starting point for the active cpu in a diskdump.
> - *
> - * Note that we currently support only UP machines. In future we might want to
> - * support SMP machines as well.
> */
> static int
> arm_get_dumpfile_stack_frame(struct bt_info *bt, ulong *nip, ulong *ksp)
> diff --git a/unwind_arm.c b/unwind_arm.c
> index 58fb5da..18fdad9 100644
> --- a/unwind_arm.c
> +++ b/unwind_arm.c
> @@ -250,9 +250,8 @@ read_module_unwind_table(struct unwind_table *tbl,
> ulong addr)
> idx_size = idx_stop - idx_start;
>
> /*
> - * We know the size of the index table. Allocate memory for the table
> - * (including the EH table) and read the contents from the kernel
> - * memory.
> + * We know the size of the index table. Allocate memory for
> + * the table and read the contents from the kernel memory.
> */
> tbl->idx = calloc(idx_size, 1);
> if (!tbl->idx)
> --
> 1.7.3.2
>
> --
> Crash-utility mailing list
> Crash-utility@redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 

Thread Tools




All times are GMT. The time now is 08:36 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org