Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Crash Utility (http://www.linux-archive.org/crash-utility/)
-   -   Remove 'Change device' button from bootloader screen on EFI systems (#582143) (http://www.linux-archive.org/crash-utility/481994-remove-change-device-button-bootloader-screen-efi-systems-582143-a.html)

John Reiser 01-27-2011 05:46 PM

Remove 'Change device' button from bootloader screen on EFI systems (#582143)
 
On 01/27/2011 10:32 AM, Will Woods wrote:
> EFI systems don't need to mess with 'BIOS Drive Order' and they can really
> only install the bootloader in one place (the EFI System Partition),

Are you sure? When I install fedora to an external drive on an Apple Macintosh
system, then I see two "EFI System Partition"s, namely one on the internal drive
and one on the external drive. I want my choice?

--

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

David Cantrell 01-27-2011 05:51 PM

Remove 'Change device' button from bootloader screen on EFI systems (#582143)
 
On Thu, 27 Jan 2011, Will Woods wrote:


EFI systems don't need to mess with 'BIOS Drive Order' and they can really
only install the bootloader in one place (the EFI System Partition), so
this button is useless during EFI installs. Remove it to avoid confusion.

Resolves: rhbz#582143
---
iw/bootloader_main_gui.py | 14 ++++++++++----
1 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/iw/bootloader_main_gui.py b/iw/bootloader_main_gui.py
index fa5d554..a616a76 100644
--- a/iw/bootloader_main_gui.py
+++ b/iw/bootloader_main_gui.py
@@ -22,6 +22,7 @@
import gtk
import gobject
import gui
+import iutil
from iw_gui import *
from constants import *

@@ -73,7 +74,8 @@ class MainBootloaderWindow(InstallWindow):
active = self.grubCB.get_active()

for widget in [ self.oslist.getWidget(), self.blpass.getWidget(), self.deviceButton ]:
- widget.set_sensitive(active)
+ if widget:
+ widget.set_sensitive(active)


def _deviceChange(self, b, anaconda, *args):
@@ -226,9 +228,13 @@ class MainBootloaderWindow(InstallWindow):
self.grubCB.connect("toggled", self.bootloaderChanged)
hb.pack_start(self.grubCB, False)

- self.deviceButton = gtk.Button(_("_Change device"))
- self.deviceButton.connect("clicked", self._deviceChange, anaconda)
- hb.pack_start(self.deviceButton, False)
+ # no "Change device" button on EFI systems, since there should only
+ # be one EFI System Partition available/usable
+ self.deviceButton = None
+ if not iutil.isEfi():
+ self.deviceButton = gtk.Button(_("_Change device"))
+ self.deviceButton.connect("clicked", self._deviceChange, anaconda)
+ hb.pack_start(self.deviceButton, False)

thebox.pack_start(hb, False)




Ack.

--
David Cantrell <dcantrell@redhat.com>
Supervisor, Installer Engineering Team
Red Hat, Inc. | Honolulu, HI | UTC-10

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


All times are GMT. The time now is 09:05 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.