FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.

» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Crash Utility

LinkBack Thread Tools
Old 01-21-2011, 06:37 PM
Dave Anderson
Default ikconfig and load module helperpatches.

----- Original Message -----

> The access of the ikconfig data is really nothing much more
> than a typical memory read, although it does have to be
> uncompressed.
> But, think about it, when running against a compressed
> diskump or compressed kdump dumpfile, every memory access
> has to be uncompressed.
> Let me review/test your patch #1, and I'll get back to you
> with my results.

Hello Toshi,

I made a couple fixes to your patch -- get_kernel_config() always failed
because the "return ret" below always gets executed, returning IKCFG_N,
and the second test for IKCONFIG_LOADED is missing the parentheses:

+ } else if (!(kt->ikconfig_flags & IKCONFIG_LOADED)) {
+ read_in_kernel_config(IKCFG_SETUP);
+ ===> if (!kt->ikconfig_flags & IKCONFIG_LOADED)
+ error(WARNING,
+ "Failed read_in_kernel_config(IKCFG_SETUP)
+ ===> return ret;

I also made the dump_kernel_table() display of the kt->ikconfig_flags a bit
more informative, and changed a couple of the error messages slightly.

Thanks for the contribution -- it's queued for the next release.


Crash-utility mailing list

Thread Tools

All times are GMT. The time now is 07:32 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org