FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Crash Utility

 
 
LinkBack Thread Tools
 
Old 11-16-2010, 12:51 AM
Mahesh J Salgaonkar
 
Default Crash-Utility: crash enhancement to support s390x diskdump

Hi All,

There was problem in my earlier posting. I had miss-spelled my id in the
From: field. Hence resending it again.

Please find the version 3 of crash patchset that enables crash utility to read
s390x diskdump (DUMPFILE generated by makedumpfile).

The first patch enhances crash utility to read elf notes section from
DUMPFILE if Kdump header >= 4.

The second patch adds crash support to read s390x diskdump. This patch also
implements new arch dependent interface process_elf_notes() to read CPU
register infromation stored in ELF notes section.

Change v3:
- Re-based to crash-5.0.9

Change v2:
- Re-based to crash-5.0.8
- Modified __diskdump_memory_dump() function to display contents of
all 4 additional fields in the kdump_sub_header.
- Modified __diskdump_memory_dump() to dump the vmcoreinfo ASCII strings.

Please review the changes and send in your comments.

Thanks,
-Mahesh.
--
Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 11-16-2010, 06:30 PM
Dave Anderson
 
Default Crash-Utility: crash enhancement to support s390x diskdump

----- "Mahesh J Salgaonkar" <mahesh@linux.vnet.ibm.com> wrote:

> Hi All,
>
> There was problem in my earlier posting. I had miss-spelled my id in the
> From: field. Hence resending it again.
>
> Please find the version 3 of crash patchset that enables crash utility to read
> s390x diskdump (DUMPFILE generated by makedumpfile).
>
> The first patch enhances crash utility to read elf notes section from
> DUMPFILE if Kdump header >= 4.
>
> The second patch adds crash support to read s390x diskdump. This patch also
> implements new arch dependent interface process_elf_notes() to read CPU
> register infromation stored in ELF notes section.
>
> Change v3:
> - Re-based to crash-5.0.9
>
> Change v2:
> - Re-based to crash-5.0.8
> - Modified __diskdump_memory_dump() function to display contents of
> all 4 additional fields in the kdump_sub_header.
> - Modified __diskdump_memory_dump() to dump the vmcoreinfo ASCII strings.
>
> Please review the changes and send in your comments.

Hello Mahesh,

The patch-set looks good so far, except for one minor nit.

Why is "S390" accepted as legitimate here in read_dump_header()?

@@ -349,6 +352,10 @@ restart:
dd->machine_type = EM_IA_64;
else if (machine_type("PPC64"))
dd->machine_type = EM_PPC64;
+ else if (machine_type("S390"))
+ dd->machine_type = EM_S390;
+ else if (machine_type("S390X"))
+ dd->machine_type = EM_S390;
else {
error(INFO, "%s: unsupported machine type: %s
",
DISKDUMP_VALID() ? "diskdump" : "compressed kdump",

In any case, the only thing I can test at this point is that the
vmcoreinfo ASCII data gets dumped -- and thanks for adding that BTW.

When I get access to, and test with, your sample s390x vmlinux/vmcore
pairs that I requested off-list, I'll confirm that the patch is queued
for the next release.

Thanks,
Dave

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 11-17-2010, 08:16 AM
Michael Holzheu
 
Default Crash-Utility: crash enhancement to support s390x diskdump

Hello Dave,

Dave Anderson <anderson@redhat.com> wrote on 11/16/2010 20:30:48:
> > Please review the changes and send in your comments.
>
> Hello Mahesh,
>
> The patch-set looks good so far, except for one minor nit.
>
> Why is "S390" accepted as legitimate here in read_dump_header()?
>
> @@ -349,6 +352,10 @@ restart:
> dd->machine_type = EM_IA_64;
> else if (machine_type("PPC64"))
> dd->machine_type = EM_PPC64;
> + else if (machine_type("S390"))
> + dd->machine_type = EM_S390;
> + else if (machine_type("S390X"))
> + dd->machine_type = EM_S390;
> else {
> error(INFO, "%s: unsupported machine type: %s
",
> DISKDUMP_VALID() ? "diskdump" : "compressed
kdump",
>

Correct, machine_type("S390") can be removed, because we currently>
can't have s390 31 bit ELF dumps or kdumps. And probably will never
have.

Michael

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 11-18-2010, 10:55 AM
Mahesh Jagannath Salgaonkar
 
Default Crash-Utility: crash enhancement to support s390x diskdump

On 11/17/2010 02:46 PM, Michael Holzheu wrote:
> Hello Dave,
>
> Dave Anderson <anderson@redhat.com> wrote on 11/16/2010 20:30:48:
>>> Please review the changes and send in your comments.
>>
>> Hello Mahesh,
>>
>> The patch-set looks good so far, except for one minor nit.
>>
>> Why is "S390" accepted as legitimate here in read_dump_header()?
>>
>> @@ -349,6 +352,10 @@ restart:
>> dd->machine_type = EM_IA_64;
>> else if (machine_type("PPC64"))
>> dd->machine_type = EM_PPC64;
>> + else if (machine_type("S390"))
>> + dd->machine_type = EM_S390;
>> + else if (machine_type("S390X"))
>> + dd->machine_type = EM_S390;
>> else {
>> error(INFO, "%s: unsupported machine type: %s
",
>> DISKDUMP_VALID() ? "diskdump" : "compressed
> kdump",
>>
>
> Correct, machine_type("S390") can be removed, because we currently>
> can't have s390 31 bit ELF dumps or kdumps. And probably will never
> have.
>
> Michael
>
Will remove the machine_type("S390") and roll out new version of the patch.

Thanks,
-Mahesh.

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 11-18-2010, 12:47 PM
Dave Anderson
 
Default Crash-Utility: crash enhancement to support s390x diskdump

----- "Mahesh Jagannath Salgaonkar" <mahesh@linux.vnet.ibm.com> wrote:

> On 11/17/2010 02:46 PM, Michael Holzheu wrote:
> > Hello Dave,
> >
> > Dave Anderson <anderson@redhat.com> wrote on 11/16/2010 20:30:48:
> >>> Please review the changes and send in your comments.
> >>
> >> Hello Mahesh,
> >>
> >> The patch-set looks good so far, except for one minor nit.
> >>
> >> Why is "S390" accepted as legitimate here in read_dump_header()?
> >>
> >> @@ -349,6 +352,10 @@ restart:
> >> dd->machine_type = EM_IA_64;
> >> else if (machine_type("PPC64"))
> >> dd->machine_type = EM_PPC64;
> >> + else if (machine_type("S390"))
> >> + dd->machine_type = EM_S390;
> >> + else if (machine_type("S390X"))
> >> + dd->machine_type = EM_S390;
> >> else {
> >> error(INFO, "%s: unsupported machine type:
> %s
",
> >> DISKDUMP_VALID() ? "diskdump" : "compressed kdump",
> >>
> >
> > Correct, machine_type("S390") can be removed, because we currently>
> > can't have s390 31 bit ELF dumps or kdumps. And probably will never
> > have.
> >
> > Michael
> >
> Will remove the machine_type("S390") and roll out new version of the
> patch.
>
> Thanks,
> -Mahesh.

Hi Mahesh,

There's really no need to do that -- I can do it unless there are other
changes you need to make. I'm just waiting for somebody to make your two
dumpfiles available for me to download before I queue it for the next
release.

Thanks,
Dave

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 11-18-2010, 03:43 PM
Mahesh Jagannath Salgaonkar
 
Default Crash-Utility: crash enhancement to support s390x diskdump

On 11/18/2010 07:17 PM, Dave Anderson wrote:
>
> ----- "Mahesh Jagannath Salgaonkar" <mahesh@linux.vnet.ibm.com> wrote:
>
>> On 11/17/2010 02:46 PM, Michael Holzheu wrote:
>>> Hello Dave,
>>>
>>> Dave Anderson <anderson@redhat.com> wrote on 11/16/2010 20:30:48:
>>>>> Please review the changes and send in your comments.
>>>>
>>>> Hello Mahesh,
>>>>
>>>> The patch-set looks good so far, except for one minor nit.
>>>>
>>>> Why is "S390" accepted as legitimate here in read_dump_header()?
>>>>
>>>> @@ -349,6 +352,10 @@ restart:
>>>> dd->machine_type = EM_IA_64;
>>>> else if (machine_type("PPC64"))
>>>> dd->machine_type = EM_PPC64;
>>>> + else if (machine_type("S390"))
>>>> + dd->machine_type = EM_S390;
>>>> + else if (machine_type("S390X"))
>>>> + dd->machine_type = EM_S390;
>>>> else {
>>>> error(INFO, "%s: unsupported machine type:
>> %s
",
>>>> DISKDUMP_VALID() ? "diskdump" : "compressed kdump",
>>>>
>>>
>>> Correct, machine_type("S390") can be removed, because we currently>
>>> can't have s390 31 bit ELF dumps or kdumps. And probably will never
>>> have.
>>>
>>> Michael
>>>
>> Will remove the machine_type("S390") and roll out new version of the
>> patch.
>>
>> Thanks,
>> -Mahesh.
>
> Hi Mahesh,
>
> There's really no need to do that -- I can do it unless there are other
> changes you need to make. I'm just waiting for somebody to make your two
> dumpfiles available for me to download before I queue it for the next
> release.
>
> Thanks,
> Dave

Thanks Dave. I have placed the dumpfiles on a different server and given
read access to Steve Best, he now should be able to get the files
available to you.

Thanks,
-Mahesh.

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 11-18-2010, 06:22 PM
Dave Anderson
 
Default Crash-Utility: crash enhancement to support s390x diskdump

----- "Mahesh Jagannath Salgaonkar" <mahesh@linux.vnet.ibm.com> wrote:

>
> Thanks Dave. I have placed the dumpfiles on a different server and given
> read access to Steve Best, he now should be able to get the files
> available to you.
>
> Thanks,
> -Mahesh.

Thanks -- I've got the files, and the patch works as expected.

The only question I have is that the vmcoreinfo data is not
contained in the 3 compressed kdump files, whereas I do see it
with newer x86_64 compressed kdumps. Is that to be expected?

Dave

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 11-19-2010, 04:22 AM
Mahesh Jagannath Salgaonkar
 
Default Crash-Utility: crash enhancement to support s390x diskdump

On 11/19/2010 12:52 AM, Dave Anderson wrote:
>
> ----- "Mahesh Jagannath Salgaonkar" <mahesh@linux.vnet.ibm.com> wrote:
>
>>
>> Thanks Dave. I have placed the dumpfiles on a different server and given
>> read access to Steve Best, he now should be able to get the files
>> available to you.
>>
>> Thanks,
>> -Mahesh.
>
> Thanks -- I've got the files, and the patch works as expected.
>
> The only question I have is that the vmcoreinfo data is not
> contained in the 3 compressed kdump files, whereas I do see it
> with newer x86_64 compressed kdumps. Is that to be expected?
>
> Dave
>
Hi Dave,

Yup, that is expected. makedumpfile copies the vmcoreinfo into
compressed kdump file only if it is available in ELF vmcore. As of now
the s390x vmcore does not contain vmcoreinfo data and hence makedumpfile
does not populate it in compressed kdump file. In future when s390x
dumps starts including vmcoreinfo data, the makedumpfile will also
transfer it to compressed kdump file with it's existing logic.

Thanks,
-Mahesh.

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 11-19-2010, 12:37 PM
Dave Anderson
 
Default Crash-Utility: crash enhancement to support s390x diskdump

----- "Mahesh Jagannath Salgaonkar" <mahesh@linux.vnet.ibm.com> wrote:

> On 11/19/2010 12:52 AM, Dave Anderson wrote:
> >
> > Thanks -- I've got the files, and the patch works as expected.
> >
> > The only question I have is that the vmcoreinfo data is not
> > contained in the 3 compressed kdump files, whereas I do see it
> > with newer x86_64 compressed kdumps. Is that to be expected?
> >
> > Dave
> >
> Hi Dave,
>
> Yup, that is expected. makedumpfile copies the vmcoreinfo into
> compressed kdump file only if it is available in ELF vmcore. As of now
> the s390x vmcore does not contain vmcoreinfo data and hence makedumpfile
> does not populate it in compressed kdump file. In future when s390x
> dumps starts including vmcoreinfo data, the makedumpfile will also
> transfer it to compressed kdump file with it's existing logic.

OK, good -- queued for the next release.

Thanks,
Dave

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 

Thread Tools




All times are GMT. The time now is 04:52 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org