FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Crash Utility

 
 
LinkBack Thread Tools
 
Old 01-19-2010, 07:16 PM
Hans de Goede
 
Default Remove unnecessary free from the rpmextract error handler

Ack.

On 01/19/2010 04:12 PM, Martin Sivak wrote:

libarchive lacks proper documentation of its memory management, but
it seems that it takes care of freeing the memory itself. So remove the
bogus free from our code.
---
loader/rpmextract.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/loader/rpmextract.c b/loader/rpmextract.c
index 64d5d7d..90af54c 100644
--- a/loader/rpmextract.c
+++ b/loader/rpmextract.c
@@ -282,7 +282,6 @@ int explodeRPM(const char *source,
FILE *fdout = fopen(filename+offset, "w");

if (fdout==NULL){
- free((void*)filename);
rc = 33;
break;
}


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 06:35 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org