FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Crash Utility

 
 
LinkBack Thread Tools
 
Old 01-12-2010, 07:10 PM
Bernhard Walle
 
Default Display "irqaction mask" only if available

Display "irqaction mask" only if available

The member "mask" has been removed from "struct irqaction" in the kernel per

commit ef79f8e191722dbc1fc33bdfc448f572266c37e9
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Thu Sep 24 09:34:37 2009 -0600

cpumask: remove unused mask field from struct irqaction.

Up until 1.1.83, the primitive human tribes used struct sigaction for
interrupts. The sa_mask field was overloaded to hold a pointer to the
name.

When someone created the new "struct irqaction" they carried across
the "mask" field as a kind of ancestor worship: the fact that it was
unused makes clear its spiritual significance.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

This patch only displays the "irqaction mask" in the "irq" command if the
member is present. It fixes the following error (kernel was 2.6.33):

crash> irq

irq: invalid structure member offset: irqaction_mask
FILE: kernel.c LINE: 5001 FUNCTION: generic_dump_irq()

[./crash.orig] error trace: 8097e44 => 8109541 => 810c0ec => 8156299


Signed-off-by: Bernhard Walle <bernhard@bwalle.de>

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 01-12-2010, 08:42 PM
Dave Anderson
 
Default Display "irqaction mask" only if available

----- "Bernhard Walle" <bernhard@bwalle.de> wrote:

> Display "irqaction mask" only if available
>
> The member "mask" has been removed from "struct irqaction" in the
> kernel per
>
> commit ef79f8e191722dbc1fc33bdfc448f572266c37e9
> Author: Rusty Russell <rusty@rustcorp.com.au>
> Date: Thu Sep 24 09:34:37 2009 -0600
>
> cpumask: remove unused mask field from struct irqaction.
>
> Up until 1.1.83, the primitive human tribes used struct sigaction for
> interrupts. The sa_mask field was overloaded to hold a pointer to the
> name.
>
> When someone created the new "struct irqaction" they carried across
> the "mask" field as a kind of ancestor worship: the fact that it was
> unused makes clear its spiritual significance.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> This patch only displays the "irqaction mask" in the "irq" command if the
> member is present. It fixes the following error (kernel was 2.6.33):
>
> crash> irq
>
> irq: invalid structure member offset: irqaction_mask
> FILE: kernel.c LINE: 5001 FUNCTION: generic_dump_irq()
>
> [./crash.orig] error trace: 8097e44 => 8109541 => 810c0ec => 8156299
>
>
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>

Thanks Bernhard -- queued for the next release.

Dave

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 

Thread Tools




All times are GMT. The time now is 11:45 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org